Properly print cstr literals in proc_macro::Literal::to_string
#116124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WaffleLapkin
added
A-proc-macros
|
r? @b-naber (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
WaffleLapkin
changed the title
proc_macro::Literal::to_stringproc_macro::Literal::to_string
|
r? @compiler-errors @bors r+ Thanks @WaffleLapkin |
bors
added
S-waiting-on-bors
|
cc @rust-lang/wg-macros since y'all mentioned wanting to be in the loop for libprocmacro-related changes, at least until there is auto-ping group for the WG. |
| @@ -1411,7 +1411,15 @@ impl Literal { | |||
| let hashes = get_hashes_str(n); | |||
| f(&["br", hashes, "\"", symbol, "\"", hashes, suffix]) | |||
| } | |||
| _ => f(&[symbol, suffix]), | |||
There was a problem hiding this comment.
making macros exhaustively match ❤️
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 25, 2023
…to-string, r=compiler-errors Properly print cstr literals in `proc_macro::Literal::to_string` Previously we printed the contents of the string, rather than the actual string literal (e.g. `the c string` instead of `c"the c string"`). Fixes rust-lang#112820 cc rust-lang#105723
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
Rustdoc overflowed on an unrelated test ( @bors retry |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 25, 2023
…to-string, r=compiler-errors Properly print cstr literals in `proc_macro::Literal::to_string` Previously we printed the contents of the string, rather than the actual string literal (e.g. `the c string` instead of `c"the c string"`). Fixes rust-lang#112820 cc rust-lang#105723
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors treeclosed=100 some bug with |
|
@bors retry |
bors
added
S-waiting-on-bors
|
A job failed! Check out the build log: (web) (plain) Click to see the possible cause of the failure (guessed by this bot) |
This was referenced Sep 25, 2023
|
@bors treeclosed- |
|
@compiler-errors does this need a rebase after #116147 or just @bors retry should be enough? |
|
We're good @bors retry |
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (a6dce3b): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 630.902s -> 630.463s (-0.07%) |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we printed the contents of the string, rather than the actual string literal (e.g.
the c stringinstead ofc"the c string").Fixes #112820
cc #105723