Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup in guide-testing.md #11614

Merged
merged 1 commit into from
Jan 18, 2014
Merged

Fixup in guide-testing.md #11614

merged 1 commit into from
Jan 18, 2014

Conversation

remen
Copy link
Contributor

@remen remen commented Jan 17, 2014

[cfg(test)] was being interpreted as starting a header

@@ -64,7 +64,7 @@ mod tests {
~~~

Additionally #[test] items behave as if they also have the
#[cfg(test)] attribute, and will not be compiled when the --test flag
\#[cfg(test)] attribute, and will not be compiled when the --test flag
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, maybe this should be wrapped in `'s, e.g.

`#[cfg(test)]` attribute ...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Oh, and might as well do the same to the #[test] on the previous line too.)

@alexcrichton
Copy link
Member

Could you rebase these commits into one?

Thanks for the fix!

Added back-quotes around #[cfg(test)] which was otherwise
being interpreted as starting a header
@remen
Copy link
Contributor Author

remen commented Jan 17, 2014

No problem. Rebased.

bors added a commit that referenced this pull request Jan 18, 2014
#[cfg(test)] was being interpreted as starting a header
@bors bors closed this Jan 18, 2014
@bors bors merged commit c6ad2de into rust-lang:master Jan 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants