Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize extended_varargs_abi_support #116161

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Stabilize extended_varargs_abi_support #116161

wants to merge 1 commit into from
+11 −118

Conversation

Soveu
Copy link
Contributor

@Soveu Soveu commented Sep 25, 2023

I think that is everything? If there is any documentation regarding extern and/or varargs to correct, let me know, some quick greps suggest that there might be none.

@rustbot
Copy link
Collaborator

rustbot commented Sep 25, 2023

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 25, 2023
@Soveu Soveu mentioned this pull request Sep 25, 2023
Open
3 tasks
@Soveu
Copy link
Contributor Author

Soveu commented Sep 25, 2023

@rustbot label F-extended_varargs_abi_support

@rustbot rustbot added the F-extended_varargs_abi_support `#![feature(extended_varargs_abi_support)]` label Sep 25, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
kadiwa4
kadiwa4 reviewed Sep 25, 2023
View reviewed changes
compiler/rustc_feature/src/accepted.rs Outdated
@@ -160,6 +160,9 @@ declare_features! (
(accepted, explicit_generic_args_with_impl_trait, "1.63.0", Some(83701), None),
/// Allows arbitrary expressions in key-value attributes at parse time.
(accepted, extended_key_value_attributes, "1.54.0", Some(78835), None),
/// Allows using `efiapi`, `aapcs`, `sysv64` and `win64` as calling
/// convention for functions with varargs.
(accepted, extended_varargs_abi_support, "1.65.0", Some(100189), None),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use CURRENT_RUSTC_VERSION instead of a version number here

@tgross35
Copy link
Contributor

tgross35 commented Oct 5, 2023

Tracking issue: #100189

@bors
Copy link
Contributor

bors commented Oct 16, 2023

☔ The latest upstream changes (presumably #116550) made this pull request unmergeable. Please resolve the merge conflicts.

@nicholasbishop nicholasbishop mentioned this pull request Nov 4, 2023
Open
3 tasks
@Soveu
Copy link
Contributor Author

Soveu commented Nov 21, 2023

@wesleywiser

@bors
Copy link
Contributor

bors commented Dec 11, 2023

☔ The latest upstream changes (presumably #118823) made this pull request unmergeable. Please resolve the merge conflicts.

@apiraino
Copy link
Contributor

r? compiler

@rustbot rustbot assigned Nadrieril and unassigned wesleywiser Feb 22, 2024
@Nadrieril
Copy link
Contributor

I'm on vacation for a few days :)
r? compiler

@rustbot rustbot assigned cjgillot and unassigned Nadrieril Feb 22, 2024
@cjgillot cjgillot added I-lang-nominated The issue / PR has been nominated for discussion during a lang team meeting. I-compiler-nominated The issue / PR has been nominated for discussion during a compiler team meeting. labels Mar 3, 2024
@cjgillot
Copy link
Contributor

cjgillot commented Mar 3, 2024

Not completely sure which team should be nominated for stabilization, so labeling both in doubt.

@pnkfelix
Copy link
Member

pnkfelix commented Mar 7, 2024 •
edited

Just to add on to @cjgillot 's comment above: @wesleywiser and I could not remember earlier today whether T-lang wants to own FCP'ing changes like this that are restricted to extending the set of calling-conventions (i.e. the conv in extern "conv" fn foo(...)), which is largely a detail about what platforms one is interoperating with, and not about changing the expressiveness of the Rust language as a whole in the abstract.

(My own gut reaction is that T-compiler is a more natural owner for this than T-lang, but I wasn't certain and so it seems best to let the nomination stand and let the two teams duke it out.)

@apiraino
Copy link
Contributor

Removing the T-compiler nomination until after T-lang discussed this. Feel free to re-add T-compiler!

@rustbot label -I-compiler-nominated

@rustbot rustbot removed the I-compiler-nominated The issue / PR has been nominated for discussion during a compiler team meeting. label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skgland Skgland Skgland left review comments

@kadiwa4 kadiwa4 kadiwa4 left review comments

@Nilstrieb Nilstrieb Nilstrieb left review comments

Assignees

@cjgillot cjgillot

Labels
F-extended_varargs_abi_support `#![feature(extended_varargs_abi_support)]` I-lang-nominated The issue / PR has been nominated for discussion during a lang team meeting. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet