Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gate and validate #[rustc_safe_intrinsic] #116162

Merged
merged 1 commit into from Sep 26, 2023
Merged

Gate and validate #[rustc_safe_intrinsic] #116162

merged 1 commit into from Sep 26, 2023

Conversation

fmease
Copy link
Member

@fmease fmease commented Sep 25, 2023 •
edited

Copied over from #116159:

This was added as ungated in https://github.com/rust-lang/rust/pull/100719/files#diff-09c366d3ad3ec9a42125253b610ca83cad6b156aa2a723f6c7e83eddef7b1e8fR502, probably because the author looked at the surrounding attributes, which are ungated because they are gated specially behind the staged_api feature.

I don't think we need to crater this, the attribute is entirely useless without the intrinsics feature, which is already unstable..

r? @Nilstrieb

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 25, 2023
@fmease fmease force-pushed the gate-n-validate-rustc_safe_intrinsic branch from 56c9ff5 to 42a91fd Compare September 25, 2023 19:43
@fmease fmease mentioned this pull request Sep 25, 2023
Closed
@fmease fmease force-pushed the gate-n-validate-rustc_safe_intrinsic branch from 42a91fd to 8cca977 Compare September 25, 2023 19:50
@fmease fmease closed this Sep 25, 2023
@Nilstrieb Nilstrieb reopened this Sep 25, 2023
Nilstrieb
Nilstrieb approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@Nilstrieb Nilstrieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@fmease fmease force-pushed the gate-n-validate-rustc_safe_intrinsic branch from 8cca977 to f54db7c Compare September 25, 2023 20:33
@fmease
Copy link
Member Author

fmease commented Sep 25, 2023

@bors r=Nilstrieb

@bors
Copy link
Contributor

bors commented Sep 25, 2023

📌 Commit f54db7c has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 25, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 26, 2023
@matthiaskrgr
Rollup merge of rust-lang#116162 - fmease:gate-n-validate-rustc_safe_…
b62471d 
…intrinsic, r=Nilstrieb

Gate and validate `#[rustc_safe_intrinsic]`

Copied over from rust-lang#116159:

> This was added as ungated in https://github.com/rust-lang/rust/pull/100719/files#diff-09c366d3ad3ec9a42125253b610ca83cad6b156aa2a723f6c7e83eddef7b1e8fR502, probably because the author looked at the surrounding attributes, which are ungated because they are gated specially behind the staged_api feature.
>
> I don't think we need to crater this, the attribute is entirely useless without the intrinsics feature, which is already unstable..

r? `@Nilstrieb`
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 26, 2023
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 26, 2023
@bors
Auto merge of rust-lang#116168 - matthiaskrgr:rollup-ys1zmk1, r=matth…
45ee343 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#116099 (Add regression test for issue rust-lang#79865)
 - rust-lang#116102 (Correct codegen of `ConstValue::Indirect` scalar and scalar pair)
 - rust-lang#116131 (Rename `cold_path` to `outline`)
 - rust-lang#116144 (subst -> instantiate)
 - rust-lang#116151 (Fix typo in rustdoc unstable features doc)
 - rust-lang#116153 (Update books)
 - rust-lang#116162 (Gate and validate `#[rustc_safe_intrinsic]`)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 26, 2023
@bors
Auto merge of rust-lang#116168 - matthiaskrgr:rollup-ys1zmk1, r=matth…
c35a363 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#116099 (Add regression test for issue rust-lang#79865)
 - rust-lang#116102 (Correct codegen of `ConstValue::Indirect` scalar and scalar pair)
 - rust-lang#116131 (Rename `cold_path` to `outline`)
 - rust-lang#116144 (subst -> instantiate)
 - rust-lang#116151 (Fix typo in rustdoc unstable features doc)
 - rust-lang#116153 (Update books)
 - rust-lang#116162 (Gate and validate `#[rustc_safe_intrinsic]`)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 26, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 26, 2023
@bors
Auto merge of rust-lang#116175 - matthiaskrgr:rollup-cwteiwy, r=matth…
21627d6 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#116099 (Add regression test for issue rust-lang#79865)
 - rust-lang#116131 (Rename `cold_path` to `outline`)
 - rust-lang#116151 (Fix typo in rustdoc unstable features doc)
 - rust-lang#116153 (Update books)
 - rust-lang#116162 (Gate and validate `#[rustc_safe_intrinsic]`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6f4a0a1 into rust-lang:master Sep 26, 2023
11 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 26, 2023
@rust-timer
Unrolled build for rust-lang#116162
95f4975 
Rollup merge of rust-lang#116162 - fmease:gate-n-validate-rustc_safe_intrinsic, r=Nilstrieb

Gate and validate `#[rustc_safe_intrinsic]`

Copied over from rust-lang#116159:

> This was added as ungated in https://github.com/rust-lang/rust/pull/100719/files#diff-09c366d3ad3ec9a42125253b610ca83cad6b156aa2a723f6c7e83eddef7b1e8fR502, probably because the author looked at the surrounding attributes, which are ungated because they are gated specially behind the staged_api feature.
>
> I don't think we need to crater this, the attribute is entirely useless without the intrinsics feature, which is already unstable..

r? ``@Nilstrieb``
@rustbot rustbot added this to the 1.74.0 milestone Sep 26, 2023
@fmease fmease deleted the gate-n-validate-rustc_safe_intrinsic branch September 26, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nilstrieb Nilstrieb Nilstrieb approved these changes

Assignees

@Nilstrieb Nilstrieb

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.74.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fmease @rust-log-analyzer @bors @Nilstrieb @rustbot