[beta] promote release #116362
Merged
[beta] promote release #116362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot
added
A-testsuite
|
@bors r+ rollup=never |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 3, 2023
…k-Simulacrum [beta] promote release r? `@Mark-Simulacrum`
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
rustbot
added
the
T-bootstrap
|
@bors r+ Set RUSTC_BOOTSTRAP on test executions as well. |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 3, 2023
…k-Simulacrum [beta] promote release r? `@Mark-Simulacrum`
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
getenv("RUSTC_BOOTSTRAP") doesn't work from emscripten code because environment variables are not passed through by default (https://emscripten.org/docs/porting/connecting_cpp_and_javascript/Interacting-with-code.html?highlight=getenv#environment-variables). I believe this is new in the promoting beta because we started custom rendering libtest, requiring a -Z flag to the libtest invocation. This is an annoying problem, I'm not sure if there are great workarounds for it. wasm32-unknown-emscripten is a tier 2 platform though so us running tests for it is sort of ... weird anyway. We might want to reconsider that. |
This should fix running tests on the emscripten target. In the future it's expected we'll want to entirely remove this builder since it's a tier 2 target, but for this initially beta-targeted patch keeping the changes minimal is preferred.
Mark-Simulacrum
force-pushed
the
beta-backport
branch
from
c69c79f
to
2c34a58
Compare
|
@bors r+ rollup=never |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 4, 2023
…emscripten, r=Kobzol Remove wasm32-unknown-emscripten tests from CI This builder tested the wasm32-unknown-emscripten target, which is tier 2 (and so not eligible for testing). In the recent beta [promotion](rust-lang#116362 (comment)), we ran into a problem with this target: emscripten doesn't support passing environment variables into the std environment, so we can't enable RUSTC_BOOTSTRAP for libtest in order to pass -Zunstable-options. We worked around this for the beta/stable branches, but given this problem, and its tier 2 status, just dropping the target's tests entirely seems warranted. Downgrading to tier 3 may also be a good idea, but that is a separate conversation not proposed here.
bors-ferrocene bot
added a commit
to ferrocene/ferrocene
that referenced
this pull request
Oct 9, 2023
34: Automated pull from upstream `beta` r=pietroalbini a=github-actions[bot] This PR pulls the following changes from the upstream repository: * rust-lang/rust#116362 Co-authored-by: Mark Rousskov <mark.simulacrum@gmail.com> Co-authored-by: bors <bors@rust-lang.org> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Mark-Simulacrum