feat(ci): upload metrics to GitHub Artifacts ✨

[meysam81]

fixes rust-lang/infra-team#74
replaces rust-lang/simpleinfra#348

[rustbot]

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

[meysam81]

r? @jdno

[jdno]

We also generate detailed metrics in x.py, which we should upload. Here's the relevant step in upload-artifacts.sh:

cp "${build_dir}/metrics.json" "${upload_dir}/metrics-${CI_JOB_NAME}.json"

I didn't notice before that build_dir is a variable that has two different values, based on the operating system:

build_dir=build
if isLinux; then
    build_dir=obj/build
fi

So simply invoking actions/upload-artifact might not be enough. 😬

I am wondering if it would make sense to create a script to gather the build metrics that we can call in both upload-artifacts.sh and in a step before actions/upload-artifact. In other words, move these instructions into a script and call it in both places:

# CPU usage statistics.
cp build/cpu-usage.csv "${upload_dir}/cpu-${CI_JOB_NAME}.csv"

# Build metrics generated by x.py.
cp "${build_dir}/metrics.json" "${upload_dir}/metrics-${CI_JOB_NAME}.json"

What do you think?

[Dylan-DPC]

@jdno any updates on the review? thanks

[bors]

☔ The latest upstream changes (presumably #124175) made this pull request unmergeable. Please resolve the merge conflicts.