Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle several #[diagnostic::on_unimplemented] attributes correctly #116642

Merged

Commits on Oct 11, 2023

  1. Handle several #[diagnostic::on_unimplemented] attributes correctly

    This PR fixes an issues where rustc would ignore subsequent
    `#[diagnostic::on_unimplemented]` attributes. The [corresponding
    RFC](https://rust-lang.github.io/rfcs/3368-diagnostic-attribute-namespace.html)
    specifies that the first matching instance of each option is used.
    Invalid attributes are linted and otherwise ignored.
    weiznich committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    232aaeb View commit details
    Browse the repository at this point in the history