Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coverage: Several small cleanups in spans #116754

Merged
merged 14 commits into from
Oct 17, 2023
Merged

coverage: Several small cleanups in spans #116754

merged 14 commits into from
Oct 17, 2023

Commits on Oct 16, 2023

  1. coverage: Rename check_invoked_macro_name_span to `maybe_push_macro… 

    …_name_span`
    @Zalathar
    Zalathar committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    46c545c View commit details
    Browse the repository at this point in the history

  2. coverage: Rename check_pending_dups to maybe_flush_pending_dups 

    This method's main responsibility is to flush the pending dups into refined
spans, if appropriate.
    @Zalathar
    Zalathar committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    9b6ce4f View commit details
    Browse the repository at this point in the history

  3. coverage: Rename hold_pending_dups_unless_dominated to `update_pend… 

    …ing_dups`
    @Zalathar
    Zalathar committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    d928d3e View commit details
    Browse the repository at this point in the history

  4. coverage: Use DUMMY_SP instead of creating a dummy span manually 

    This patch also sorts the constructor fields into declaration order.
    @Zalathar
    Zalathar committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    fa2e262 View commit details
    Browse the repository at this point in the history

  5. coverage: Simplify push_refined_span 

    It turns out that all of the `len` manipulation here was just reimplementing
`last_mut`.
    @Zalathar
    Zalathar committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    5f1e8f9 View commit details
    Browse the repository at this point in the history

  6. coverage: Flatten guard logic in maybe_push_macro_name_span

    @Zalathar
    Zalathar committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    97d1a91 View commit details
    Browse the repository at this point in the history

  7. coverage: Flatten guard logic in maybe_flush_pending_dups

    @Zalathar
    Zalathar committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    7bbe4be View commit details
    Browse the repository at this point in the history

  8. coverage: Remove redundant field prev_expn_span 

    This span can always be retrieved from `prev`, so there is no need to store it
separately.
    @Zalathar
    Zalathar committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    9bb27f3 View commit details
    Browse the repository at this point in the history

  9. coverage: Call prev/curr less in to_refined_spans 

    This makes it easier to see that the non-initial cases assume that `prev` and
`curr` are set, and all operate on the same prev/curr references.
    @Zalathar
    Zalathar committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    b1c44f4 View commit details
    Browse the repository at this point in the history

  10. coverage: Call prev/curr less in other places 

    This reduces clutter, and makes it easier to notice regions where mutations
definitely don't occur.
    @Zalathar
    Zalathar committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    41038db View commit details
    Browse the repository at this point in the history

  11. coverage: Move take_curr and note what its callers are doing

    @Zalathar
    Zalathar committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    25e6303 View commit details
    Browse the repository at this point in the history

  12. coverage: Inline prev_starts_after_next

    @Zalathar
    Zalathar committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    4ab4273 View commit details
    Browse the repository at this point in the history

  13. coverage: Inline span_bcb_dominates 

    Interacting with `basic_coverage_blocks` directly makes it easier to satisfy
the borrow checker when mutating `pending_dups` while reading other fields.
    @Zalathar
    Zalathar committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    5e5a8e7 View commit details
    Browse the repository at this point in the history

  14. coverage: Explain why we temporarily steal pending_dups

    @Zalathar
    Zalathar committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    7aa1b83 View commit details
    Browse the repository at this point in the history