Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rework opaque type region inference #116891

Merged
merged 12 commits into from Mar 28, 2024
Merged

rework opaque type region inference #116891

merged 12 commits into from Mar 28, 2024

Conversation

aliemjay
Copy link
Member

@aliemjay aliemjay commented Oct 18, 2023 •
edited

User-facing changes are documented in this comment.

The design document is in this comment.

- Fix Ice in check_unique; ICE -> Error; fixes #122782.
- Ignore uncaptured lifetime args; ICE -> Pass; fixes #111906, fixes #110623, fixes #109059, fixes #122307
- Except equal parameters from the uniqueness check; Pass -> Error; fixes #113916.
- Check RPITs for invalid args; Pass -> Error; fixes #111935; ICE -> Error; fixes #110726.
- Rework opaque types region inference; Pass -> Error; fixes #113971, fixes #112841.
- Reject external lifetimes as invalid args; Pass -> Error; fixes #105498.

r? @ghost

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 18, 2023
@aliemjay

This comment was marked as resolved.

Sign in to view
@bors

This comment was marked as resolved.

Sign in to view
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 19, 2023
@bors
Auto merge of rust-lang#116891 - aliemjay:opaque-region-infer-rework-…
c679690 
…2, r=<try>

rework opaque type region inference

fixes rust-lang#113971 Pass -> Error

fixes rust-lang#111906 ICE -> Pass
fixes rust-lang#110623 ==
fixes rust-lang#109059 ==

fixes rust-lang#112841 Pass -> Error

fixes rust-lang#110726 ICE->Error

r? `@ghost`
@bors

This comment was marked as resolved.

Sign in to view
@aliemjay
Copy link
Member Author

@craterbot check

@craterbot
Copy link
Collaborator

👌 Experiment pr-116891 created and queued.
🤖 Automatically detected try build c679690
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2023
@aliemjay

This comment was marked as resolved.

Sign in to view
@bors

This comment was marked as resolved.

Sign in to view
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 21, 2023
@bors
Auto merge of rust-lang#116891 - aliemjay:opaque-region-infer-rework-…
e287a7d 
…2, r=<try>

rework opaque type region inference

fixes rust-lang#113971 Pass -> Error

fixes rust-lang#111906 ICE -> Pass
fixes rust-lang#110623 ==
fixes rust-lang#109059 ==

fixes rust-lang#112841 Pass -> Error

fixes rust-lang#110726 ICE->Error

r? `@ghost`
@bors

This comment was marked as resolved.

Sign in to view
@craterbot

This comment was marked as resolved.

Sign in to view
@aliemjay

This comment was marked as resolved.

Sign in to view
@craterbot

This comment was marked as resolved.

Sign in to view
@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Oct 22, 2023
@aliemjay
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 23, 2023
@bors
Copy link
Contributor

bors commented Oct 23, 2023

⌛ Trying commit 350b33e with merge 66abdf7...

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 23, 2023
@bors
Auto merge of rust-lang#116891 - aliemjay:opaque-region-infer-rework-…
66abdf7 
…2, r=<try>

rework opaque type region inference

fixes rust-lang#113971 Pass -> Error

fixes rust-lang#111906 ICE -> Pass
fixes rust-lang#110623 ==
fixes rust-lang#109059 ==

fixes rust-lang#112841 Pass -> Error

fixes rust-lang#110726 ICE->Error

fixes rust-lang#111935 Pass -> Error
fixes rust-lang#113916 ==

r? `@ghost`
@bors
Copy link
Contributor

bors commented Oct 23, 2023

☀️ Try build successful - checks-actions
Build commit: 66abdf7 (66abdf72fc886ae058026c1529ae9c93ebd8838a)

@rust-timer

This comment has been minimized.

Sign in to view
@aliemjay
Copy link
Member Author

@craterbot check

@craterbot
Copy link
Collaborator

👌 Experiment pr-116891 created and queued.
🤖 Automatically detected try build 66abdf7
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 23, 2023
@rust-cloud-vms rust-cloud-vms bot force-pushed the opaque-region-infer-rework-2 branch from b587b02 to 4008a39 Compare March 28, 2024 06:16
@aliemjay
Copy link
Member Author

@bors r=compiler-errors,oli-obk rollup=never

@rustbot label +relnotes

@bors
Copy link
Contributor

bors commented Mar 28, 2024

📌 Commit 4008a39 has been approved by compiler-errors,oli-obk

It is now in the queue for this repository.

@rustbot rustbot added the relnotes Marks issues that should be documented in the release notes of the next release. label Mar 28, 2024
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 28, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-cloud-vms rust-cloud-vms bot force-pushed the opaque-region-infer-rework-2 branch from 4008a39 to 59c217f Compare March 28, 2024 06:42
@aliemjay
Copy link
Member Author

@bors r-

Waiting on CI.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 28, 2024
@aliemjay
Copy link
Member Author

@bors r=compiler-errors,oli-obk rollup=never

@bors
Copy link
Contributor

bors commented Mar 28, 2024

📌 Commit 59c217f has been approved by compiler-errors,oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 28, 2024
@bors
Copy link
Contributor

bors commented Mar 28, 2024

⌛ Testing commit 59c217f with merge 551abd6...

@bors
Copy link
Contributor

bors commented Mar 28, 2024

☀️ Test successful - checks-actions
Approved by: compiler-errors,oli-obk
Pushing 551abd6 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 28, 2024
@bors bors merged commit 551abd6 into rust-lang:master Mar 28, 2024
12 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Mar 28, 2024
@aliemjay aliemjay deleted the opaque-region-infer-rework-2 branch March 28, 2024 12:05
@bors bors mentioned this pull request Mar 28, 2024
Open
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (551abd6): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.1% [-1.5%, -0.5%] 10
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -1.1% [-1.5%, -0.5%] 10

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.6% [0.4%, 0.8%] 3
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.6% [0.4%, 0.8%] 3

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 669.796s -> 670.635s (0.13%)
Artifact size: 315.69 MiB -> 315.72 MiB (0.01%)

github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Mar 29, 2024
@bors
Auto merge of #116891 - aliemjay:opaque-region-infer-rework-2, r=comp…
b901ffb 
…iler-errors,oli-obk

rework opaque type region inference

User-facing changes are documented in [this comment](rust-lang/rust#116891 (comment)).

The design document is in [this comment](rust-lang/rust#116891 (comment)).

---

\- Fix Ice in check_unique; ICE -> Error; fixes #122782.
\- Ignore uncaptured lifetime args; ICE -> Pass; fixes #111906, fixes #110623, fixes #109059, fixes #122307
\- Except equal parameters from the uniqueness check; Pass -> Error; fixes #113916.
\- Check RPITs for invalid args; Pass -> Error; fixes #111935; ICE -> Error; fixes #110726.
\- Rework opaque types region inference; Pass -> Error; fixes #113971, fixes #112841.
\- Reject external lifetimes as invalid args; Pass -> Error; fixes #105498.

r? `@ghost`
@traviscross traviscross mentioned this pull request Apr 2, 2024
Open
3 tasks
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Apr 4, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 6, 2024
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lqd lqd lqd left review comments

@compiler-errors compiler-errors compiler-errors approved these changes

@lcnr lcnr lcnr left review comments

@oli-obk oli-obk oli-obk approved these changes

Assignees

@oli-obk oli-obk

@compiler-errors compiler-errors

Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. F-type_alias_impl_trait `#[feature(type_alias_impl_trait)]` finished-final-comment-period The final comment period is finished for this PR / Issue. merged-by-bors This PR was explicitly merged by bors. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-types Relevant to the types team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.79.0