Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stablize arc_unwrap_or_clone #116949

Merged
merged 1 commit into from Dec 10, 2023
Merged

Stablize arc_unwrap_or_clone #116949

merged 1 commit into from Dec 10, 2023

Conversation

hamza1311
Copy link
Contributor

@hamza1311 hamza1311 commented Oct 19, 2023 •
edited

Fixes: #93610

This likely needs FCP. I created this PR as it's stabilization is trivial and FCP can be just conducted here. Not sure how to ping the libs API team (last attempt didn't work apparently according to GH UI)

@hamza1311
Copy link
Contributor Author

@rustbot modify labels: +T-libs-api

@rustbot
Copy link
Collaborator

rustbot commented Oct 19, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 19, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@tgross35
Copy link
Contributor

@rustbot label +needs-fcp -t-libs
r? libs-api

@rustbot rustbot added the needs-fcp This change is insta-stable, so needs a completed FCP to proceed. label Oct 19, 2023
@dtolnay dtolnay added S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 28, 2023
@dtolnay dtolnay assigned dtolnay and unassigned joshtriplett Oct 28, 2023
@dtolnay dtolnay removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 28, 2023
dtolnay
dtolnay reviewed Oct 28, 2023
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FCP proposal: #93610 (comment)

@hamza1311
Copy link
Contributor Author

hamza1311 commented Dec 9, 2023 •
edited

FCP proposal: #93610 (comment)

That concluded positively. We can merge this now, @dtolnay

dtolnay
dtolnay approved these changes Dec 10, 2023
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dtolnay
Copy link
Member

dtolnay commented Dec 10, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Dec 10, 2023

📌 Commit 540921e has been approved by dtolnay

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 10, 2023
@dtolnay dtolnay removed the S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. label Dec 10, 2023
@bors
Copy link
Contributor

bors commented Dec 10, 2023

⌛ Testing commit 540921e with merge 61afc9c...

@bors
Copy link
Contributor

bors commented Dec 10, 2023

☀️ Test successful - checks-actions
Approved by: dtolnay
Pushing 61afc9c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 10, 2023
@bors bors merged commit 61afc9c into rust-lang:master Dec 10, 2023
12 checks passed
@rustbot rustbot added this to the 1.76.0 milestone Dec 10, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (61afc9c): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 5.0% [5.0%, 5.0%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 668.605s -> 667.481s (-0.17%)
Artifact size: 314.16 MiB -> 314.13 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels
merged-by-bors This PR was explicitly merged by bors. needs-fcp This change is insta-stable, so needs a completed FCP to proceed. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.76.0
Development

Successfully merging this pull request may close these issues.

Tracking Issue for arc_unwrap_or_clone
9 participants
@hamza1311 @rustbot @rust-log-analyzer @tgross35 @dtolnay @bors @rust-timer @joshtriplett @Mark-Simulacrum