Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compute polonius loan scopes over the region graph #117560

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Compute polonius loan scopes over the region graph #117560

merged 2 commits into from
Nov 8, 2023

Commits on Nov 4, 2023

  1. traverse region graph instead of SCCs to compute polonius loan scopes 

    By using SCC for better performance, we also have to take into account
SCCs whose representative is an existential region but also contains a
placeholder.

By only checking the representative, we may miss that the loan escapes
the function. This can be fixed by picking a better representative, or
removing placeholders from the main path.

This is the simplest fix: forgo efficiency and traverse the region graph
instead of the SCCs.
    @lqd
    lqd committed Nov 4, 2023
    Configuration menu
    Copy the full SHA
    de7a830 View commit details
    Browse the repository at this point in the history

  2. add test for issue 117146

    @lqd
    lqd committed Nov 4, 2023
    Configuration menu
    Copy the full SHA
    2dff90d View commit details
    Browse the repository at this point in the history