Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvm-wrapper: Remove include of non-existant Vectorize.h #117675

Merged
merged 1 commit into from Nov 7, 2023

Conversation

zmodem
Copy link
Contributor

@zmodem zmodem commented Nov 7, 2023

LLVM recently removed the header: llvm/llvm-project@2400c54

It only contained a declaration of createLoadStoreVectorizerPass(), which Rust doesn't reference.

@rustbot
Copy link
Collaborator

rustbot commented Nov 7, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cuviper (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 7, 2023
@zmodem
Copy link
Contributor Author

zmodem commented Nov 7, 2023

@durin42 Please take a look? This is also my first PR to Rust, so assume I have no idea what I'm doing.

@rustbot label: +llvm-main

@rustbot rustbot added the llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) label Nov 7, 2023
@durin42
Copy link
Contributor

durin42 commented Nov 7, 2023

Oh nice, that's better than my fix.

@durin42
Copy link
Contributor

durin42 commented Nov 7, 2023

@rustbot r+ rollup=always

@durin42
Copy link
Contributor

durin42 commented Nov 7, 2023

hm.

@rustbot r=durin42 rollup=always

@cuviper
Copy link
Member

cuviper commented Nov 7, 2023

@bors r=durin42 rollup=always

@bors
Copy link
Contributor

bors commented Nov 7, 2023

📌 Commit 752a613 has been approved by durin42

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2023
@durin42
Copy link
Contributor

durin42 commented Nov 7, 2023

d'oh. Thanks @cuviper!

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 7, 2023
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#115485 (Format macro const literals with pretty printer)
 - rust-lang#117616 (warn when using an unstable feature with -Ctarget-feature)
 - rust-lang#117639 (Update books)
 - rust-lang#117675 (llvm-wrapper: Remove include of non-existant Vectorize.h)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 518fe49 into rust-lang:master Nov 7, 2023
11 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 7, 2023
Rollup merge of rust-lang#117675 - zmodem:vectorize_h, r=durin42

llvm-wrapper: Remove include of non-existant Vectorize.h

LLVM recently removed the header: llvm/llvm-project@2400c54

It only contained a declaration of `createLoadStoreVectorizerPass()`, which Rust doesn't reference.
@rustbot rustbot added this to the 1.75.0 milestone Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants