Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crater: test enabling MCP510 #117684

Closed
wants to merge 5 commits into from
Closed

crater: test enabling MCP510 #117684

wants to merge 5 commits into from

Conversation

lqd
Copy link
Member

@lqd lqd commented Nov 7, 2023

Tests pass at stage1 and 2 with the x86_64-unknown-linux-gnu target switched. CI passes in #113382 with most x86_64-unknown-linux-gnu builders enabled. Bootstrap and the perf collector work.

The crater queue is about to be empty, so it's a good time to do another run with this linker configuration and see if anything changed since the previous run. Surely, some bug-for-bug bfd compatibility differences will remain, but it will good to check with the latest lld anyways.

Note for anyone looking at this PR coming from the crater queue: this is intended to be a low-priority run. If it hasn't started and you need your run started before this one, go ahead and bump your own priority above this.

r? @ghost

@lqd
ci: bump gcc on dist x64 linux builder to 9.5
7bcb914 
Support for `-fuse-ld=lld` was added in GCC 9
@lqd
add note to remember to update a url when bumping to gcc 10.1.0
ba45208
@lqd
bootstrap: introduce rust-lld cfg for rustc
a33e79a
@lqd
bootstrap: enable rust-lld when necessary for x86_64-unknown-linux-gnu
5dff79a 
`x86_64-unknown-linux-gnu` has switched to using the self-contained linker
by default (unless asked not to), so we have to build rust-lld:
- when we build our own llvm
- when we use download-ci-llvm
- otherwise, when using an external llvm we can't enable it
@lqd
tmp: enable rust-lld by default
d267f40
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Nov 7, 2023
@lqd
Copy link
Member Author

lqd commented Nov 7, 2023

@bors try

@bors
Copy link
Contributor

bors commented Nov 7, 2023

⌛ Trying commit d267f40 with merge 53e0313...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 7, 2023
@bors
Auto merge of rust-lang#117684 - lqd:mcp510-crater, r=<try>
53e0313 
crater: test enabling MCP510

Tests pass at stage1 and 2 with the `x86_64-unknown-linux-gnu` target switched. CI passes in rust-lang#113382 with most `x86_64-unknown-linux-gnu` builders enabled. Bootstrap and the perf collector work.

The crater queue is about to be empty, so it's a good time to do another run with this linker configuration and see if anything changed since the previous run. Surely, some bug-for-bug bfd compatibility differences will remain, but it will good to check with the latest lld anyways.

Note for anyone looking at this PR coming from the crater queue: this is intended to be a low-priority run. If it hasn't started and you need your run started before this one, go ahead and bump your own priority above this.

r? `@ghost`
@bors
Copy link
Contributor

bors commented Nov 7, 2023

☀️ Try build successful - checks-actions
Build commit: 53e0313 (53e03135c36e913ff664ce8329041b7e3c2fd358)

@lqd
Copy link
Member Author

lqd commented Nov 7, 2023

A regular helloworld build looks good:

$ cargo +53e03135c36e913ff664ce8329041b7e3c2fd358 build -q && readelf -p .comment target/debug/helloworld

String dump of section '.comment':
  [     1]  GCC: (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
  [    2c]  rustc version 1.75.0-nightly (53e03135c 2023-11-07)
  [    60]  Linker: LLD 17.0.4

The x86_64-unknown-linux-gnu target also looks good:

{
  "arch": "x86_64",
  "cpu": "x86-64",
  "crt-static-respected": true,
  "data-layout": "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128",
  "dynamic-linking": true,
  "env": "gnu",
  "has-rpath": true,
  "has-thread-local": true,
  "is-builtin": true,
  "link-self-contained": {
    "components": [
      "linker"
    ]
  },
  "linker-flavor": "gnu-lld-cc",
  "llvm-target": "x86_64-unknown-linux-gnu",
  "max-atomic-width": 64,
  "os": "linux",
  "plt-by-default": false,
  "position-independent-executables": true,
  "pre-link-args": {
    "gnu-cc": [
      "-m64"
    ],
    "gnu-lld-cc": [
      "-m64"
    ]
  },
  "relro-level": "full",
  "stack-probes": {
    "kind": "inline-or-call",
    "min-llvm-version-for-inline": [
      16,
      0,
      0
    ]
  },
  "static-position-independent-executables": true,
  "supported-sanitizers": [
    "address",
    "cfi",
    "leak",
    "memory",
    "thread",
    "safestack"
  ],
  "supported-split-debuginfo": [
    "packed",
    "unpacked",
    "off"
  ],
  "supports-xray": true,
  "target-family": [
    "unix"
  ],
  "target-pointer-width": "64"
}

@craterbot run mode=build-only

@craterbot
Copy link
Collaborator

👌 Experiment pr-117684 created and queued.
🤖 Automatically detected try build 53e0313
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2023
@craterbot
Copy link
Collaborator

🚧 Experiment pr-117684 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-117684 is completed!
📊 227 regressed and 80 fixed (385987 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Nov 9, 2023
@lqd
Copy link
Member Author

lqd commented Nov 9, 2023

No space left on device: 149 out of 227

@lqd
Copy link
Member Author

lqd commented Nov 9, 2023

Queuing a short run to remove the transient issues, with priority because it's short (as discussed in this zulip topic). If someone doing another run needs this: feel free to change your run's priority above this if it's urgent, or downgrade this one.

@craterbot check p=1 crates=https://crater-reports.s3.amazonaws.com/pr-117684/retry-regressed-list.txt

@craterbot
Copy link
Collaborator

👌 Experiment pr-117684-1 created and queued.
🤖 Automatically detected try build 53e0313
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 9, 2023
@craterbot
Copy link
Collaborator

🚧 Experiment pr-117684-1 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚨 Report generation of pr-117684-1 failed: Error: missing label values ["pr-117684-1"]
🛠️ If the error is fixed use the retry-report command.

🆘 Can someone from the infra team check in on this? @rust-lang/infra
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@Mark-Simulacrum
Copy link
Member

@craterbot retry-report

@craterbot
Copy link
Collaborator

🛠️ Generation of the report for pr-117684-1 queued again.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-117684-1 is completed!
📊 1 regressed and 0 fixed (227 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Nov 11, 2023
@lqd
Copy link
Member Author

lqd commented Nov 11, 2023

I am a doofus, and ran the same command for both of my in-progress runs 🤦

@craterbot run mode=build-only p=1 crates=https://crater-reports.s3.amazonaws.com/pr-117684/retry-regressed-list.txt

@craterbot
Copy link
Collaborator

👌 Experiment pr-117684-2 created and queued.
🤖 Automatically detected try build 53e0313
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 11, 2023
@craterbot
Copy link
Collaborator

🚧 Experiment pr-117684-2 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-117684-2 is completed!
📊 45 regressed and 0 fixed (227 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Nov 12, 2023
@lqd
Copy link
Member Author

lqd commented Nov 12, 2023 •
edited

Roughly similar to last year's run indeed, with more dependencies on linkme's shenanigans. Will triage later.

@Dylan-DPC
Copy link
Member

@lqd any updates on the crater triage? thanks

@lqd
Copy link
Member Author

lqd commented Apr 13, 2024

Let's close this as the data is gathered. Crater triage is at https://hackmd.io/OAJxlxc6Te6YUot9ftYSKQ

@lqd lqd closed this Apr 13, 2024
@Dylan-DPC
Copy link
Member

Dylan-DPC commented Apr 13, 2024 •
edited

Closing this as inactive. Feel free to reöpen this pr or create a new pr if you get the time to work on this. Thanks Err by some hell of coïncidence the pr was being checked at the same time by both of us :P

@Dylan-DPC Dylan-DPC removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lqd @bors @craterbot @Mark-Simulacrum @Dylan-DPC @rustbot