Introduce perma-unstable `wasm-c-abi` flag #117919

daxpedda · 2023-11-14T22:15:38Z

Now that wasm-bindgen v0.2.88 supports the spec-compliant C ABI, the idea is to switch to that in a future version of Rust. In the meantime it would be good to let people test and play around with it.

This PR introduces a new perma-unstable -Zwasm-c-abi compiler flag, which switches to the new spec-compliant C ABI when targeting wasm32-unknown-unknown.

Alternatively, we could also stabilize this and then deprecate it when we switch. I will leave this to the Rust maintainers to decide.

This is a companion PR to #117918, but they could be merged independently.
MCP: rust-lang/compiler-team#703
Tracking issue: #122532

rustbot · 2023-11-14T22:15:46Z

r? @compiler-errors

(rustbot has picked a reviewer for you, use r? to override)

rustbot · 2023-11-14T22:15:48Z

These commits modify compiler targets.
(See the Target Tier Policy.)

daxpedda · 2023-11-14T22:17:47Z

compiler/rustc_target/src/spec/mod.rs

+pub trait HasWasmCAbiOpt {
+    fn wasm_c_abi_opt(&self) -> bool;
+}


This is the best I could come up with to keep the logic inside of Target::adjust_abi(), I believe moving this logic outside of it would introduce some very hacky code that could potentially become a trap for other contributors.

I'm pretty unfamiliar with the compiler though, so any advice would be appreciated.

rustbot · 2023-11-14T22:36:01Z

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo

compiler/rustc_session/src/options.rs

rustbot · 2023-11-16T08:36:15Z

Some changes occurred in src/tools/cargo

cc @ehuss

daxpedda · 2023-11-16T08:39:22Z

Apologies @ehuss, I messed up during rebasing onto master and mistakenly changed the Cargo submodule!

bors · 2023-12-01T00:56:35Z

☔ The latest upstream changes (presumably #116892) made this pull request unmergeable. Please resolve the merge conflicts.

compiler-errors · 2023-12-05T16:03:33Z

Sorry, I'm extremely busy

r? compiler

petrochenkov · 2023-12-05T16:32:21Z

r? compiler
I'm overloaded with reviews.

b-naber · 2023-12-11T21:31:27Z

The companion PR is lang-nominated, if the lang team approves that change this one could be merged too, but if this PR would be merged independently it would need at least an MCP, I think, since it introduces a new flag.

Co-Authored-By: Ralf Jung <330628+RalfJung@users.noreply.github.com>

apiraino · 2024-03-14T11:11:07Z

MCP#703 is now approved.

If I understand correctly, this proposal can now move forward

@rustbot ready

apiraino · 2024-03-28T10:32:53Z

@b-naber checking this PR. The MCP has been merged (comment), can this be reviewed or does it needs some updates? thanks for checking the progress here!

liamrosenfeld · 2024-04-17T16:57:17Z

Is there anything further that needs to be done to get this on some review queue? Both the MCP was accepted and the companion PR was merged over a month ago but there have been no updates since.

This addresses an issue that pops up throughout the wasm ecosystem, and causes major issues when it does. So phasing in a fix with this flag as soon as possible would be very helpful.

wesleywiser · 2024-04-18T16:47:15Z

@bors r+

bors · 2024-04-18T16:47:18Z

📌 Commit 9e2c658 has been approved by wesleywiser

It is now in the queue for this repository.

Introduce perma-unstable `wasm-c-abi` flag Now that `wasm-bindgen` v0.2.88 supports the spec-compliant C ABI, the idea is to switch to that in a future version of Rust. In the meantime it would be good to let people test and play around with it. This PR introduces a new perma-unstable `-Zwasm-c-abi` compiler flag, which switches to the new spec-compliant C ABI when targeting `wasm32-unknown-unknown`. Alternatively, we could also stabilize this and then deprecate it when we switch. I will leave this to the Rust maintainers to decide. This is a companion PR to rust-lang#117918, but they could be merged independently. MCP: rust-lang/compiler-team#703 Tracking issue: rust-lang#122532

…kingjubilee Rollup of 6 pull requests Successful merges: - rust-lang#117919 (Introduce perma-unstable `wasm-c-abi` flag) - rust-lang#123571 (Correctly change type when adding adjustments on top of `NeverToAny`) - rust-lang#123752 (Properly handle emojis as literal prefix in macros) - rust-lang#123980 ( Add an opt-in to store incoming edges in `VecGraph` + misc) - rust-lang#124110 (Fix negating `f16` and `f128` constants) - rust-lang#124116 (when suggesting RUST_BACKTRACE=1, add a special note for Miri's env var isolation) r? `@ghost` `@rustbot` modify labels: rollup

Introduce perma-unstable `wasm-c-abi` flag Now that `wasm-bindgen` v0.2.88 supports the spec-compliant C ABI, the idea is to switch to that in a future version of Rust. In the meantime it would be good to let people test and play around with it. This PR introduces a new perma-unstable `-Zwasm-c-abi` compiler flag, which switches to the new spec-compliant C ABI when targeting `wasm32-unknown-unknown`. Alternatively, we could also stabilize this and then deprecate it when we switch. I will leave this to the Rust maintainers to decide. This is a companion PR to rust-lang#117918, but they could be merged independently. MCP: rust-lang/compiler-team#703 Tracking issue: rust-lang#122532

…kingjubilee Rollup of 9 pull requests Successful merges: - rust-lang#117919 (Introduce perma-unstable `wasm-c-abi` flag) - rust-lang#123406 (Force exhaustion in iter::ArrayChunks::into_remainder) - rust-lang#123752 (Properly handle emojis as literal prefix in macros) - rust-lang#123935 (Don't inline integer literals when they overflow - new attempt) - rust-lang#123980 ( Add an opt-in to store incoming edges in `VecGraph` + misc) - rust-lang#124019 (Use raw-dylib for Windows synchronization functions) - rust-lang#124110 (Fix negating `f16` and `f128` constants) - rust-lang#124112 (Fix ICE when there is a non-Unicode entry in the incremental crate directory) - rust-lang#124116 (when suggesting RUST_BACKTRACE=1, add a special note for Miri's env var isolation) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2024-04-19T03:35:15Z

⌛ Testing commit 9e2c658 with merge 13e63f7...

bors · 2024-04-19T05:37:05Z

☀️ Test successful - checks-actions
Approved by: wesleywiser
Pushing 13e63f7 to master...

rust-timer · 2024-04-19T07:22:37Z

Finished benchmarking commit (13e63f7): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.2%, 0.2%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.2%	[0.2%, 0.2%]	1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.0%	[2.0%, 2.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.1%	[2.1%, 4.4%]	8
Regressions ❌ (secondary)	2.7%	[2.1%, 3.5%]	11
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.1%	[2.1%, 4.4%]	8

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 673.311s -> 673.499s (0.03%)
Artifact size: 315.21 MiB -> 315.24 MiB (0.01%)

rustbot assigned compiler-errors Nov 14, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 14, 2023

daxpedda commented Nov 14, 2023

View reviewed changes

This comment has been minimized.

Sign in to view

daxpedda force-pushed the wasm-c-abi branch from 9021455 to 22448ca Compare November 14, 2023 22:22

This comment has been minimized.

Sign in to view

daxpedda force-pushed the wasm-c-abi branch from 22448ca to eb36606 Compare November 14, 2023 22:35

This comment has been minimized.

Sign in to view

daxpedda force-pushed the wasm-c-abi branch from eb36606 to 72b6505 Compare November 14, 2023 23:03

Nilstrieb reviewed Nov 16, 2023

View reviewed changes

compiler/rustc_session/src/options.rs Outdated Show resolved Hide resolved

daxpedda force-pushed the wasm-c-abi branch 2 times, most recently from 571d6df to b5d3f7b Compare November 16, 2023 08:36

daxpedda force-pushed the wasm-c-abi branch from b5d3f7b to 62afb0f Compare November 16, 2023 08:38

This comment has been minimized.

Sign in to view

daxpedda force-pushed the wasm-c-abi branch from 62afb0f to 9006713 Compare November 16, 2023 08:43

daxpedda force-pushed the wasm-c-abi branch from 9006713 to 7955e07 Compare December 1, 2023 07:23

rustbot assigned petrochenkov and unassigned compiler-errors Dec 5, 2023

rustbot assigned b-naber and unassigned petrochenkov Dec 5, 2023

daxpedda and others added 2 commits March 10, 2024 09:00

Introduce perma-unstable wasm-c-abi flag

f09c19a

Remove TargetOptions::default_adjusted_cabi

9e2c658

Co-Authored-By: Ralf Jung <330628+RalfJung@users.noreply.github.com>

daxpedda force-pushed the wasm-c-abi branch from 8bb40f8 to 9e2c658 Compare March 10, 2024 08:00

apiraino removed the S-waiting-on-MCP Status: PR has a compiler MCP and is waiting for the compiler MCP to complete. label Mar 14, 2024

daxpedda mentioned this pull request Mar 15, 2024

Tracking Issue for perma-unstable wasm-c-abi flag #122532

Open

2 tasks

wesleywiser approved these changes Apr 18, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 18, 2024

GuillaumeGomez mentioned this pull request Apr 18, 2024

Rollup of 10 pull requests #124131

Closed

GuillaumeGomez mentioned this pull request Apr 18, 2024

Rollup of 7 pull requests #124133

Closed

workingjubilee mentioned this pull request Apr 18, 2024

Rollup of 6 pull requests #124140

Closed

workingjubilee mentioned this pull request Apr 18, 2024

Rollup of 9 pull requests #124142

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 19, 2024

bors merged commit 13e63f7 into rust-lang:master Apr 19, 2024
12 checks passed

rustbot added this to the 1.79.0 milestone Apr 19, 2024

bors mentioned this pull request Apr 19, 2024

sanitizers: stabilize core sanitizers (i.e., AddressSanitizer, LeakSanitizer, MemorySanitizer, ThreadSanitizer) #123617

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce perma-unstable `wasm-c-abi` flag #117919

Introduce perma-unstable `wasm-c-abi` flag #117919

daxpedda commented Nov 14, 2023 •

edited

rustbot commented Nov 14, 2023

rustbot commented Nov 14, 2023

daxpedda Nov 14, 2023

This comment has been minimized.

This comment has been minimized.

rustbot commented Nov 14, 2023

This comment has been minimized.

rustbot commented Nov 16, 2023

daxpedda commented Nov 16, 2023

This comment has been minimized.

bors commented Dec 1, 2023

compiler-errors commented Dec 5, 2023

petrochenkov commented Dec 5, 2023

b-naber commented Dec 11, 2023

apiraino commented Mar 14, 2024

apiraino commented Mar 28, 2024

liamrosenfeld commented Apr 17, 2024 •

edited

wesleywiser commented Apr 18, 2024

bors commented Apr 18, 2024

bors commented Apr 19, 2024

bors commented Apr 19, 2024

rust-timer commented Apr 19, 2024

Introduce perma-unstable wasm-c-abi flag #117919

Introduce perma-unstable wasm-c-abi flag #117919

Conversation

daxpedda commented Nov 14, 2023 • edited

rustbot commented Nov 14, 2023

rustbot commented Nov 14, 2023

daxpedda Nov 14, 2023

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

rustbot commented Nov 14, 2023

This comment has been minimized.

rustbot commented Nov 16, 2023

daxpedda commented Nov 16, 2023

This comment has been minimized.

bors commented Dec 1, 2023

compiler-errors commented Dec 5, 2023

petrochenkov commented Dec 5, 2023

b-naber commented Dec 11, 2023

apiraino commented Mar 14, 2024

apiraino commented Mar 28, 2024

liamrosenfeld commented Apr 17, 2024 • edited

wesleywiser commented Apr 18, 2024

bors commented Apr 18, 2024

bors commented Apr 19, 2024

bors commented Apr 19, 2024

rust-timer commented Apr 19, 2024

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Introduce perma-unstable `wasm-c-abi` flag #117919

Introduce perma-unstable `wasm-c-abi` flag #117919

daxpedda commented Nov 14, 2023 •

edited

liamrosenfeld commented Apr 17, 2024 •

edited