Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When failing to import core, suggest std #118065

Merged
merged 1 commit into from Nov 23, 2023
Merged

When failing to import core, suggest std #118065

merged 1 commit into from Nov 23, 2023
+29 −12

Conversation

estebank
Copy link
Contributor

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Nov 19, 2023

r? @TaKO8Ki

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 19, 2023
TaKO8Ki
TaKO8Ki reviewed Nov 22, 2023
View reviewed changes
Copy link
Member

@TaKO8Ki TaKO8Ki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one suggestion. After addressing that r=me

compiler/rustc_resolve/src/diagnostics.rs Outdated Show resolved Hide resolved
@TaKO8Ki TaKO8Ki added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 22, 2023
@estebank
Copy link
Contributor Author

@bors r=TaKO8Ki

@bors
Copy link
Contributor

bors commented Nov 22, 2023

📌 Commit ec50f1c has been approved by TaKO8Ki

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 22, 2023
@bors
Copy link
Contributor

bors commented Nov 23, 2023

⌛ Testing commit ec50f1c with merge 360bafa...

@bors
Copy link
Contributor

bors commented Nov 23, 2023

☀️ Test successful - checks-actions
Approved by: TaKO8Ki
Pushing 360bafa to master...

1 similar comment
@bors
Copy link
Contributor

bors commented Nov 23, 2023

☀️ Test successful - checks-actions
Approved by: TaKO8Ki
Pushing 360bafa to master...

@bors bors added merged-by-bors This PR was explicitly merged by bors. labels Nov 23, 2023
@bors bors merged commit 360bafa into rust-lang:master Nov 23, 2023
12 checks passed
@rustbot rustbot added this to the 1.76.0 milestone Nov 23, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (360bafa): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 674.393s -> 677.231s (0.42%)
Artifact size: 313.69 MiB -> 313.70 MiB (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TaKO8Ki TaKO8Ki TaKO8Ki left review comments

Assignees

@TaKO8Ki TaKO8Ki

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.76.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@estebank @rustbot @bors @rust-timer @TaKO8Ki