Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add never_patterns feature gate #118157

Merged
merged 1 commit into from Nov 29, 2023
Merged

Add never_patterns feature gate #118157

merged 1 commit into from Nov 29, 2023

Conversation

Nadrieril
Copy link
Member

This PR adds the feature gate and most basic parsing for the experimental never_patterns feature. See the tracking issue (#118155) for details on the experiment.

@scottmcm has agreed to be my lang-team liaison for this experiment.

@Nadrieril Nadrieril added the F-never_patterns `#![feature(never_patterns)]` label Nov 22, 2023
@rustbot
Copy link
Collaborator

rustbot commented Nov 22, 2023

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 22, 2023
@rustbot
Copy link
Collaborator

rustbot commented Nov 22, 2023

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

@rustbot

This comment was marked as off-topic.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Nadrieril Nadrieril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 22, 2023
@Nadrieril Nadrieril mentioned this pull request Nov 22, 2023
Open
5 tasks
@Nadrieril Nadrieril force-pushed the never_pat-feature-gate branch 2 times, most recently from ecb071c to 81e159b Compare November 22, 2023 01:33
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot
Copy link
Collaborator

rustbot commented Nov 22, 2023

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Nadrieril
Copy link
Member Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 22, 2023
@traviscross traviscross added the T-lang Relevant to the language team, which will review and decide on the PR/issue. label Nov 22, 2023
@traviscross
Copy link
Contributor

@rustbot labels +I-lang-nominated

Let's discuss this in triage to ensure the experiment can move forward.

@rustbot rustbot added the I-lang-nominated The issue / PR has been nominated for discussion during a lang team meeting. label Nov 22, 2023
@scottmcm
Copy link
Member

We discussed this in the lang triage meeting today.

Meeting consensus with quorum was that this experiment can go forward (without needing an FCP or similar to start the experiment)!

Un-tagging lang; this can land once reviewed.

@Nadrieril
Copy link
Member Author

r? @compiler-errors

@rustbot rustbot assigned compiler-errors and unassigned davidtwco Nov 29, 2023
compiler-errors
compiler-errors requested changes Nov 29, 2023
View reviewed changes
tests/ui/pattern/never_patterns.rs Outdated Show resolved Hide resolved
tests/ui/feature-gates/feature-gate-never_patterns.rs Show resolved Hide resolved
src/tools/rustfmt/src/patterns.rs Outdated Show resolved Hide resolved
src/tools/rustfmt/src/patterns.rs Show resolved Hide resolved
src/librustdoc/clean/utils.rs Show resolved Hide resolved
compiler/rustc_parse/src/parser/pat.rs Show resolved Hide resolved
compiler/rustc_mir_build/src/thir/pattern/deconstruct_pat.rs Outdated Show resolved Hide resolved
compiler/rustc_mir_build/src/build/matches/simplify.rs Show resolved Hide resolved
compiler/rustc_hir_typeck/src/pat.rs Outdated Show resolved Hide resolved
compiler/rustc_hir_typeck/src/pat.rs Outdated Show resolved Hide resolved
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 29, 2023
@Nadrieril
Copy link
Member Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 29, 2023
compiler-errors
compiler-errors approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit

please squash all commits into one so that rustfmt isn't unnecessarily touched in the git history at all, and then r=me

src/tools/rustfmt/src/patterns.rs Outdated Show resolved Hide resolved
@Nadrieril
Copy link
Member Author

@bors r=compiler-errors

@bors
Copy link
Contributor

bors commented Nov 29, 2023

📌 Commit a3838c8 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 29, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 29, 2023
@matthiaskrgr
Rollup merge of rust-lang#118157 - Nadrieril:never_pat-feature-gate, …
da1f9d4 
…r=compiler-errors

Add `never_patterns` feature gate

This PR adds the feature gate and most basic parsing for the experimental `never_patterns` feature. See the tracking issue (rust-lang#118155) for details on the experiment.

`@scottmcm` has agreed to be my lang-team liaison for this experiment.
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 29, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 29, 2023
@matthiaskrgr
Rollup merge of rust-lang#118157 - Nadrieril:never_pat-feature-gate, …
4915a5e 
…r=compiler-errors

Add `never_patterns` feature gate

This PR adds the feature gate and most basic parsing for the experimental `never_patterns` feature. See the tracking issue (rust-lang#118155) for details on the experiment.

``@scottmcm`` has agreed to be my lang-team liaison for this experiment.
This was referenced Nov 29, 2023
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 29, 2023
@bors
Auto merge of rust-lang#118443 - matthiaskrgr:rollup-mp8o3m4, r=matth…
ce4727f 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#118157 (Add `never_patterns` feature gate)
 - rust-lang#118191 (Suggest `let` or `==` on typo'd let-chain)
 - rust-lang#118231 (also add is_empty to const raw slices)
 - rust-lang#118333 (Print list of missing target features when calling a function with target features outside an unsafe block)
 - rust-lang#118426 (ConstProp: Correctly remove const if unknown value assigned to it.)
 - rust-lang#118428 (rustdoc: Move `AssocItemRender` and `RenderMode` to `html::render`.)
 - rust-lang#118438 (Update nto-qnx.md)

Failed merges:

 - rust-lang#118268 (Pretty print `Fn<(..., ...)>` trait refs with parentheses (almost) always)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c03f891 into rust-lang:master Nov 29, 2023
11 checks passed
@rustbot rustbot added this to the 1.76.0 milestone Nov 29, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 29, 2023
@rust-timer
Unrolled build for rust-lang#118157
5d5877b 
Rollup merge of rust-lang#118157 - Nadrieril:never_pat-feature-gate, r=compiler-errors

Add `never_patterns` feature gate

This PR adds the feature gate and most basic parsing for the experimental `never_patterns` feature. See the tracking issue (rust-lang#118155) for details on the experiment.

`@scottmcm` has agreed to be my lang-team liaison for this experiment.
@Nadrieril Nadrieril deleted the never_pat-feature-gate branch November 29, 2023 16:08
bors pushed a commit to rust-lang-ci/rust that referenced this pull request Dec 1, 2023
@matthiaskrgr
Rollup merge of rust-lang#118157 - Nadrieril:never_pat-feature-gate, …
071f8f6 
…r=compiler-errors

Add `never_patterns` feature gate

This PR adds the feature gate and most basic parsing for the experimental `never_patterns` feature. See the tracking issue (rust-lang#118155) for details on the experiment.

`@scottmcm` has agreed to be my lang-team liaison for this experiment.
@Nadrieril Nadrieril removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@compiler-errors compiler-errors

Labels
F-never_patterns `#![feature(never_patterns)]` T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.76.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@Nadrieril @rustbot @rust-log-analyzer @traviscross @scottmcm @bors @compiler-errors @davidtwco