Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intercrate ambiguity causes: ignore candidates which don't apply #118210

Merged
merged 1 commit into from Nov 24, 2023

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Nov 23, 2023

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 23, 2023
@lcnr lcnr added WG-trait-system-refactor The Rustc Trait System Refactor Initiative and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 23, 2023
@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 23, 2023

📌 Commit d51ef5c has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 23, 2023
@bors
Copy link
Contributor

bors commented Nov 23, 2023

⌛ Testing commit d51ef5c with merge f7324d2...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 23, 2023
…, r=compiler-errors

intercrate ambiguity causes: ignore candidates which don't apply

r? `@compiler-errors`
@rust-log-analyzer
Copy link
Collaborator

The job i686-gnu-nopt failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
   Compiling rustc_driver_impl v0.0.0 (/checkout/compiler/rustc_driver_impl)
[RUSTC-TIMING] rustc_smir test:false 37.971
   Compiling rustc-main v0.0.0 (/checkout/compiler/rustc)
[RUSTC-TIMING] build_script_build test:false 0.254
rustc: /checkout/src/llvm-project/llvm/include/llvm/ADT/DenseMap.h:649: bool llvm::DenseMapBase<DerivedT, KeyT, ValueT, KeyInfoT, BucketT>::LookupBucketFor(const LookupKeyT&, const BucketT*&) const [with LookupKeyT = unsigned int; DerivedT = llvm::DenseMap<unsigned int, unsigned int>; KeyT = unsigned int; ValueT = unsigned int; KeyInfoT = llvm::DenseMapInfo<unsigned int>; BucketT = llvm::detail::DenseMapPair<unsigned int, unsigned int>]: Assertion `!KeyInfoT::isEqual(Val, EmptyKey) && !KeyInfoT::isEqual(Val, TombstoneKey) && "Empty/Tombstone value shouldn't be inserted into map!"' failed.
[RUSTC-TIMING] rustc_borrowck test:false 248.908
rustc exited with signal: 6 (SIGABRT) (core dumped)

Caused by:
Caused by:
  process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc --crate-name rustc_borrowck --edition=2021 compiler/rustc_borrowck/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type lib --emit=dep-info,metadata,link -C opt-level=3 -C embed-bitcode=no -C debug-assertions=on -Zunstable-options --check-cfg 'cfg(feature, values())' -C metadata=74b86f142052b154 -C extra-filename=-74b86f142052b154 --out-dir /checkout/obj/build/i686-unknown-linux-gnu/stage1-rustc/i686-unknown-linux-gnu/release/deps --target i686-unknown-linux-gnu -L dependency=/checkout/obj/build/i686-unknown-linux-gnu/stage1-rustc/i686-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/i686-unknown-linux-gnu/stage1-rustc/release/deps --extern either=/checkout/obj/build/i686-unknown-linux-gnu/stage1-rustc/i686-unknown-linux-gnu/release/deps/libeither-633adb471c1c5b2c.rmeta --extern itertools=/checkout/obj/build/i686-unknown-linux-gnu/stage1-rustc/i686-unknown-linux-gnu/release/deps/libitertools-7849f9d4c4970a32.rmeta --extern polonius_engine=/checkout/obj/build/i686-unknown-linux-gnu/stage1-rustc/i686-unknown-linux-gnu/release/deps/libpolonius_engine-9b72184ac5ef8f72.rmeta --extern rustc_data_structures=/checkout/obj/build/i686-unknown-linux-gnu/stage1-rustc/i686-unknown-linux-gnu/release/deps/librustc_data_structures-8f0423ddf458e478.rmeta --extern rustc_errors=/checkout/obj/build/i686-unknown-linux-gnu/stage1-rustc/i686-unknown-linux-gnu/release/deps/librustc_errors-51e9a0d3f30dc19c.rmeta --extern rustc_fluent_macro=/checkout/obj/build/i686-unknown-linux-gnu/stage1-rustc/release/deps/librustc_fluent_macro-665a7cd003197d50.so --extern rustc_graphviz=/checkout/obj/build/i686-unknown-linux-gnu/stage1-rustc/i686-unknown-linux-gnu/release/deps/librustc_graphviz-248b41ae6e967afe.rmeta --extern rustc_hir=/checkout/obj/build/i686-unknown-linux-gnu/stage1-rustc/i686-unknown-linux-gnu/release/deps/librustc_hir-4c35b89c475b8c68.rmeta --extern rustc_index=/checkout/obj/build/i686-unknown-linux-gnu/stage1-rustc/i686-unknown-linux-gnu/release/deps/librustc_index-3e603860a44e38d7.rmeta --extern rustc_infer=/checkout/obj/build/i686-unknown-linux-gnu/stage1-rustc/i686-unknown-linux-gnu/release/deps/librustc_infer-b3290db5e2f792d9.rmeta --extern rustc_lexer=/checkout/obj/build/i686-unknown-linux-gnu/stage1-rustc/i686-unknown-linux-gnu/release/deps/librustc_lexer-2409775ee34b619a.rmeta --extern rustc_macros=/checkout/obj/build/i686-unknown-linux-gnu/stage1-rustc/release/deps/librustc_macros-0bf09d8462c7e36d.so --extern rustc_middle=/checkout/obj/build/i686-unknown-linux-gnu/stage1-rustc/i686-unknown-linux-gnu/release/deps/librustc_middle-00251355ca3baca2.rmeta --extern rustc_mir_dataflow=/checkout/obj/build/i686-unknown-linux-gnu/stage1-rustc/i686-unknown-linux-gnu/release/deps/librustc_mir_dataflow-b3427a6b89904c8d.rmeta --extern rustc_session=/checkout/obj/build/i686-unknown-linux-gnu/stage1-rustc/i686-unknown-linux-gnu/release/deps/librustc_session-e2bfcee931c312a6.rmeta --extern rustc_span=/checkout/obj/build/i686-unknown-linux-gnu/stage1-rustc/i686-unknown-linux-gnu/release/deps/librustc_span-80a08a940fd6aee4.rmeta --extern rustc_target=/checkout/obj/build/i686-unknown-linux-gnu/stage1-rustc/i686-unknown-linux-gnu/release/deps/librustc_target-bd3fbbe82b49accb.rmeta --extern rustc_trait_selection=/checkout/obj/build/i686-unknown-linux-gnu/stage1-rustc/i686-unknown-linux-gnu/release/deps/librustc_trait_selection-f4b63586dab74d5b.rmeta --extern rustc_traits=/checkout/obj/build/i686-unknown-linux-gnu/stage1-rustc/i686-unknown-linux-gnu/release/deps/librustc_traits-09ab615ea478741b.rmeta --extern smallvec=/checkout/obj/build/i686-unknown-linux-gnu/stage1-rustc/i686-unknown-linux-gnu/release/deps/libsmallvec-eaf9cdb303b98e0e.rmeta --extern tracing=/checkout/obj/build/i686-unknown-linux-gnu/stage1-rustc/i686-unknown-linux-gnu/release/deps/libtracing-7e0886fb04a94aeb.rmeta --cfg=windows_raw_dylib -Csymbol-mangling-version=v0 -Zunstable-options '--check-cfg=cfg(bootstrap,values())' '--check-cfg=cfg(parallel_compiler,values())' '--check-cfg=cfg(no_btreemap_remove_entry,values())' '--check-cfg=cfg(crossbeam_loom,values())' '--check-cfg=cfg(span_locations,values())' '--check-cfg=cfg(rustix_use_libc,values())' '--check-cfg=cfg(emulate_second_only_system,values())' '--check-cfg=cfg(windows_raw_dylib,values())' -Zmacro-backtrace -Clink-args=-Wl,-z,origin '-Clink-args=-Wl,-rpath,$ORIGIN/../lib' -Csplit-debuginfo=off -Zunstable-options '-Wrustc::internal' -Cprefer-dynamic --cfg=parallel_compiler -Z binary-dep-depinfo -L native=/checkout/obj/build/i686-unknown-linux-gnu/stage1-rustc/i686-unknown-linux-gnu/release/build/psm-9eea3609b0ffc79e/out` (exit status: 254)
[RUSTC-TIMING] rustc_builtin_macros test:false 107.930
[RUSTC-TIMING] rustc_mir_transform test:false 269.455
[RUSTC-TIMING] rustc_hir_typeck test:false 270.147
[RUSTC-TIMING] rustc_driver_impl test:false 80.741

@bors
Copy link
Contributor

bors commented Nov 23, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 23, 2023
@compiler-errors
Copy link
Member

That doesn't look related

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 23, 2023
@bors
Copy link
Contributor

bors commented Nov 24, 2023

⌛ Testing commit d51ef5c with merge 0f32341...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 24, 2023
…, r=compiler-errors

intercrate ambiguity causes: ignore candidates which don't apply

r? `@compiler-errors`
@rust-log-analyzer
Copy link
Collaborator

The job armhf-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
error: test run failed!
status: exit status: 101
command: RUST_TEST_THREADS="8" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/remote-test-client" "run" "0" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/tail-cps/a"
--- stdout -------------------------------
uploaded "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/tail-cps/a", waiting for result
--- stderr -------------------------------
thread 'main' panicked at src/tools/remote-test-client/src/main.rs:310:9:
client.read_exact(&mut header) failed with Connection reset by peer (os error 104)
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@bors
Copy link
Contributor

bors commented Nov 24, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 24, 2023
@lcnr
Copy link
Contributor Author

lcnr commented Nov 24, 2023

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 24, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 24, 2023
…mpiler-errors

Rollup of 7 pull requests

Successful merges:

 - rust-lang#118187 (Recompile LLVM when it changes in the git sources)
 - rust-lang#118210 (intercrate ambiguity causes: ignore candidates which don't apply)
 - rust-lang#118215 (Add common trait for crate definitions)
 - rust-lang#118238 (memcpy assumptions: update GCC link)
 - rust-lang#118243 (EvalCtxt::commit_if_ok don't inherit nested goals)
 - rust-lang#118245 (Add `Span` to `TraitBoundModifier`)
 - rust-lang#118246 (Remove a hack for effects)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ffacd54 into rust-lang:master Nov 24, 2023
11 of 12 checks passed
@rustbot rustbot added this to the 1.76.0 milestone Nov 24, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 24, 2023
Rollup merge of rust-lang#118210 - lcnr:intercrate-ambiguity-causes-uwu, r=compiler-errors

intercrate ambiguity causes: ignore candidates which don't apply

r? `@compiler-errors`
@lcnr lcnr deleted the intercrate-ambiguity-causes-uwu branch November 24, 2023 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. WG-trait-system-refactor The Rustc Trait System Refactor Initiative
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants