Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve: Avoid clones of MacroData #118272

Merged
merged 1 commit into from
Nov 25, 2023
Merged

resolve: Avoid clones of MacroData #118272

merged 1 commit into from
Nov 25, 2023

Conversation

petrochenkov
Copy link
Contributor

And move declarative macro compilation to an earlier point in def collector, which is required for #118188.

@petrochenkov
resolve: Avoid clones of MacroData
ad0770e 
And move declarative macro compilation to an earlier point in def collector, which is required for rust-lang#118188.
@rustbot
Copy link
Collaborator

rustbot commented Nov 24, 2023

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 24, 2023
@cjgillot
Copy link
Contributor

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 25, 2023
@bors
Copy link
Contributor

bors commented Nov 25, 2023

⌛ Trying commit ad0770e with merge 16e9c82...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 25, 2023
@bors
Auto merge of rust-lang#118272 - petrochenkov:macrodata, r=<try>
16e9c82 
resolve: Avoid clones of `MacroData`

And move declarative macro compilation to an earlier point in def collector, which is required for rust-lang#118188.
@bors
Copy link
Contributor

bors commented Nov 25, 2023

☀️ Try build successful - checks-actions
Build commit: 16e9c82 (16e9c8210f239415f76582640bc52de29d58f008)

1 similar comment
@bors
Copy link
Contributor

bors commented Nov 25, 2023

☀️ Try build successful - checks-actions
Build commit: 16e9c82 (16e9c8210f239415f76582640bc52de29d58f008)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (16e9c82): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.7% [1.2%, 4.9%] 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 676.226s -> 674.506s (-0.25%)
Artifact size: 313.43 MiB -> 313.49 MiB (0.02%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 25, 2023
@petrochenkov
Copy link
Contributor Author

@bors rollup=maybe

@cjgillot
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Nov 25, 2023

📌 Commit ad0770e has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 25, 2023
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 25, 2023
@GuillaumeGomez
Rollup merge of rust-lang#118272 - petrochenkov:macrodata, r=cjgillot
2b63473 
resolve: Avoid clones of `MacroData`

And move declarative macro compilation to an earlier point in def collector, which is required for rust-lang#118188.
This was referenced Nov 25, 2023
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 25, 2023
@bors
Auto merge of rust-lang#118294 - GuillaumeGomez:rollup-ij2bzwt, r=Gui…
ec1393f 
…llaumeGomez

Rollup of 6 pull requests

Successful merges:

 - rust-lang#116446 (Yeet `mir::Const::from_anon_const`)
 - rust-lang#117871 (remove unused pub fns)
 - rust-lang#118017 (rustc_lint: address latent TODO)
 - rust-lang#118199 (Remove `HirId` from `QPath::LangItem`)
 - rust-lang#118272 (resolve: Avoid clones of `MacroData`)
 - rust-lang#118291 (rustdoc-search: clean up some DOM code)

Failed merges:

 - rust-lang#118201 (Miscellaneous `ObligationCauseCode` cleanups)
 - rust-lang#118256 (rustc: `hir().local_def_id_to_hir_id()` -> `tcx.local_def_id_to_hir_id()` cleanup)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9b1da03 into rust-lang:master Nov 25, 2023
12 checks passed
@rustbot rustbot added this to the 1.76.0 milestone Nov 25, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 25, 2023
@rust-timer
Unrolled build for rust-lang#118272
92efb3b 
Rollup merge of rust-lang#118272 - petrochenkov:macrodata, r=cjgillot

resolve: Avoid clones of `MacroData`

And move declarative macro compilation to an earlier point in def collector, which is required for rust-lang#118188.
@petrochenkov petrochenkov mentioned this pull request Nov 27, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 28, 2023
@bors
Auto merge of rust-lang#118188 - petrochenkov:defeed, r=cjgillot
5facb42 
resolve: Feed the `def_kind` query immediately on `DefId` creation

Before this PR the def kind query required building HIR for no good reason, with this PR def kinds are instead assigned immediately when `DefId`s are created.

Some PRs previously refactored things to make all def kinds to be available early enough - rust-lang#118250, rust-lang#118272, rust-lang#118311.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cjgillot cjgillot

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.76.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@petrochenkov @rustbot @cjgillot @rust-timer @bors