Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce must_use on associated types and RPITITs that have a must-use trait in bounds #118504

Merged
merged 1 commit into from
Dec 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/rustc_lint/src/unused.rs
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ impl<'tcx> LateLintPass<'tcx> for UnusedResults {
.map(|inner| MustUsePath::Pinned(Box::new(inner)))
}
ty::Adt(def, _) => is_def_must_use(cx, def.did(), span),
ty::Alias(ty::Opaque, ty::AliasTy { def_id: def, .. }) => {
ty::Alias(ty::Opaque | ty::Projection, ty::AliasTy { def_id: def, .. }) => {
elaborate(
cx.tcx,
cx.tcx.explicit_item_bounds(def).instantiate_identity_iter_copied(),
Expand Down
15 changes: 15 additions & 0 deletions tests/ui/lint/unused/assoc-types.assoc_ty.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
error: unused implementer of `Future` that must be used
--> $DIR/assoc-types.rs:19:5
|
LL | T::foo();
| ^^^^^^^^
|
= note: futures do nothing unless you `.await` or poll them
note: the lint level is defined here
--> $DIR/assoc-types.rs:4:9
|
LL | #![deny(unused_must_use)]
| ^^^^^^^^^^^^^^^

error: aborting due to 1 previous error

15 changes: 15 additions & 0 deletions tests/ui/lint/unused/assoc-types.rpitit.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
error: unused implementer of `Future` that must be used
--> $DIR/assoc-types.rs:19:5
|
LL | T::foo();
| ^^^^^^^^
|
= note: futures do nothing unless you `.await` or poll them
note: the lint level is defined here
--> $DIR/assoc-types.rs:4:9
|
LL | #![deny(unused_must_use)]
| ^^^^^^^^^^^^^^^

error: aborting due to 1 previous error

23 changes: 23 additions & 0 deletions tests/ui/lint/unused/assoc-types.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
// edition: 2021
// revisions: rpitit assoc_ty

#![deny(unused_must_use)]

use std::future::Future;

pub trait Tr {
type Fut: Future<Output = ()>;

#[cfg(rpitit)]
fn foo() -> impl Future<Output = ()>;

#[cfg(assoc_ty)]
fn foo() -> Self::Fut;
}

pub async fn bar<T: Tr>() {
T::foo();
//~^ ERROR unused implementer of `Future` that must be used
}

fn main() {}