New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable emutls by default for android #118613
base: master
Are you sure you want to change the base?
Conversation
r? @cjgillot (rustbot has picked a reviewer for you, use r? to override) |
☔ The latest upstream changes (presumably #117873) made this pull request unmergeable. Please resolve the merge conflicts. |
r? compiler |
dbc94ed
to
05e4196
Compare
@bors r+ ref: #117873 (comment) |
@bors r- This is the part of the PR that needs careful consideration (and probably FCP!) |
(Sorry if r-ing a t-compiler PR was out of line, I figured it happened due to a misunderstanding though). It's still a draft too. Does this version link against libc++? (And if not, do thread locals work in dylibs) |
There is currently no progress and someone needs to decide how to provide emutls symbols. I'm already satisfied with the |
This is a split of #117873
This is an attempt to enable emutls by default in android.
The current unresolved problem is that if use emutls provided by
compiler-builtins
, then eachso
will have its own emutls symbol during dynamic linking, causing thread_local of eachso
to be independent of each other.One solution to this problem is to link against
libc++_shared.so
provided by android ndk, but this cause in additional runtime dependencies and looks a bit strange.