Rollup of 8 pull requests #118732

matthiaskrgr · 2023-12-08T05:44:44Z

Successful merges:

Elaborate on ip_addr bit conversion endianness #118505 (Elaborate on ip_addr bit conversion endianness)
OnceLock: Add note about drop and statics #118581 (OnceLock: Add note about drop and statics)
[rustdoc] Fix display of features #118677 ([rustdoc] Fix display of features)
coverage: Avoid unnecessary macros in unit tests #118690 (coverage: Avoid unnecessary macros in unit tests)
Tell MirUsedCollector that the pointer alignment checks calls its panic symbol #118693 (Tell MirUsedCollector that the pointer alignment checks calls its panic symbol)
coverage: Merge refined spans in a separate final pass #118695 (coverage: Merge refined spans in a separate final pass)
fix jobserver GLOBAL_CLIENT_CHECKED uninitialized before use #118709 (fix jobserver GLOBAL_CLIENT_CHECKED uninitialized before use)
rustdoc: remove unused parameter reversed from onEach(Lazy) #118722 (rustdoc: remove unused parameter reversed from onEach(Lazy))

r? @ghost
@rustbot modify labels: rollup

These macros don't provide enough value to justify their complexity, when they can just as easily be functions instead.

…ic symbol

This makes `push_refined_span` trivial, which will let us inline it and benefit from partial borrows of `refined_spans`.

Adds explanation of how endianness is handled when converting `Ipv4Addr` and `Ipv6Addr` to and from bits. Addresses rust-lang#113744

This feature was added in edec580 to support JavaScript-based toggles that were later replaced with HTML `<details>`.

2. jobserver::initialize_checked should call before build_session, still should use EarlyErrorHandler, so revert stderr change in rust-lang#118635

…s, r=cuviper Elaborate on ip_addr bit conversion endianness Adds explanation of how endianness is handled when converting `Ipv4Addr` and `Ipv6Addr` to and from bits. This is intended to unblock stabilization of the affected methods. Addresses rust-lang#113744

…k, r=workingjubilee OnceLock: Add note about drop and statics Hi! Just a minor documentation addition, I've attempted to build docs locally but ran in to issues, so am not 100% sure this change will render correctly.

…notriddle [rustdoc] Fix display of features Fixes rust-lang#118615. It now looks like this: ![image](https://github.com/rust-lang/rust/assets/3050060/6e77204e-0706-44a3-89ae-2dbd1934ebbc) We can't use flex without breaking the flow, meaning we can't vertically align items as we want. Because of that, the `min-height` was problematic as it rendered weirdly and therefore needed to be removed. r? `@notriddle`

coverage: Avoid unnecessary macros in unit tests These macros don't provide enough value to justify their complexity, when they can just as easily be functions instead. --- `@rustbot` label +A-code-coverage

…achable, r=bjorn3 Tell MirUsedCollector that the pointer alignment checks calls its panic symbol Fixes rust-lang#118683 (not an issue, but that PR is a basically a bug report) When we had `panic_immediate_abort` start adding `#[inline]` to this panic function, builds started breaking because we failed to write up the MIR assert terminator to the correct panic shim. Things happened to work before by pure luck because without this feature enabled, the function we're inserting calls to is `#[inline(never)]` so we always generated code for it. r? bjorn3

coverage: Merge refined spans in a separate final pass Pulling this merge step out of `push_refined_span` and into a separate pass lets us push directly to `refined_spans` instead of calling a helper method. Because the compiler can now see partial borrows of `refined_spans`, we can remove some extra code that was jumping through hoops to satisfy the borrow checker. --- ``@rustbot`` label +A-code-coverage

fix jobserver GLOBAL_CLIENT_CHECKED uninitialized before use override rust-lang#118589, resolve merge conflict `@petrochenkov` `@SparrowLii` Thanks!

…uillaumeGomez rustdoc: remove unused parameter `reversed` from onEach(Lazy) This feature was added in edec580 to support JavaScript-based toggles that were later replaced with HTML `<details>`.

matthiaskrgr · 2023-12-08T05:46:59Z

@bors r+ rollup=never p=8

bors · 2023-12-08T05:47:01Z

📌 Commit 9dd34d5 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2023-12-08T07:12:30Z

⌛ Testing commit 9dd34d5 with merge 8043f62...

bors · 2023-12-08T09:28:34Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 8043f62 to master...

rust-timer · 2023-12-08T09:30:49Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#118505	Elaborate on ip_addr bit conversion endianness	`6ba458237a9f9c481939a39d5871ffe48d58a71e` (link)
#118581	OnceLock: Add note about drop and statics	`c7a9b1eb2d3265b9865dcbd6a67f0ffc2f2748b8` (link)
#118677	[rustdoc] Fix display of features	`b7fe885faa88037ca0e9a77be4e1f836a673c359` (link)
#118690	coverage: Avoid unnecessary macros in unit tests	`e837c60bca251f1063b8b416f0f5f8e50737baa8` (link)
#118693	Tell MirUsedCollector that the pointer alignment checks cal…	`010eed4a64a14a67c64e14ef220d322f50212bb8` (link)
#118695	coverage: Merge refined spans in a separate final pass	`3275065050074bab119a8beec281edc48ef508a4` (link)
#118709	fix jobserver GLOBAL_CLIENT_CHECKED uninitialized before use	`acd6e456736d9fa6d3999fb9e298b664b8a40883` (link)
#118722	rustdoc: remove unused parameter `reversed` from onEach(Laz…	`b7b79b11ed436dd094d36cd64302ea4f55b35134` (link)

previous master: 6c470a557a

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2023-12-08T11:11:59Z

Finished benchmarking commit (8043f62): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.2%	[0.2%, 0.2%]	1
Improvements ✅ (primary)	-2.5%	[-2.5%, -2.5%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.5%	[-2.5%, -2.5%]	1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.5%, 0.7%]	2
Regressions ❌ (secondary)	3.7%	[3.7%, 3.7%]	1
Improvements ✅ (primary)	-0.8%	[-1.5%, -0.4%]	4
Improvements ✅ (secondary)	-1.3%	[-1.3%, -1.2%]	3
All ❌✅ (primary)	-0.3%	[-1.5%, 0.7%]	6

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.2%	[-2.2%, -2.2%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.2%	[-2.2%, -2.2%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 673.544s -> 674.492s (0.14%)
Artifact size: 314.03 MiB -> 314.05 MiB (0.01%)

lqd · 2023-12-08T11:57:14Z

The syn change is definitely noise, and we'll see how tuple-stress evolves but it could be as well.

Mark-Simulacrum · 2023-12-12T00:46:16Z

I think both are noise.

tuple-stress:

Zalathar and others added 19 commits December 7, 2023 11:12

coverage: Avoid unnecessary macros in unit tests

47e6e5e

These macros don't provide enough value to justify their complexity, when they can just as easily be functions instead.

Tell MirUsedCollector that the pointer alignment checks calls its pan…

aa58ccb

…ic symbol

coverage: Merge refined spans in a separate final pass

ec0110b

This makes `push_refined_span` trivial, which will let us inline it and benefit from partial borrows of `refined_spans`.

coverage: Inline push_refined_span

9089d28

coverage: Simplify code that pushes to refined_spans

9a43215

Fix display of features in rustdoc

bf681dc

Extend GUI tests for doc_cfg

9e1797b

Elaborate on ip_addr bit conversion endianness

c3bb1b5

Adds explanation of how endianness is handled when converting `Ipv4Addr` and `Ipv6Addr` to and from bits. Addresses rust-lang#113744

rustdoc: remove unused parameter reversed from onEach(Lazy)

6a0a89a

This feature was added in edec580 to support JavaScript-based toggles that were later replaced with HTML `<details>`.

OnceLock: Rework example, statics aren't dropped

88fccc4

1. fix jobserver GLOBAL_CLIENT_CHECKED uninitialized before use

dabedb7

2. jobserver::initialize_checked should call before build_session, still should use EarlyErrorHandler, so revert stderr change in rust-lang#118635

Rollup merge of rust-lang#118690 - Zalathar:test-macros, r=cjgillot

0c121b5

coverage: Avoid unnecessary macros in unit tests These macros don't provide enough value to justify their complexity, when they can just as easily be functions instead. --- `@rustbot` label +A-code-coverage

Rollup merge of rust-lang#118709 - oksbsb:fix-job-server, r=SparrowLii

beabb5e

fix jobserver GLOBAL_CLIENT_CHECKED uninitialized before use override rust-lang#118589, resolve merge conflict `@petrochenkov` `@SparrowLii` Thanks!

Rollup merge of rust-lang#118722 - notriddle:notriddle/dom-opt-3, r=G…

9dd34d5

…uillaumeGomez rustdoc: remove unused parameter `reversed` from onEach(Lazy) This feature was added in edec580 to support JavaScript-based toggles that were later replaced with HTML `<details>`.

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 8, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 8, 2023

bors merged commit 8043f62 into rust-lang:master Dec 8, 2023
12 checks passed

rustbot added this to the 1.76.0 milestone Dec 8, 2023

rustbot added the perf-regression Performance regression. label Dec 8, 2023

Mark-Simulacrum added the perf-regression-triaged The performance regression has been triaged. label Dec 12, 2023

matthiaskrgr deleted the rollup-ub9pgjm branch March 16, 2024 18:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 8 pull requests #118732

Rollup of 8 pull requests #118732

matthiaskrgr commented Dec 8, 2023

matthiaskrgr commented Dec 8, 2023

bors commented Dec 8, 2023

bors commented Dec 8, 2023

bors commented Dec 8, 2023

rust-timer commented Dec 8, 2023

rust-timer commented Dec 8, 2023

lqd commented Dec 8, 2023

Mark-Simulacrum commented Dec 12, 2023

Rollup of 8 pull requests #118732

Rollup of 8 pull requests #118732

Conversation

matthiaskrgr commented Dec 8, 2023

matthiaskrgr commented Dec 8, 2023

bors commented Dec 8, 2023

bors commented Dec 8, 2023

bors commented Dec 8, 2023

rust-timer commented Dec 8, 2023

rust-timer commented Dec 8, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

Binary size

lqd commented Dec 8, 2023

Mark-Simulacrum commented Dec 12, 2023