New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't print host effect param in pretty path_generic_args
#118788
Conversation
Some changes might have occurred in exhaustiveness checking cc @Nadrieril Some changes occurred in need_type_info.rs cc @lcnr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (42dfac5): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 667.481s -> 670.131s (0.40%) |
Make
own_args_no_defaults
pass back theGenericParamDef
, so that we can pass both the args and param definitions intopath_generic_args
. That allows us to use theGenericParamDef
to filter out effect params.This allows us to filter out the host param regardless of whether it's
sym::host
ortrue
/false
.This also renames a couple of
const_effect_param
->host_effect_param
, and restores~const
pretty printing toTraitPredPrintModifiersAndPath
.cc #118785
r? @fee1-dead cc @oli-obk