Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use immediate_backend_type when reading from a const alloc #118791

Merged
merged 1 commit into from Dec 10, 2023

Conversation

saethlin
Copy link
Member

@saethlin saethlin commented Dec 9, 2023

Fixes #118047

r? @nikic

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 9, 2023
@nikic
Copy link
Contributor

nikic commented Dec 9, 2023

Do we need a test for this? The errant IR is only found by an assertion, what comes out with --emit=llvm-ir looks like it's been fixed up by something.

"Does not assert" seems like a worthwhile thing to test.

@saethlin
Copy link
Member Author

saethlin commented Dec 9, 2023

I've added a ui/codegen test based on my reduced example

@nikic
Copy link
Contributor

nikic commented Dec 10, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Dec 10, 2023

📌 Commit b0a5801 has been approved by nikic

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 10, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 10, 2023
Use immediate_backend_type when reading from a const alloc

Fixes rust-lang#118047

r? `@nikic`
@bors
Copy link
Contributor

bors commented Dec 10, 2023

⌛ Testing commit b0a5801 with merge 7e452c1...

@bors
Copy link
Contributor

bors commented Dec 10, 2023

☀️ Test successful - checks-actions
Approved by: nikic
Pushing 7e452c1 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 10, 2023
@bors bors merged commit 7e452c1 into rust-lang:master Dec 10, 2023
12 checks passed
@rustbot rustbot added this to the 1.76.0 milestone Dec 10, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (7e452c1): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.4% [2.4%, 2.4%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.4% [2.4%, 2.4%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.1% [-1.2%, -1.1%] 2
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -1.1% [-1.2%, -1.1%] 2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 668.148s -> 668.954s (0.12%)
Artifact size: 314.08 MiB -> 314.14 MiB (0.02%)

@saethlin saethlin deleted the use-immediate-type branch December 14, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataflowConstProp trips LLVM assertion "Invalid constexpr bitcast!"
5 participants