Use bool instead of PartiolOrd as return value of the comparison closure in {slice,Iteraotr}::is_sorted_by
#118811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
the8472
reviewed
Dec 11, 2023
|
I have following concern:
|
|
Is sorted is an unstable feature, so breaking changes are allowed. |
Mark-Simulacrum
requested changes
Dec 16, 2023
rustbot
added
S-waiting-on-author
|
(this is marked as
S-waiting-on-author
|
|
@rustbot review Ty for the pointer @WaffleLapkin |
rustbot
added
S-waiting-on-review
|
r=me with commits squashed. Thanks! |
EbbDrop
force-pushed
the
is-sorted-by-bool
branch
from
c2c00f5
to
606eeb8
Compare
|
@bors r=Mark-Simulacrum |
|
@EbbDrop: 🔑 Insufficient privileges: Not in reviewers |
|
@Mark-Simulacrum Looks like i am not allowed to use that bors command |
|
@bors r=Mark-Simulacrum |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 21, 2024
Rollup of 8 pull requests Successful merges: - rust-lang#116090 (Implement strict integer operations that panic on overflow) - rust-lang#118811 (Use `bool` instead of `PartiolOrd` as return value of the comparison closure in `{slice,Iteraotr}::is_sorted_by`) - rust-lang#119081 (Add Ipv6Addr::is_ipv4_mapped) - rust-lang#119461 (Use an interpreter in MIR jump threading) - rust-lang#119996 (Move OS String implementation into `sys`) - rust-lang#120015 (coverage: Format all coverage tests with `rustfmt`) - rust-lang#120027 (pattern_analysis: Remove `Ty: Copy` bound) - rust-lang#120084 (fix(rust-analyzer): use new pkgid spec to compare) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 21, 2024
Rollup merge of rust-lang#118811 - EbbDrop:is-sorted-by-bool, r=Mark-Simulacrum Use `bool` instead of `PartiolOrd` as return value of the comparison closure in `{slice,Iteraotr}::is_sorted_by` Changes the function signature of the closure given to `{slice,Iteraotr}::is_sorted_by` to return a `bool` instead of a `PartiolOrd` as suggested by the libs-api team here: rust-lang#53485 (comment). This means these functions now return true if the closure returns true for all the pairs of values.
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the function signature of the closure given to
{slice,Iteraotr}::is_sorted_byto return aboolinstead of aPartiolOrdas suggested by the libs-api team here: #53485 (comment).This means these functions now return true if the closure returns true for all the pairs of values.