[DO NOT MERGE] Introduce mechanism to write compiler metrics to disk

[estebank]

I want to verify the performance impact of enabling this new behavior against perf.

[rustbot]

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

[estebank]

@bors try @rust-timer queue

[bors]

⌛ Trying commit dbbb434 with merge 75a3f82...

[estebank]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 6c24541 with merge d6a63ff...

[bors]

💔 Test failed - checks-actions

[estebank]

@bors try @rust-timer queue

[bors]

⌛ Trying commit dfaca28 with merge ede0202...

[bors]

☀️ Try build successful - checks-actions
Build commit: ede0202 (ede0202ac7bd9098e93296c47c0d62c3b7c2205c)

[rust-timer]

Finished benchmarking commit (ede0202): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.2%	[0.2%, 4.0%]	175
Regressions ❌ (secondary)	1.6%	[0.2%, 5.0%]	103
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.2%	[0.2%, 4.0%]	175

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.3%	[0.6%, 1.9%]	2
Regressions ❌ (secondary)	3.7%	[0.9%, 8.6%]	11
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.4%	[-5.7%, -1.3%]	4
All ❌✅ (primary)	1.3%	[0.6%, 1.9%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.2%	[0.6%, 5.6%]	72
Regressions ❌ (secondary)	4.4%	[1.6%, 8.5%]	27
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.2%	[0.6%, 5.6%]	72

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 672.799s -> 674.95s (0.32%)
Artifact size: 312.41 MiB -> 312.48 MiB (0.02%)

[estebank]

@bors try @rust-timer queue

[bors]

🔒 Merge conflict

This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.

How do I rebase?

Assuming self is your fork and upstream is this repository, you can resolve the conflict following these steps:

1. git checkout compiler-metrics (switch to your branch)
2. git fetch upstream master (retrieve the latest master)
3. git rebase upstream/master -p (rebase on top of it)
4. Follow the on-screen instruction to resolve conflicts (check git status if you got lost).
5. git push self compiler-metrics --force-with-lease (update this PR)

You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial.

Please avoid the "Resolve conflicts" button on GitHub. It uses git merge instead of git rebase which makes the PR commit history more difficult to read.

Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Cargo.lock conflict is handled during merge and rebase. This is normal, and you should still perform step 5 to update this PR.

Error message

Auto-merging compiler/rustc_passes/src/hir_stats.rs
CONFLICT (content): Merge conflict in compiler/rustc_passes/src/hir_stats.rs
Automatic merge failed; fix conflicts and then commit the result.

[estebank]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 600f6a4 with merge 6c07765...

[bors]

☀️ Try build successful - checks-actions
Build commit: 6c07765 (6c07765fc9bda772e75cded94387855f577f8769)

[rust-timer]

Finished benchmarking commit (6c07765): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.4%	[-0.4%, -0.4%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.8%	[0.4%, 1.5%]	3
Regressions ❌ (secondary)	3.2%	[2.0%, 4.3%]	2
Improvements ✅ (primary)	-0.5%	[-0.5%, -0.4%]	2
Improvements ✅ (secondary)	-1.5%	[-1.5%, -1.5%]	1
All ❌✅ (primary)	0.3%	[-0.5%, 1.5%]	5

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 673.56s -> 673.417s (-0.02%)
Artifact size: 312.39 MiB -> 312.43 MiB (0.01%)