clippy::complexity fixes #118885
Merged
clippy::complexity fixes #118885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filter_map_identity needless_bool search_is_some unit_arg map_identity needless_question_mark derivable_impls
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-query-system
|
Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
compiler-errors
approved these changes
Dec 12, 2023
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
RalfJung
reviewed
Dec 12, 2023
| @@ -21,7 +21,7 @@ pub trait ValueVisitor<'mir, 'tcx: 'mir, M: Machine<'mir, 'tcx>>: Sized { | |||
| /// `read_discriminant` can be hooked for better error messages. | |||
| #[inline(always)] | |||
| fn read_discriminant(&mut self, v: &Self::V) -> InterpResult<'tcx, VariantIdx> { | |||
| Ok(self.ecx().read_discriminant(&v.to_op(self.ecx())?)?) | |||
| self.ecx().read_discriminant(&v.to_op(self.ecx())?) | |||
There was a problem hiding this comment.
I usually prefer consistently putting in the ? and Ok-wrapping... but I guess it's futile to fight against clippy lints :/
There was a problem hiding this comment.
I think in this case, the ())?)?) is pretty hard to read
There was a problem hiding this comment.
(deleted, misread 😅
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 12, 2023
…r-errors clippy::complexity fixes filter_map_identity needless_bool search_is_some unit_arg map_identity needless_question_mark derivable_impls
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Dec 12, 2023
…r-errors clippy::complexity fixes filter_map_identity needless_bool search_is_some unit_arg map_identity needless_question_mark derivable_impls
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 12, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#117050 ([`RFC 3086`] Attempt to try to resolve blocking concerns ) - rust-lang#118500 (Move some methods from `tcx.hir()` to `tcx`) - rust-lang#118871 (Coroutine variant fields can be uninitialized) - rust-lang#118872 (Add rustX check to codeblock attributes lint) - rust-lang#118884 (NFC: simplify merging of two vecs) - rust-lang#118885 (clippy::complexity fixes) - rust-lang#118886 (Clean up variables in `search.js`) - rust-lang#118887 (Typo) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 13, 2023
…kingjubilee Rollup of 10 pull requests Successful merges: - rust-lang#118858 (Remove dead codes in core) - rust-lang#118864 (Fix alignment passed down to LLVM for simd_masked_load) - rust-lang#118872 (Add rustX check to codeblock attributes lint) - rust-lang#118873 (fix `waker_getters` tracking issue number) - rust-lang#118884 (NFC: simplify merging of two vecs) - rust-lang#118885 (clippy::complexity fixes) - rust-lang#118886 (Clean up variables in `search.js`) - rust-lang#118887 (Typo) - rust-lang#118889 (more clippy::complexity fixes) - rust-lang#118891 (Actually parse async gen blocks correctly) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 13, 2023
Rollup merge of rust-lang#118885 - matthiaskrgr:compl_2023, r=compiler-errors clippy::complexity fixes filter_map_identity needless_bool search_is_some unit_arg map_identity needless_question_mark derivable_impls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filter_map_identity
needless_bool
search_is_some
unit_arg
map_identity
needless_question_mark
derivable_impls