Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uplift TypeAndMut and ClosureKind to rustc_type_ir #118888

Merged
merged 3 commits into from Dec 15, 2023

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented Dec 12, 2023

Uplifts TypeAndMut and ClosureKind

I know I said I was just going to get rid of TypeAndMut (rust-lang/types-team#124) but I think this is much simpler, lol

r? @jackh726 or @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 12, 2023
@compiler-errors compiler-errors changed the title Uplift more things Uplift TypeAndMut and ClosureKind to rustc_type_ir Dec 12, 2023
@rustbot
Copy link
Collaborator

rustbot commented Dec 12, 2023

Could not assign reviewer from: jackh726.
User(s) jackh726 are either the PR author, already assigned, or on vacation, and there are no other candidates.
Use r? to specify someone else to assign.

@rust-log-analyzer

This comment has been minimized.

@rustbot
Copy link
Collaborator

rustbot commented Dec 12, 2023

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@rust-log-analyzer

This comment has been minimized.

@jackh726
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Dec 14, 2023

📌 Commit 742f193 has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 14, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 15, 2023
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#116888 (Add discussion that concurrent access to the environment is unsafe)
 - rust-lang#118888 (Uplift `TypeAndMut` and `ClosureKind` to `rustc_type_ir`)
 - rust-lang#118929 (coverage: Tidy up early parts of the instrumentor pass)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d5af762 into rust-lang:master Dec 15, 2023
11 checks passed
@rustbot rustbot added this to the 1.76.0 milestone Dec 15, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 15, 2023
Rollup merge of rust-lang#118888 - compiler-errors:uplift-more-things, r=jackh726

Uplift `TypeAndMut` and `ClosureKind` to `rustc_type_ir`

Uplifts `TypeAndMut` and `ClosureKind`

I know I said I was just going to get rid of `TypeAndMut` (rust-lang/types-team#124) but I think this is much simpler, lol

r? `@jackh726` or `@lcnr`
flip1995 pushed a commit to flip1995/rust that referenced this pull request Dec 16, 2023
…, r=jackh726

Uplift `TypeAndMut` and `ClosureKind` to `rustc_type_ir`

Uplifts `TypeAndMut` and `ClosureKind`

I know I said I was just going to get rid of `TypeAndMut` (rust-lang/types-team#124) but I think this is much simpler, lol

r? `@jackh726` or `@lcnr`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants