Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Erase late bound regions from Instance::fn_sig() and add a few more details to StableMIR APIs #118927

Merged
merged 4 commits into from
Dec 15, 2023
Merged

Erase late bound regions from Instance::fn_sig() and add a few more details to StableMIR APIs #118927

merged 4 commits into from
Dec 15, 2023

Commits on Dec 14, 2023

  1. Erase late bound regions from instance fn_sig() 

    Late bound regions were still part of the signature.
    @celinval
    celinval committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    c3a2302 View commit details
    Browse the repository at this point in the history

  2. Add spread arg and missing CoroutineKind

    @celinval
    celinval committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    a66cac9 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. Address PR comments 

    - Remove `fn_sig()` from Instance.
- Change return value of `AssertMessage::description` to `Cow<>`.
- Add assert to instance `ty()`.
- Generalize uint / int type creation.
    @celinval
    celinval committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    c0f1207 View commit details
    Browse the repository at this point in the history

  2. Revert signature change for AssertMessage description

    @celinval
    celinval committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    6004386 View commit details
    Browse the repository at this point in the history