std::net::bind using -1 for openbsd which in turn sets it to somaxconn. #119026

devnexen · 2023-12-16T20:42:24Z

trusting platform's SOMAXCONN instead of hardcoding to 128 otherwise.

rustbot · 2023-12-16T20:42:32Z

(rustbot has picked a reviewer for you, use r? to override)

Mark-Simulacrum · 2023-12-16T23:45:04Z

I'm going to nominate for T-libs-api. This is changing the listen backlog size to the platform maximum (via -1 or SOMAXCONN) from 128 on most platforms. On Linux this has no effect; we previously changed from our current fallback default of 128 to -1 there in #97963. #55614 is tracking a general request to make this configurable, and has a comment that seems plausible in terms of not wanting to change the behavior here:

There are situations where you would rather have clients get an error than be stuck in a long queue because service is slow, so being able to specify a small maximum backlog per application is important.

(#55614 (comment))

It's not obviously the case that this is API surface area, but I think getting an opinion from the team would be useful here. Do we want to continue to land PRs which increase the backlog size to ~maximum allowed on the system? (Perhaps finished with this PR + changes in libc to refine SOMAXCONN).

devnexen · 2023-12-17T19:35:26Z

For the most part, SOMAXCONN is set to 128 anyway except linux/glibc, hurd, aix ; haiku being the only one lesser.

Amanieu · 2023-12-19T17:11:25Z

We discussed this in the libs-api meeting. We have no objections to this change: it seems like it won't cause much behavior difference, and somaxconn can generally by controlled system-wide anyways.

Mark-Simulacrum · 2023-12-19T17:15:54Z

@bors r+

bors · 2023-12-19T17:15:57Z

📌 Commit f5c3967 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

…lacrum std::net::bind using -1 for openbsd which in turn sets it to somaxconn. trusting platform's SOMAXCONN instead of hardcoding to 128 otherwise.

…mpiler-errors Rollup of 4 pull requests Successful merges: - rust-lang#119026 (std::net::bind using -1 for openbsd which in turn sets it to somaxconn.) - rust-lang#119094 (Add function ABI and type layout to StableMIR) - rust-lang#119102 (Add arm-none-eabi and armv7r-none-eabi platform-support documentation.) - rust-lang#119107 (subtype_predicate: remove unnecessary probe) Failed merges: - rust-lang#119141 (Add method to get instance instantiation arguments) r? `@ghost` `@rustbot` modify labels: rollup

compiler-errors · 2023-12-20T00:36:54Z

This failed in a rollup: #119144 (comment)
@bors r-

devnexen · 2023-12-22T11:19:58Z

@rustbot review

Mark-Simulacrum · 2023-12-22T13:39:36Z

@bors r+

bors · 2023-12-22T13:39:39Z

📌 Commit 743eb65 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

…lacrum std::net::bind using -1 for openbsd which in turn sets it to somaxconn. trusting platform's SOMAXCONN instead of hardcoding to 128 otherwise.

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#117449 (Avoid silencing relevant follow-up errors) - rust-lang#117556 (Disallow reference to `static mut` and adding `static_mut_ref` lint) - rust-lang#118521 (Enable address sanitizer for MSVC targets using INFERASANLIBS linker flag) - rust-lang#118704 (Promote `riscv32{im|imafc}` targets to tier 2) - rust-lang#119026 (std::net::bind using -1 for openbsd which in turn sets it to somaxconn.) - rust-lang#119151 (Hide foreign `#[doc(hidden)]` paths in import suggestions) - rust-lang#119195 (Make named_asm_labels lint not trigger on unicode and trigger on format args) r? `@ghost` `@rustbot` modify labels: rollup

…lacrum std::net::bind using -1 for openbsd which in turn sets it to somaxconn. trusting platform's SOMAXCONN instead of hardcoding to 128 otherwise.

…mpiler-errors Rollup of 10 pull requests Successful merges: - rust-lang#118521 (Enable address sanitizer for MSVC targets using INFERASANLIBS linker flag) - rust-lang#119026 (std::net::bind using -1 for openbsd which in turn sets it to somaxconn.) - rust-lang#119195 (Make named_asm_labels lint not trigger on unicode and trigger on format args) - rust-lang#119204 (macro_rules: Less hacky heuristic for using `tt` metavariable spans) - rust-lang#119362 (Make `derive(Trait)` suggestion more accurate) - rust-lang#119397 (Recover parentheses in range patterns) - rust-lang#119414 (bootstrap: Move -Clto= setting from Rustc::run to rustc_cargo) - rust-lang#119417 (Uplift some miscellaneous coroutine-specific machinery into `check_closure`) - rust-lang#119540 (Don't synthesize host effect args inside trait object types) - rust-lang#119555 (Add codegen test for RVO on MaybeUninit) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#118521 (Enable address sanitizer for MSVC targets using INFERASANLIBS linker flag) - rust-lang#119026 (std::net::bind using -1 for openbsd which in turn sets it to somaxconn.) - rust-lang#119195 (Make named_asm_labels lint not trigger on unicode and trigger on format args) - rust-lang#119204 (macro_rules: Less hacky heuristic for using `tt` metavariable spans) - rust-lang#119362 (Make `derive(Trait)` suggestion more accurate) - rust-lang#119397 (Recover parentheses in range patterns) - rust-lang#119417 (Uplift some miscellaneous coroutine-specific machinery into `check_closure`) - rust-lang#119539 (Fix typos) - rust-lang#119540 (Don't synthesize host effect args inside trait object types) - rust-lang#119555 (Add codegen test for RVO on MaybeUninit) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#119026 - devnexen:listener_upd, r=Mark-Simulacrum std::net::bind using -1 for openbsd which in turn sets it to somaxconn. trusting platform's SOMAXCONN instead of hardcoding to 128 otherwise.

Fix broken build for ESP IDF due to rust-lang#119026 `target_os = "espidf"` in `libc` lacks the `SOMAXCONN` constant, but that's probably irrelevant in this context, as `UnixListener` is not supported on ESP IDF - it being a single process "OS" only. The PR just re-uses the `128` constant so that the code builds. Trying to use the listener on ESP IDF will fail with `ENOSYS`, which is fine. *UPDATE* Might not fail with `ENOSYS` - need to test what error code would be returned, but that doesn`t change anything.

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#117744 (Add -Zuse-sync-unwind) - rust-lang#118649 (Make inductive cycles in coherence ambiguous always) - rust-lang#118979 (Use `assert_unsafe_precondition` for `char::from_u32_unchecked`) - rust-lang#119562 (Rename `pointer` field on `Pin`) - rust-lang#119619 (mir-opt and custom target fixes) - rust-lang#119632 (Fix broken build for ESP IDF due to rust-lang#119026) - rust-lang#119712 (Adding alignment to the cases to test for specific error messages.) - rust-lang#119734 (Miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup

Fix broken build for ESP IDF due to rust-lang#119026 `target_os = "espidf"` in `libc` lacks the `SOMAXCONN` constant, but that's probably irrelevant in this context, as `UnixListener` is not supported on ESP IDF - it being a single process "OS" only. The PR just re-uses the `128` constant so that the code builds. Trying to use the listener on ESP IDF will fail with `ENOSYS`, which is fine. *UPDATE* Might not fail with `ENOSYS` - need to test what error code would be returned, but that doesn`t change anything.

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#117744 (Add -Zuse-sync-unwind) - rust-lang#118649 (Make inductive cycles in coherence ambiguous always) - rust-lang#118979 (Use `assert_unsafe_precondition` for `char::from_u32_unchecked`) - rust-lang#119619 (mir-opt and custom target fixes) - rust-lang#119632 (Fix broken build for ESP IDF due to rust-lang#119026) - rust-lang#119712 (Adding alignment to the cases to test for specific error messages.) - rust-lang#119734 (Miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#119632 - ivmarkov:master, r=Nilstrieb,dtolnay Fix broken build for ESP IDF due to rust-lang#119026 `target_os = "espidf"` in `libc` lacks the `SOMAXCONN` constant, but that's probably irrelevant in this context, as `UnixListener` is not supported on ESP IDF - it being a single process "OS" only. The PR just re-uses the `128` constant so that the code builds. Trying to use the listener on ESP IDF will fail with `ENOSYS`, which is fine. *UPDATE* Might not fail with `ENOSYS` - need to test what error code would be returned, but that doesn`t change anything.

rustbot assigned Mark-Simulacrum Dec 16, 2023

rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 16, 2023

Mark-Simulacrum added the I-libs-api-nominated The issue / PR has been nominated for discussion during a libs-api team meeting. label Dec 16, 2023

Mark-Simulacrum added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 16, 2023

Amanieu removed the I-libs-api-nominated The issue / PR has been nominated for discussion during a libs-api team meeting. label Dec 19, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). labels Dec 19, 2023

compiler-errors mentioned this pull request Dec 19, 2023

Rollup of 5 pull requests #119142

Closed

compiler-errors mentioned this pull request Dec 19, 2023

Rollup of 4 pull requests #119144

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 20, 2023

devnexen force-pushed the listener_upd branch from f5c3967 to 743eb65 Compare December 20, 2023 07:18

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 22, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 31, 2023

matthiaskrgr mentioned this pull request Jan 3, 2024

Rollup of 7 pull requests #119558

Closed

compiler-errors mentioned this pull request Jan 4, 2024

Rollup of 10 pull requests #119565

Closed

matthiaskrgr mentioned this pull request Jan 4, 2024

Rollup of 10 pull requests #119569

Merged

bors merged commit d134a4f into rust-lang:master Jan 4, 2024
11 checks passed

rustbot added this to the 1.77.0 milestone Jan 4, 2024

ivmarkov added a commit to ivmarkov/rust that referenced this pull request Jan 5, 2024

Fix broken build for ESP IDF due to rust-lang#119026

fb7f524

ivmarkov added a commit to ivmarkov/rust that referenced this pull request Jan 5, 2024

Fix broken build for ESP IDF due to rust-lang#119026

a10b3cd

This was referenced Jan 6, 2024

Update actions/checkout action to v4 tokio-rs/mio#1752

Merged

Add async-io tests back to CI smol-rs/polling#172

Merged

pheki mentioned this pull request Jan 7, 2024

Change to pre-generated bindings, add feature for generating at compile-time vita-rust/vitasdk-sys#21

Merged

7 tasks

taiki-e mentioned this pull request Jan 7, 2024

Fix CI failures smol-rs/polling#173

Merged

matthiaskrgr mentioned this pull request Jan 8, 2024

Rollup of 8 pull requests #119755

Closed

matthiaskrgr mentioned this pull request Jan 9, 2024

Rollup of 7 pull requests #119760

Merged

pheki mentioned this pull request Jan 11, 2024

Fix broken vita std compilation by adding SOMAXCONN rust-lang/libc#3538

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

std::net::bind using -1 for openbsd which in turn sets it to somaxconn. #119026

std::net::bind using -1 for openbsd which in turn sets it to somaxconn. #119026

devnexen commented Dec 16, 2023

rustbot commented Dec 16, 2023

Mark-Simulacrum commented Dec 16, 2023

devnexen commented Dec 17, 2023

Amanieu commented Dec 19, 2023

Mark-Simulacrum commented Dec 19, 2023

bors commented Dec 19, 2023

compiler-errors commented Dec 20, 2023

devnexen commented Dec 22, 2023

Mark-Simulacrum commented Dec 22, 2023

bors commented Dec 22, 2023

std::net::bind using -1 for openbsd which in turn sets it to somaxconn. #119026

std::net::bind using -1 for openbsd which in turn sets it to somaxconn. #119026

Conversation

devnexen commented Dec 16, 2023

rustbot commented Dec 16, 2023

Mark-Simulacrum commented Dec 16, 2023

devnexen commented Dec 17, 2023

Amanieu commented Dec 19, 2023

Mark-Simulacrum commented Dec 19, 2023

bors commented Dec 19, 2023

compiler-errors commented Dec 20, 2023

devnexen commented Dec 22, 2023

Mark-Simulacrum commented Dec 22, 2023

bors commented Dec 22, 2023