Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Experiment] Play with match lowering #119031

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

[Experiment] Play with match lowering #119031

wants to merge 9 commits into from

Commits on Mar 2, 2024

  1. Add tests

    @Nadrieril
    Nadrieril committed Mar 2, 2024
    Copy the full SHA
    36e0c36 View commit details
    Browse the repository at this point in the history

  2. Tweak test_candidates_with_or

    @Nadrieril
    Nadrieril committed Mar 2, 2024
    Copy the full SHA
    1091425 View commit details
    Browse the repository at this point in the history

  3. Precompute the presence of bindings and ascriptions

    @Nadrieril
    Nadrieril committed Mar 2, 2024
    Copy the full SHA
    0ad2eff View commit details
    Browse the repository at this point in the history

  4. Improve or-pattern simplification 

    We can now tell ahead of time whether and or-pattern will be
simplifiable or not. We use this to clarify the possible code paths.
    @Nadrieril
    Nadrieril committed Mar 2, 2024
    Copy the full SHA
    22b8a7d View commit details
    Browse the repository at this point in the history

  5. Tiny missed simplification

    @Nadrieril
    Nadrieril committed Mar 2, 2024
    Copy the full SHA
    c2564d0 View commit details
    Browse the repository at this point in the history

  6. Use an enum instead of manually tracking indices for target_blocks

    @Nadrieril
    Nadrieril committed Mar 2, 2024
    Copy the full SHA
    0c9b5e2 View commit details
    Browse the repository at this point in the history

  7. Allocate candidate vectors as we sort them

    @Nadrieril
    Nadrieril committed Mar 2, 2024
    Copy the full SHA
    b3dc088 View commit details
    Browse the repository at this point in the history

  8. No need to collect test variants ahead of time

    @Nadrieril
    Nadrieril committed Mar 2, 2024
    Copy the full SHA
    3f01d65 View commit details
    Browse the repository at this point in the history

  9. Fix a subtle regression 

    Before, the SwitchInt cases were computed in two passes: if the first
pass accepted e.g. 0..=5 and then 1, the second pass would not accept
0..=5 anymore because 1 would be listed in the SwitchInt options.

Now there's a single pass, so if we sort 0..=5 we must take care to not
sort a subsequent 1.
    @Nadrieril
    Nadrieril committed Mar 2, 2024
    Copy the full SHA
    6433f90 View commit details
    Browse the repository at this point in the history