effects: fix a comment #119089
Merged
effects: fix a comment #119089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
fmease
commented
Dec 18, 2023
Comment on lines
390
to
396
| && !matches!( | ||
| arg, | ||
| GenericArg::Const(hir::ConstArg { | ||
| is_desugared_from_effects: true, | ||
| .. | ||
| }) | ||
| ) |
There was a problem hiding this comment.
Obviously I'm “treating symptoms” here but for the lowerer there's simply no way to know up front if the trait is non-const to avoid synthesizing host effect args.
fmease
changed the title
~const trait bounds involving a non-const trait~const trait bounds involving non-const traits
This comment was marked as resolved.
This comment was marked as resolved.
fmease
force-pushed
the
dont-ice-on-tilde-const-non-const-trait
branch
from
c1d2c3b
to
9746938
Compare
|
I think this is fixed via 324ca87 |
fmease
force-pushed
the
dont-ice-on-tilde-const-non-const-trait
branch
from
9746938
to
b2e304e
Compare
fmease
commented
Dec 19, 2023
| @@ -262,7 +262,7 @@ pub fn create_args_for_parent_generic_args<'tcx, 'a>( | |||
| // impl const PartialEq for () {} | |||
| // ``` | |||
| // | |||
| // Since this is a const impl, we need to insert `<false>` at the end of | |||
There was a problem hiding this comment.
It's not false but host in this case, therefore I've updated the comment.
Ah, yes, much better! Makes sense. I've pushed your suggested changes and made you the co-author. |
|
That commit is actually contained in #119072, but feel free to change this to just the comment change and r=me. |
fmease
force-pushed
the
dont-ice-on-tilde-const-non-const-trait
branch
from
b2e304e
to
ffdc6c7
Compare
fmease
changed the title
~const trait bounds involving non-const traits
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
bors
added
S-waiting-on-bors
This comment was marked as resolved.
This comment was marked as resolved.
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Dec 19, 2023
…-const-trait, r=fee1-dead effects: fix a comment r? fee1-dead or compiler
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 19, 2023
…mpiler-errors Rollup of 7 pull requests Successful merges: - rust-lang#118691 (Add check for possible CStr literals in pre-2021) - rust-lang#118973 (rustc_codegen_ssa: Don't drop `IncorrectCguReuseType` , make `rustc_expected_cgu_reuse` attr work) - rust-lang#119071 (-Znext-solver: adapt overflow rules to avoid breakage) - rust-lang#119089 (effects: fix a comment) - rust-lang#119096 (Yeet unnecessary param envs) - rust-lang#119118 (Fix arm64e-apple-ios target) - rust-lang#119134 (resolve: Feed visibilities for unresolved trait impl items) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 20, 2023
…mpiler-errors Rollup of 7 pull requests Successful merges: - rust-lang#118691 (Add check for possible CStr literals in pre-2021) - rust-lang#118973 (rustc_codegen_ssa: Don't drop `IncorrectCguReuseType` , make `rustc_expected_cgu_reuse` attr work) - rust-lang#119071 (-Znext-solver: adapt overflow rules to avoid breakage) - rust-lang#119089 (effects: fix a comment) - rust-lang#119096 (Yeet unnecessary param envs) - rust-lang#119118 (Fix arm64e-apple-ios target) - rust-lang#119134 (resolve: Feed visibilities for unresolved trait impl items) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 20, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#118691 (Add check for possible CStr literals in pre-2021) - rust-lang#118973 (rustc_codegen_ssa: Don't drop `IncorrectCguReuseType` , make `rustc_expected_cgu_reuse` attr work) - rust-lang#119071 (-Znext-solver: adapt overflow rules to avoid breakage) - rust-lang#119089 (effects: fix a comment) - rust-lang#119094 (Add function ABI and type layout to StableMIR) - rust-lang#119102 (Add arm-none-eabi and armv7r-none-eabi platform-support documentation.) - rust-lang#119107 (subtype_predicate: remove unnecessary probe) Failed merges: - rust-lang#119135 (Fix crash due to `CrateItem::kind()` not handling constructors) - rust-lang#119141 (Add method to get instance instantiation arguments) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 20, 2023
Rollup merge of rust-lang#119089 - fmease:dont-ice-on-tilde-const-non-const-trait, r=fee1-dead effects: fix a comment r? fee1-dead or compiler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? fee1-dead or compiler