Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use diagnostic namespace in stdlib #119216

Merged
merged 4 commits into from
Jan 6, 2024
Merged

Use diagnostic namespace in stdlib #119216

merged 4 commits into from
Jan 6, 2024

Commits on Jan 5, 2024

  1. Allow emitting diagnostics from the #[diagnostic] namespace without a 

    nightly feature

(Using this attribute still requires a nightly feature, this just
enables that this feature does not need to be enabled on the child crate
as well)
    @weiznich
    weiznich committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    ddfcf86 View commit details
    Browse the repository at this point in the history

  2. Replace some usage of #[rustc_on_unimplemented] with 

    `#[diagnostic::on_unimplemented]`

This commit replaces those `#[rustc_on_unimplemented]` attributes with
their equivalent `#[diagnostic::on_unimplemented]` where this is
supported (So no filter or any extended option)
    @weiznich
    weiznich committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    2c3aeea View commit details
    Browse the repository at this point in the history

  3. Add a test that emitting diagnostics does not require the crate to use 

    the corresponding feature.
    @weiznich
    weiznich committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    91e1af3 View commit details
    Browse the repository at this point in the history

  4. Ignore a rustdoc test

    @fmease
    fmease committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    54967d7 View commit details
    Browse the repository at this point in the history