Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IntoAsyncIterator #119222

Merged
merged 3 commits into from Dec 23, 2023
Merged

Add IntoAsyncIterator #119222

merged 3 commits into from Dec 23, 2023

Conversation

eholk
Copy link
Contributor

@eholk eholk commented Dec 22, 2023

This introduces the IntoAsyncIterator trait and uses it in the desugaring of the unstable for await loop syntax. This is mostly added for symmetry with Iterator and IntoIterator.

r? @compiler-errors

cc @rust-lang/libs-api, @rust-lang/wg-async

@eholk eholk added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Dec 22, 2023
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 22, 2023
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me when it gets T-libs-api approval (or we hear from them that this doesn't require their approval)

@compiler-errors compiler-errors added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). I-libs-api-nominated The issue / PR has been nominated for discussion during a libs-api team meeting. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 22, 2023
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@dtolnay
Copy link
Member

dtolnay commented Dec 22, 2023

@bors r=compiler-errors,dtolnay

@bors
Copy link
Contributor

bors commented Dec 22, 2023

📌 Commit aaa3e76 has been approved by compiler-errors,dtolnay

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). labels Dec 22, 2023
@dtolnay dtolnay removed the I-libs-api-nominated The issue / PR has been nominated for discussion during a libs-api team meeting. label Dec 22, 2023
@eholk
Copy link
Contributor Author

eholk commented Dec 22, 2023

Thanks for the quick reviews!

@compiler-errors
Copy link
Member

@bors rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 23, 2023
…mpiler-errors

Rollup of 6 pull requests

Successful merges:

 - rust-lang#119012 (Extract `layout_of_{struct,enum}` fn)
 - rust-lang#119077 (Separate MIR lints from validation)
 - rust-lang#119171 (Cleanup error handlers: round 4)
 - rust-lang#119198 (Split coroutine desugaring kind from source)
 - rust-lang#119222 (Add `IntoAsyncIterator`)
 - rust-lang#119230 (Exhaustiveness: clean up after librarification)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit eef023c into rust-lang:master Dec 23, 2023
11 checks passed
@rustbot rustbot added this to the 1.77.0 milestone Dec 23, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 23, 2023
Rollup merge of rust-lang#119222 - eholk:into-async-iterator, r=compiler-errors,dtolnay

Add `IntoAsyncIterator`

This introduces the `IntoAsyncIterator` trait and uses it in the desugaring of the unstable `for await` loop syntax. This is mostly added for symmetry with `Iterator` and `IntoIterator`.

r? `@compiler-errors`

cc `@rust-lang/libs-api,` `@rust-lang/wg-async`
@dtolnay dtolnay self-assigned this Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants