Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #119263

Merged
merged 14 commits into from Dec 23, 2023
Merged

Rollup of 5 pull requests #119263

merged 14 commits into from Dec 23, 2023

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Toasterson and others added 14 commits December 4, 2023 12:14
Signed-off-by: Till Wegmueller <toasterson@gmail.com>
Signed-off-by: Till Wegmueller <toasterson@gmail.com>
…freebsd

Signed-off-by: Till Wegmueller <toasterson@gmail.com>
this is used at `rustc_middle::error`, is duplicated here somehow
… r=jackh726

Add illumos aarch64 target for rust.

This adds the newly being developed illumos aarch64 target to the rust compiler.

`@rmustacc` `@citrus-it` `@richlowe` As promissed before my hiatus :)
…e-json, r=aDotInTheVoid

[rustdoc] Add `is_object_safe` information for traits in JSON output

As asked by `@obi1kenobi` [here](rust-lang#113241 (comment)).

cc `@aDotInTheVoid`
r? `@notriddle`
…piler-errors

Remove an unused diagnostic struct

this is used at `rustc_middle::error`, is duplicated here somehow
@rustbot rustbot added A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Dec 23, 2023
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Contributor

bors commented Dec 23, 2023

📌 Commit aa2e5fa has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 23, 2023
@bors
Copy link
Contributor

bors commented Dec 23, 2023

⌛ Testing commit aa2e5fa with merge 2d7be73...

@bors
Copy link
Contributor

bors commented Dec 23, 2023

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 2d7be73 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 23, 2023
@bors bors merged commit 2d7be73 into rust-lang:master Dec 23, 2023
12 checks passed
@rustbot rustbot added this to the 1.77.0 milestone Dec 23, 2023
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#112936 Add illumos aarch64 target for rust. 114ce8848db717064eba32fb99060d4569e0ed18 (link)
#119153 stabilize file_create_new 9b21d24be538be1fe9367637ca8a120b624f314d (link)
#119246 [rustdoc] Add is_object_safe information for traits in JS… e9b5a8232bc64a752ea4f1177deba137b3f8fae1 (link)
#119254 Remove an unused diagnostic struct 6387a9fd7590925bd35a706c2387362c7290d56c (link)
#119255 add a test for ICE #112822 f6904d90cd77dbb19378185856e030e1cd813aea (link)

previous master: 520e30be83

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (2d7be73): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.2% [2.2%, 2.2%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 670.853s -> 670.739s (-0.02%)
Artifact size: 312.76 MiB -> 312.78 MiB (0.01%)

@matthiaskrgr matthiaskrgr deleted the rollup-zxok9fb branch March 16, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-json Area: Rustdoc JSON backend merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants