show linker output even if the linker succeeds #119286

jyn514 · 2023-12-24T23:44:23Z

show stderr by default
show stdout if --verbose is passed
remove both from RUSTC_LOG
hide the linker cli args unless --verbose is passed

fixes #83436. fixes #38206. fixes #109979. helps with #46998. cc https://rust-lang.zulipchat.com/#narrow/stream/233931-t-compiler.2Fmajor-changes/topic/uplift.20some.20-Zverbose.20calls.20and.20rename.20to.E2.80.A6.20compiler-team.23706/near/408986134

this is based on #119129 for convenience so i didn't have to duplicate the changes around saving --verbose in cb6d033#diff-7a49efa20548d6806dbe1c66dd4dc445fda18fcbbf1709520cadecc4841aae12

r? @bjorn3

rustbot · 2023-12-24T23:44:33Z

rustc_macros::diagnostics was changed

cc @davidtwco, @compiler-errors, @TaKO8Ki

jyn514 · 2023-12-24T23:53:38Z

hmm actually this is a slight expansion of scope but @bjorn3 how would you feel about not printing the giant list of linker arguments unless someone passes --verbose (#109979)

jyn514 · 2023-12-25T01:10:13Z

also i know we settled on not showing stdout by default but it's useful for debugging search paths - maybe we should show it after all? it seems silly to have to pass both -Wl,--verbose and --verbose. #46998 (comment)

compiler/rustc_codegen_ssa/src/back/link.rs

bjorn3 · 2023-12-25T11:13:12Z

compiler/rustc_interface/src/tests.rs

@@ -714,7 +714,7 @@ fn test_unstable_options_tracking_hash() {
    untracked!(unpretty, Some("expanded".to_string()));
    untracked!(unstable_options, true);
    untracked!(validate_mir, true);
-    untracked!(verbose, true);
+    untracked!(verbose_internals, true);


Don't diagnostics influenced by this flag end up in the incr cache? It should actually be tracked I think.

hmm, do we cache diagnostic output? even on errors? that seems very strange to me.

i don't mind changing it to tracked, i'm just confused why it's necessary.

On errors we don't finalize the incr comp cache, but non-fatal diagnostics are cached afaik. Otherwise we would have to replay the query in question, which we may not be able to do if the query key is not reconstructible from the dep node fingerprint.

compiler/rustc_session/src/options.rs

compiler/rustc_codegen_ssa/src/back/link.rs

bors · 2024-01-06T18:43:05Z

☔ The latest upstream changes (presumably #119662) made this pull request unmergeable. Please resolve the merge conflicts.

jyn514 · 2024-01-20T01:03:00Z

hmm. that test has the following comment:

rust/tests/incremental/commandline-args.rs

Lines 13 to 20 in e9a009f

    
           // Between revisions 1 and 2, we are changing the debuginfo-level, which should 
        
           // invalidate the cache. Between revisions 2 and 3, we are adding `--verbose` 
        
           // which should have no effect on the cache. Between revisions, we are adding 
        
           // `--remap-path-prefix` which should invalidate the cache: 
        
           //[rpass1] compile-flags: -C debuginfo=0 
        
           //[rpass2] compile-flags: -C debuginfo=2 
        
           //[rpass3] compile-flags: -C debuginfo=2 --verbose 
        
           //[rpass4] compile-flags: -C debuginfo=2 --verbose --remap-path-prefix=/home/bors/rust=src

i suppose those lines are all invalid now, it should be testing that the CGU is not reused? i'm not sure why it's testing --verbose specifically, maybe it's enough to test any untracked CLI arg. i'll change it to --diagnostic-width.

i'm realizing your comments are all about #119129. i feel slightly uncomfortable making unrelated changes in this PR ... how do you feel about splitting them into a separate PR so i can assign michaelwoerister?

bjorn3 · 2024-01-20T09:10:30Z

how do you feel about splitting them into a separate PR so i can assign michaelwoerister?

Sure

bjorn3 · 2024-01-20T20:42:54Z

hide the linker cli args unless --verbose is passed

I prefer not doing this. It is helpful whenever a linkage issue is opened to not have to ask to rerun with RUSTFLAGS="--verbose". If you revert this change r=me. If you still want to keep it, let me thing about it for a bit.

bors · 2024-01-29T03:13:57Z

☔ The latest upstream changes (presumably #119972) made this pull request unmergeable. Please resolve the merge conflicts.

the linker arguments can be *very* long, especially for crates with many dependencies. often they are not useful. omit them unless the user specifically requests them.

this avoids warnings from macOS ld

bjorn3 · 2024-01-30T09:55:25Z

@bors r+

bors · 2024-01-30T09:55:27Z

📌 Commit fde9966 has been approved by bjorn3

It is now in the queue for this repository.

bjorn3 · 2024-01-30T09:55:50Z

@bors rollup=iffy

show linker output even if the linker succeeds - show stderr by default - show stdout if `--verbose` is passed - remove both from RUSTC_LOG - hide the linker cli args unless `--verbose` is passed fixes rust-lang#83436. fixes rust-lang#38206. fixes rust-lang#109979. helps with rust-lang#46998. cc https://rust-lang.zulipchat.com/#narrow/stream/233931-t-compiler.2Fmajor-changes/topic/uplift.20some.20-Zverbose.20calls.20and.20rename.20to.E2.80.A6.20compiler-team.23706/near/408986134 this is based on rust-lang#119129 for convenience so i didn't have to duplicate the changes around saving `--verbose` in rust-lang@cb6d033#diff-7a49efa20548d6806dbe1c66dd4dc445fda18fcbbf1709520cadecc4841aae12 r? `@bjorn3`

bors · 2024-01-30T22:22:44Z

⌛ Testing commit fde9966 with merge 6f77ebe...

bors · 2024-01-30T23:16:36Z

💔 Test failed - checks-actions

jyn514 · 2024-02-01T05:02:23Z

lol what on earth
AFAICT there are two types of warnings:
1.

warning: linker stderr: Warning: .drectve `-exclude-symbols:_ZN17compiler_builtins3mem6memcpy17h33c7778f71cce9faE ' unrecognized
           Warning: .drectve `-exclude-symbols:_ZN17compiler_builtins3mem7memmove17ha30886041cd704b7E ' unrecognized

2024-01-30T23:15:45.4590600Z ---- [ui] tests\ui\array-slice-vec\nested-vec-1.rs stdout ----
2024-01-30T23:15:45.4591032Z normalized stderr:
2024-01-30T23:15:45.4591439Z warning: linker stderr: Warning: corrupt .drectve at end of def file

the first one looks like #112368, probably? that's related to an old linker version, i'm not sure what version we're using in CI.
the second one is what's actually causing tests to fail and i don't have ideas for fixing it. maybe @mati865 knows.

anyway i'm probably not going to put much more time into this pr

mati865 · 2024-02-01T07:41:05Z

the first one looks like #112368, probably? that's related to an old linker version, i'm not sure what version we're using in CI.

Because getting a newer one is not a trivial task ;)
#119229

the second one is what's actually causing tests to fail and i don't have ideas for fixing it

Oh, that's strange. In the past, Rust used .def files only to let the linker know which symbols to export. Maybe something has changed (likely accidentally), but we'd need to dump that file and see its contents.

nikic · 2024-02-13T09:54:42Z

@bors r-

Probably someone clicked the synchronize button.

jyn514 · 2024-02-17T16:17:32Z

i am not planning to work on this more, someone else can pick it up if they care

rustbot assigned bjorn3 Dec 24, 2023

jyn514 force-pushed the linker-output branch 2 times, most recently from 060a457 to a34d7ae Compare December 24, 2023 23:47

This comment has been minimized.

Sign in to view

jyn514 force-pushed the linker-output branch 2 times, most recently from 64cb47a to ab6fb2b Compare December 25, 2023 00:55

jyn514 mentioned this pull request Dec 25, 2023

Unreadable error messages on linking failure #46998

Open

This comment has been minimized.

Sign in to view

jyn514 force-pushed the linker-output branch from ab6fb2b to ba4425d Compare December 25, 2023 01:40

Nilstrieb reviewed Dec 25, 2023

View reviewed changes

compiler/rustc_codegen_ssa/src/back/link.rs Outdated Show resolved Hide resolved

bjorn3 reviewed Dec 25, 2023

View reviewed changes

compiler/rustc_session/src/options.rs Outdated Show resolved Hide resolved

bjorn3 reviewed Dec 25, 2023

View reviewed changes

compiler/rustc_codegen_ssa/src/back/link.rs Show resolved Hide resolved

jyn514 force-pushed the linker-output branch from ba4425d to 43edbe0 Compare December 25, 2023 11:42

jyn514 force-pushed the linker-output branch from 43edbe0 to cbf71f7 Compare January 19, 2024 23:33

This comment has been minimized.

Sign in to view

jyn514 force-pushed the linker-output branch from cbf71f7 to 748af4f Compare January 20, 2024 01:05

jyn514 mentioned this pull request Jan 20, 2024

Track verbose and verbose_internals #120159

Merged

jyn514 force-pushed the linker-output branch from 748af4f to aac51d5 Compare January 20, 2024 13:04

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 28, 2024

jyn514 reopened this Jan 28, 2024

jyn514 and others added 5 commits January 29, 2024 21:47

remove dead code in CGREP script

1c546d7

give a better error for tuple structs in derive(Diagnostic)

cd95e17

show linker warnings even if it returns 0

d4e7a8c

don't show the full linker args unless --verbose is passed

36d1e94

the linker arguments can be *very* long, especially for crates with many dependencies. often they are not useful. omit them unless the user specifically requests them.

don't pass -L .../auxiliary unless it exists

fde9966

this avoids warnings from macOS ld

jyn514 force-pushed the linker-output branch from cbfe501 to fde9966 Compare January 30, 2024 02:54

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 30, 2024

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 30, 2024

bjorn3 mentioned this pull request Feb 2, 2024

wasm: Store rlib metadata in wasm object files #120588

Merged

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 13, 2024

jyn514 closed this Feb 17, 2024

Nilstrieb added S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

show linker output even if the linker succeeds #119286

show linker output even if the linker succeeds #119286

jyn514 commented Dec 24, 2023 •

edited

rustbot commented Dec 24, 2023

jyn514 commented Dec 24, 2023

This comment has been minimized.

jyn514 commented Dec 25, 2023

This comment has been minimized.

bjorn3 Dec 25, 2023

jyn514 Dec 25, 2023

bjorn3 Dec 25, 2023

bors commented Jan 6, 2024

This comment has been minimized.

jyn514 commented Jan 20, 2024

bjorn3 commented Jan 20, 2024

bjorn3 commented Jan 20, 2024

bors commented Jan 29, 2024

bjorn3 commented Jan 30, 2024

bors commented Jan 30, 2024

bjorn3 commented Jan 30, 2024

bors commented Jan 30, 2024

bors commented Jan 30, 2024

jyn514 commented Feb 1, 2024 •

edited

mati865 commented Feb 1, 2024

nikic commented Feb 13, 2024

jyn514 commented Feb 17, 2024

show linker output even if the linker succeeds #119286

show linker output even if the linker succeeds #119286

Conversation

jyn514 commented Dec 24, 2023 • edited

rustbot commented Dec 24, 2023

jyn514 commented Dec 24, 2023

This comment has been minimized.

jyn514 commented Dec 25, 2023

This comment has been minimized.

bjorn3 Dec 25, 2023

Choose a reason for hiding this comment

jyn514 Dec 25, 2023

Choose a reason for hiding this comment

bjorn3 Dec 25, 2023

Choose a reason for hiding this comment

bors commented Jan 6, 2024

This comment has been minimized.

jyn514 commented Jan 20, 2024

bjorn3 commented Jan 20, 2024

bjorn3 commented Jan 20, 2024

bors commented Jan 29, 2024

bjorn3 commented Jan 30, 2024

bors commented Jan 30, 2024

bjorn3 commented Jan 30, 2024

bors commented Jan 30, 2024

bors commented Jan 30, 2024

jyn514 commented Feb 1, 2024 • edited

mati865 commented Feb 1, 2024

nikic commented Feb 13, 2024

jyn514 commented Feb 17, 2024

jyn514 commented Dec 24, 2023 •

edited

jyn514 commented Feb 1, 2024 •

edited