macro_rules: Remove NtIdent nonterminal token

[petrochenkov]

It only exists for keeping the second span (the metavariable span), but after #119673 such spans can be kept using a more general mechanism.

[rustbot]

r? @compiler-errors

(rustbot has picked a reviewer for you, use r? to override)

[compiler-errors]

unassigning myself for now since you said it's a WIP, feel free to reassign when there's stuff to review

[rustbot]

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

[rustbot]

The Miri subtree was changed

cc @rust-lang/miri

[bors]

⌛ Trying commit 8bbdaaa with merge b2ad6b1...

[bors]

☀️ Try build successful - checks-actions
Build commit: b2ad6b1 (b2ad6b111bba75f9b737f6a251345556ddbe3ee2)

[petrochenkov]

This PR fixes some cross-crate hygiene issues as visible from tests/ui/editions/edition-keywords-* tests, so it's better to run crater.
@craterbot check

[craterbot]

👌 Experiment pr-119412 created and queued.
🤖 Automatically detected try build b2ad6b1
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[rust-timer]

Finished benchmarking commit (b2ad6b1): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	19.8%	[9.2%, 32.5%]	3
Regressions ❌ (secondary)	0.4%	[0.4%, 0.4%]	1
Improvements ✅ (primary)	-0.5%	[-1.6%, -0.2%]	37
Improvements ✅ (secondary)	-0.3%	[-0.8%, -0.1%]	13
All ❌✅ (primary)	1.0%	[-1.6%, 32.5%]	40

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	6.8%	[0.7%, 11.3%]	4
Regressions ❌ (secondary)	3.4%	[3.4%, 3.4%]	1
Improvements ✅ (primary)	-1.9%	[-2.4%, -1.3%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.9%	[-2.4%, 11.3%]	6

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	24.6%	[8.9%, 38.4%]	3
Regressions ❌ (secondary)	1.6%	[1.6%, 1.6%]	1
Improvements ✅ (primary)	-2.5%	[-3.4%, -1.4%]	6
Improvements ✅ (secondary)	-2.7%	[-2.7%, -2.7%]	1
All ❌✅ (primary)	6.5%	[-3.4%, 38.4%]	9

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.2%, 0.2%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.3%	[-0.4%, -0.0%]	11
Improvements ✅ (secondary)	-0.0%	[-0.0%, -0.0%]	5
All ❌✅ (primary)	-0.2%	[-0.4%, 0.2%]	13

Bootstrap: 640.916s -> 640.264s (-0.10%)
Artifact size: 308.79 MiB -> 308.75 MiB (-0.01%)

[petrochenkov]

An improvement for everything, except for the 32.47% (?!!) regression for syn and a minor regression for the tt-muncher stress test.

I'll investigate the syn regression, but probably after returning from vacation.
cc @dtolnay in the meantime.

[craterbot]

🚧 Experiment pr-119412 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🎉 Experiment pr-119412 is completed!
📊 216 regressed and 1 fixed (418672 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[bors]

☔ The latest upstream changes (presumably #121268) made this pull request unmergeable. Please resolve the merge conflicts.