Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reland optimized-compiler-builtins config #119556

Merged
merged 2 commits into from
Jan 7, 2024

Commits on Jan 3, 2024

  1. Configuration menu
    Copy the full SHA
    1490bba View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2024

  1. add a new optimized_compiler_builtins option

    in particular, this makes the `c` feature for compiler-builtins an explicit opt-in, rather than silently detected by whether `llvm-project` is checked out on disk.
    exposing this is necessary because the `cc` crate doesn't support cross-compiling to MSVC, and we want people to be able to run `x check --target foo` regardless of whether they have a c toolchain available.
    
    this also uses the new option in CI, where we *do* want to optimize compiler_builtins.
    
    the new option is off by default for the `dev` channel and on otherwise.
    jyn514 authored and onur-ozkan committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    6a409dd View commit details
    Browse the repository at this point in the history