Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fast path to inline ADT constructors. #119706

Closed
wants to merge 1 commit into from

Conversation

cjgillot
Copy link
Contributor

@cjgillot cjgillot commented Jan 7, 2024

r? @ghost

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 7, 2024
@cjgillot
Copy link
Contributor Author

cjgillot commented Jan 7, 2024

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 7, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 7, 2024
Add fast path to inline ADT constructors.

r? `@ghost`
@bors
Copy link
Contributor

bors commented Jan 7, 2024

⌛ Trying commit 8f68d81 with merge 8339f4d...

@rust-log-analyzer

This comment has been minimized.

@cjgillot
Copy link
Contributor Author

cjgillot commented Jan 7, 2024

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 7, 2024
Add fast path to inline ADT constructors.

r? `@ghost`
@bors
Copy link
Contributor

bors commented Jan 7, 2024

⌛ Trying commit 667fa3c with merge 6cbf1c5...

@cjgillot cjgillot added the A-mir-opt Area: MIR optimizations label Jan 7, 2024
@bors
Copy link
Contributor

bors commented Jan 7, 2024

☀️ Try build successful - checks-actions
Build commit: 6cbf1c5 (6cbf1c527582fcac4952de6debc2de146b4bfec9)

1 similar comment
@bors
Copy link
Contributor

bors commented Jan 7, 2024

☀️ Try build successful - checks-actions
Build commit: 6cbf1c5 (6cbf1c527582fcac4952de6debc2de146b4bfec9)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (6cbf1c5): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.3% [2.3%, 2.3%] 1
Improvements ✅
(primary)
-2.8% [-2.8%, -2.8%] 1
Improvements ✅
(secondary)
-1.4% [-1.6%, -1.2%] 2
All ❌✅ (primary) -2.8% [-2.8%, -2.8%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 665.982s -> 666.714s (0.11%)
Artifact size: 308.42 MiB -> 308.54 MiB (0.04%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 8, 2024
@cjgillot cjgillot closed this Apr 7, 2024
@cjgillot cjgillot deleted the inline-ctor branch April 7, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-mir-opt Area: MIR optimizations S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants