Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Waker::will_wake: Compare vtable address instead of its content #119863

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Waker::will_wake: Compare vtable address instead of its content #119863

merged 1 commit into from
Feb 15, 2024

Commits on Jan 11, 2024

  1. Waker::will_wake: Compare vtable address instead of its content 

    Optimize will_wake implementation by comparing vtable address instead
of its content.

The existing best practice to avoid false negatives from will_wake is
to define a waker vtable as a static item. That approach continues to
works with the new implementation.

While this potentially changes the observable behaviour, the function is
documented to work on a best-effort basis. The PartialEq impl for
RawWaker remains as it was.
    @tmiasko
    tmiasko committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    9d84589 View commit details
    Browse the repository at this point in the history