Skip to content

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented Jan 13, 2024

We can encounter BindingObligations from GATs that we should handle in report_no_match_method_error. I assume we can encounter them from methods, though I didn't really feel like wasting my time creating a repro.

Fixes #119942

@rustbot
Copy link
Collaborator

rustbot commented Jan 13, 2024

r? @b-naber

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 13, 2024
Copy link
Member

@fmease fmease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r? fmease

@rustbot rustbot assigned fmease and unassigned b-naber Jan 14, 2024
@fmease
Copy link
Member

fmease commented Jan 14, 2024

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 14, 2024

📌 Commit 0b45ff5 has been approved by fmease

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 14, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 14, 2024
…llaumeGomez

Rollup of 3 pull requests

Successful merges:

 - rust-lang#119944 (Don't ICE when noting GAT bounds in `report_no_match_method_error`)
 - rust-lang#119949 (Add note on SpecOptionPartialEq to `newtype_index`)
 - rust-lang#119961 ([meta] Remove Zulip rustdoc nomination alert)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5ad0ed5 into rust-lang:master Jan 14, 2024
@rustbot rustbot added this to the 1.77.0 milestone Jan 14, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 14, 2024
Rollup merge of rust-lang#119944 - compiler-errors:no-match-due-to-gat-bounds, r=fmease

Don't ICE when noting GAT bounds in `report_no_match_method_error`

We can encounter `BindingObligation`s from GATs that we should handle in `report_no_match_method_error`. I assume we can encounter them from methods, though I didn't really feel like wasting my time creating a repro.

Fixes rust-lang#119942
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ice: internal error: entered unreachable code: encountered TraitItem(TraitItem ..
5 participants