Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using derivative in rustc_pattern_analysis #120420

Merged
merged 1 commit into from Jan 29, 2024
Merged

Stop using derivative in rustc_pattern_analysis #120420

merged 1 commit into from Jan 29, 2024

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented Jan 27, 2024 •
edited

@rustbot
Copy link
Collaborator

rustbot commented Jan 27, 2024

r? @fmease

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 27, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jan 27, 2024

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

Some changes might have occurred in exhaustiveness checking

cc @Nadrieril

@rustbot rustbot assigned Nadrieril and unassigned fmease Jan 27, 2024
@lnicola lnicola force-pushed the rm-pattern-analysis-derivative branch from 02919f1 to f5c7895 Compare January 27, 2024 12:21
@Nilstrieb
Copy link
Member

Nilstrieb commented Jan 27, 2024 •
edited

not particularly happy with the diff 😞
but I can see the motivation
(Oh, didn't see the assignment to Nadrieril, but I assume it's fine for me to approve it :))
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 27, 2024

📌 Commit f5c7895 has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 27, 2024
@lnicola
Copy link
Member Author

lnicola commented Jan 27, 2024 •
edited

not particularly happy with the diff 😞

I'll change it back after #26925 😀.

Oh, didn't see the assignment to Nadrieril, but I assume it's fine for me to approve it :)

Yeah, sorry, I added it in later (not sure if they have bors rights).

@Nadrieril
Copy link
Member

Nadrieril commented Jan 27, 2024 •
edited

Oh, thank you for doing that! I had started doing that but I didn't enjoy the manual Debug and PartualEq impls. I guess they're manageable

@lnicola
Copy link
Member Author

lnicola commented Jan 27, 2024

We could even get rid of it (there's only one other crate using derivative), but I'm not sure how popular that would be.

@Nadrieril
Copy link
Member

I don't think it would be too hard to maintain it ourselves if we do want to keep it

@Nilstrieb
Copy link
Member

I think the cost and benefit are both pretty small. It was added recently to replace the manual handwritten impls which were a bit annoying. I don't think it matters that much to get rid of syn 1, the compiler depends on so many crates and I doubt syn 1 or derivative are a bottleneck.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 27, 2024
@matthiaskrgr
Rollup merge of rust-lang#120420 - lnicola:rm-pattern-analysis-deriva…
e4409db 
…tive, r=Nilstrieb

Stop using derivative in rustc_pattern_analysis

CC rust-lang#109302, rust-lang/rust-analyzer#16420 (comment)

r? `@Nadrieril`
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 27, 2024
Closed
@Nadrieril
Copy link
Member

Aren't you the one who opened #109302? 😄

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 27, 2024
@bors
Auto merge of rust-lang#120429 - matthiaskrgr:rollup-0kxx256, r=matth…
56ee58e 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#120172 (bootstrap: add more unit tests)
 - rust-lang#120266 (Improve documentation for [A]Rc::into_inner)
 - rust-lang#120358 (Bump Fuchsia, build tests, and use 8 core bots)
 - rust-lang#120373 (Adjust Behaviour of `read_dir` and `ReadDir` in Windows Implementation: Check Whether Path to Search In Exists)
 - rust-lang#120376 (Update codegen test for LLVM 18)
 - rust-lang#120420 (Stop using derivative in rustc_pattern_analysis)
 - rust-lang#120425 (Remove unnecessary unit returns in query declarations)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 27, 2024
@matthiaskrgr
Rollup merge of rust-lang#120420 - lnicola:rm-pattern-analysis-deriva…
561d6f0 
…tive, r=Nilstrieb

Stop using derivative in rustc_pattern_analysis

CC rust-lang#109302, rust-lang/rust-analyzer#16420 (comment)

r? `@Nadrieril`
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 27, 2024
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 27, 2024
@matthiaskrgr
Rollup merge of rust-lang#120420 - lnicola:rm-pattern-analysis-deriva…
881e51a 
…tive, r=Nilstrieb

Stop using derivative in rustc_pattern_analysis

CC rust-lang#109302, rust-lang/rust-analyzer#16420 (comment)

r? ``@Nadrieril``
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 27, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 28, 2024
@bors
Auto merge of rust-lang#120432 - matthiaskrgr:rollup-ho8zrrk, r=matth…
02dde5d 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#116677 (References refer to allocated objects)
 - rust-lang#120232 (Add support for custom JSON targets when using build-std.)
 - rust-lang#120266 (Improve documentation for [A]Rc::into_inner)
 - rust-lang#120358 (Bump Fuchsia, build tests, and use 8 core bots)
 - rust-lang#120373 (Adjust Behaviour of `read_dir` and `ReadDir` in Windows Implementation: Check Whether Path to Search In Exists)
 - rust-lang#120402 (Make the coroutine def id of an async closure the child of the closure def id)
 - rust-lang#120420 (Stop using derivative in rustc_pattern_analysis)
 - rust-lang#120425 (Remove unnecessary unit returns in query declarations)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 28, 2024
@matthiaskrgr
Rollup merge of rust-lang#120420 - lnicola:rm-pattern-analysis-deriva…
9b06380 
…tive, r=Nilstrieb

Stop using derivative in rustc_pattern_analysis

CC rust-lang#109302, rust-lang/rust-analyzer#16420 (comment)

r? ```@Nadrieril```
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 28, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 28, 2024
@bors
Auto merge of rust-lang#120437 - matthiaskrgr:rollup-h1uai71, r=matth…
a162071 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#120358 (Bump Fuchsia, build tests, and use 8 core bots)
 - rust-lang#120402 (Make the coroutine def id of an async closure the child of the closure def id)
 - rust-lang#120420 (Stop using derivative in rustc_pattern_analysis)
 - rust-lang#120425 (Remove unnecessary unit returns in query declarations)
 - rust-lang#120428 (hir: Two preparatory changes for rust-lang#120206)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 28, 2024
@bors
Auto merge of rust-lang#120437 - matthiaskrgr:rollup-h1uai71, r=matth…
769e1fe 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#120358 (Bump Fuchsia, build tests, and use 8 core bots)
 - rust-lang#120402 (Make the coroutine def id of an async closure the child of the closure def id)
 - rust-lang#120420 (Stop using derivative in rustc_pattern_analysis)
 - rust-lang#120425 (Remove unnecessary unit returns in query declarations)
 - rust-lang#120428 (hir: Two preparatory changes for rust-lang#120206)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 28, 2024
@bors
Auto merge of rust-lang#120437 - matthiaskrgr:rollup-h1uai71, r=matth…
8d9b7de 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#120358 (Bump Fuchsia, build tests, and use 8 core bots)
 - rust-lang#120402 (Make the coroutine def id of an async closure the child of the closure def id)
 - rust-lang#120420 (Stop using derivative in rustc_pattern_analysis)
 - rust-lang#120425 (Remove unnecessary unit returns in query declarations)
 - rust-lang#120428 (hir: Two preparatory changes for rust-lang#120206)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 29, 2024
@bors
Auto merge of rust-lang#120437 - matthiaskrgr:rollup-h1uai71, r=matth…
abbba77 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#120358 (Bump Fuchsia, build tests, and use 8 core bots)
 - rust-lang#120402 (Make the coroutine def id of an async closure the child of the closure def id)
 - rust-lang#120420 (Stop using derivative in rustc_pattern_analysis)
 - rust-lang#120425 (Remove unnecessary unit returns in query declarations)
 - rust-lang#120428 (hir: Two preparatory changes for rust-lang#120206)

r? `@ghost`
`@rustbot` modify labels: rollup
@Dylan-DPC Dylan-DPC mentioned this pull request Jan 29, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 29, 2024
@bors
Auto merge of rust-lang#120466 - Dylan-DPC:rollup-v0or19a, r=Dylan-DPC
9ee33fb 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#116677 (References refer to allocated objects)
 - rust-lang#118625 (Improve handling of expressions in patterns)
 - rust-lang#120266 (Improve documentation for [A]Rc::into_inner)
 - rust-lang#120373 (Adjust Behaviour of `read_dir` and `ReadDir` in Windows Implementation: Check Whether Path to Search In Exists)
 - rust-lang#120390 (Borrow check inline const patterns)
 - rust-lang#120420 (Stop using derivative in rustc_pattern_analysis)
 - rust-lang#120428 (hir: Two preparatory changes for rust-lang#120206)
 - rust-lang#120453 (Fix incorrect comment in normalize_newlines)
 - rust-lang#120462 (Clean dead code)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 29, 2024
@bors
Auto merge of rust-lang#120466 - Dylan-DPC:rollup-v0or19a, r=Dylan-DPC
5518eaa 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#116677 (References refer to allocated objects)
 - rust-lang#118625 (Improve handling of expressions in patterns)
 - rust-lang#120266 (Improve documentation for [A]Rc::into_inner)
 - rust-lang#120373 (Adjust Behaviour of `read_dir` and `ReadDir` in Windows Implementation: Check Whether Path to Search In Exists)
 - rust-lang#120390 (Borrow check inline const patterns)
 - rust-lang#120420 (Stop using derivative in rustc_pattern_analysis)
 - rust-lang#120428 (hir: Two preparatory changes for rust-lang#120206)
 - rust-lang#120453 (Fix incorrect comment in normalize_newlines)
 - rust-lang#120462 (Clean dead code)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5de94a3 into rust-lang:master Jan 29, 2024
11 checks passed
@rustbot rustbot added this to the 1.77.0 milestone Jan 29, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 29, 2024
@rust-timer
Unrolled build for rust-lang#120420
bc00a84 
Rollup merge of rust-lang#120420 - lnicola:rm-pattern-analysis-derivative, r=Nilstrieb

Stop using derivative in rustc_pattern_analysis

CC rust-lang#109302, rust-lang/rust-analyzer#16420 (comment)

r? ````@Nadrieril````
@lnicola lnicola deleted the rm-pattern-analysis-derivative branch January 30, 2024 06:00
@Nadrieril Nadrieril mentioned this pull request Jan 31, 2024
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 31, 2024
@matthiaskrgr
Rollup merge of rust-lang#120516 - Nadrieril:cleanup-impls, r=compile…
c4da12a 
…r-errors

pattern_analysis: cleanup manual impls

rust-lang#120420 introduced some unneeded manual impls. I remove them here.

r? `@Nilstrieb`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 31, 2024
@matthiaskrgr
Rollup merge of rust-lang#120516 - Nadrieril:cleanup-impls, r=compile…
5f73290 
…r-errors

pattern_analysis: cleanup manual impls

rust-lang#120420 introduced some unneeded manual impls. I remove them here.

r? ``@Nilstrieb``
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 3, 2024
@matthiaskrgr
Rollup merge of rust-lang#120516 - Nadrieril:cleanup-impls, r=compile…
f3ebf1e 
…r-errors

pattern_analysis: cleanup manual impls

rust-lang#120420 introduced some unneeded manual impls. I remove them here.

r? ```@Nilstrieb```
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 4, 2024
@rust-timer
Unrolled build for rust-lang#120516
7e49221 
Rollup merge of rust-lang#120516 - Nadrieril:cleanup-impls, r=compiler-errors

pattern_analysis: cleanup manual impls

rust-lang#120420 introduced some unneeded manual impls. I remove them here.

r? ```@Nilstrieb```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Nadrieril Nadrieril

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.77.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lnicola @rustbot @Nilstrieb @bors @Nadrieril @fmease