Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FileCheck annotations to MIR-opt SROA tests #120455

Merged
merged 4 commits into from
Feb 7, 2024
Merged

Add FileCheck annotations to MIR-opt SROA tests #120455

merged 4 commits into from
Feb 7, 2024

Conversation

JarlEvanson
Copy link
Contributor

Part of #116971, adds FileCheck annotations to SROA MIR-opt tests in tests/mir-opt/sroa and a few uncategorized files.

r? cjgillot

@rustbot
Copy link
Collaborator

rustbot commented Jan 28, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cjgillot (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 28, 2024
cjgillot
cjgillot reviewed Jan 28, 2024
View reviewed changes
tests/mir-opt/sroa/lifetimes.rs Outdated Show resolved Hide resolved
tests/mir-opt/sroa/structs.rs Outdated Show resolved Hide resolved
tests/mir-opt/sroa/structs.rs Show resolved Hide resolved
tests/mir-opt/sroa/structs.rs Outdated Show resolved Hide resolved
tests/mir-opt/sroa/structs.rs Outdated Show resolved Hide resolved
tests/mir-opt/sroa/structs.rs Outdated Show resolved Hide resolved
tests/mir-opt/sroa/structs.rs Outdated Show resolved Hide resolved
tests/mir-opt/sroa/structs.rs Show resolved Hide resolved
@JarlEvanson
Copy link
Contributor Author

Thanks for the review. I think I implemented all your suggestions, but let me know if I didn't.

cjgillot
cjgillot reviewed Feb 4, 2024
View reviewed changes
Copy link
Contributor

@cjgillot cjgillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JarlEvanson. A few more nits, and will be good to go.

tests/mir-opt/remove_storage_markers.rs Outdated Show resolved Hide resolved
tests/mir-opt/sroa/structs.rs Outdated Show resolved Hide resolved
tests/mir-opt/sroa/structs.rs Outdated Show resolved Hide resolved
tests/mir-opt/sroa/structs.rs Outdated Show resolved Hide resolved
tests/mir-opt/sroa/structs.rs Outdated Show resolved Hide resolved
tests/mir-opt/sroa/structs.rs Show resolved Hide resolved
tests/mir-opt/sroa/structs.rs Show resolved Hide resolved
tests/mir-opt/sroa/structs.rs Outdated Show resolved Hide resolved
tests/mir-opt/sroa/structs.rs Show resolved Hide resolved
@cjgillot
Copy link
Contributor

cjgillot commented Feb 6, 2024

Thanks!
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 6, 2024

📌 Commit bae4f17 has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 6, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 7, 2024
@matthiaskrgr
Rollup merge of rust-lang#120455 - JarlEvanson:sroa-miri-tests, r=cjg…
8bdae44 
…illot

 Add FileCheck annotations to MIR-opt SROA tests

Part of rust-lang#116971, adds FileCheck annotations to SROA MIR-opt tests in `tests/mir-opt/sroa` and a few uncategorized files.

r? cjgillot
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 7, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 7, 2024
@bors
Auto merge of rust-lang#120731 - matthiaskrgr:rollup-wsmujwc, r=matth…
9e350cf 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#119162 (Add unstable `-Z direct-access-external-data` cmdline flag for `rustc`)
 - rust-lang#119592 (resolve: Unload speculatively resolved crates before freezing cstore)
 - rust-lang#120103 (Make it so that async-fn-in-trait is compatible with a concrete future in implementation)
 - rust-lang#120455 ( Add FileCheck annotations to MIR-opt SROA tests)
 - rust-lang#120470 (Mark "unused binding" suggestion as maybe incorrect)
 - rust-lang#120619 (Assert that params with the same *index* have the same *name*)
 - rust-lang#120633 (pattern_analysis: gather up place-relevant info)
 - rust-lang#120726 (Don't use bashism in checktools.sh)

r? `@ghost`
`@rustbot` modify labels: rollup
Nadrieril added a commit to Nadrieril/rust that referenced this pull request Feb 7, 2024
@Nadrieril
Rollup merge of rust-lang#120455 - JarlEvanson:sroa-miri-tests, r=cjg…
5661a5b 
…illot

 Add FileCheck annotations to MIR-opt SROA tests

Part of rust-lang#116971, adds FileCheck annotations to SROA MIR-opt tests in `tests/mir-opt/sroa` and a few uncategorized files.

r? cjgillot
@Nadrieril Nadrieril mentioned this pull request Feb 7, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 7, 2024
@bors
Auto merge of rust-lang#120743 - Nadrieril:rollup-h2mxjc2, r=Nadrieril
e8ec9f4 
Rollup of 13 pull requests

Successful merges:

 - rust-lang#110482 (Add armv8r-none-eabihf target for the Cortex-R52.)
 - rust-lang#119162 (Add unstable `-Z direct-access-external-data` cmdline flag for `rustc`)
 - rust-lang#120302 (various const interning cleanups)
 - rust-lang#120455 ( Add FileCheck annotations to MIR-opt SROA tests)
 - rust-lang#120470 (Mark "unused binding" suggestion as maybe incorrect)
 - rust-lang#120479 (Suggest turning `if let` into irrefutable `let` if appropriate)
 - rust-lang#120564 (coverage: Split out counter increment sites from BCB node/edge counters)
 - rust-lang#120633 (pattern_analysis: gather up place-relevant info)
 - rust-lang#120664 (Add parallel rustc ui tests)
 - rust-lang#120721 (fix `llvm_out` to use the correct LLVM root)
 - rust-lang#120726 (Don't use bashism in checktools.sh)
 - rust-lang#120733 (MirPass: make name more const)
 - rust-lang#120735 (Remove some `unchecked_claim_error_was_emitted` calls)

Failed merges:

 - rust-lang#120727 (exhaustiveness: Prefer "`0..MAX` not covered" to "`_` not covered")

r? `@ghost`
`@rustbot` modify labels: rollup
@Nadrieril Nadrieril mentioned this pull request Feb 7, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 7, 2024
@bors
Auto merge of rust-lang#120748 - Nadrieril:rollup-dj0qwv5, r=Nadrieril
8ace7ea 
Rollup of 13 pull requests

Successful merges:

 - rust-lang#110482 (Add armv8r-none-eabihf target for the Cortex-R52.)
 - rust-lang#119162 (Add unstable `-Z direct-access-external-data` cmdline flag for `rustc`)
 - rust-lang#120302 (various const interning cleanups)
 - rust-lang#120455 ( Add FileCheck annotations to MIR-opt SROA tests)
 - rust-lang#120470 (Mark "unused binding" suggestion as maybe incorrect)
 - rust-lang#120479 (Suggest turning `if let` into irrefutable `let` if appropriate)
 - rust-lang#120564 (coverage: Split out counter increment sites from BCB node/edge counters)
 - rust-lang#120633 (pattern_analysis: gather up place-relevant info)
 - rust-lang#120664 (Add parallel rustc ui tests)
 - rust-lang#120726 (Don't use bashism in checktools.sh)
 - rust-lang#120733 (MirPass: make name more const)
 - rust-lang#120735 (Remove some `unchecked_claim_error_was_emitted` calls)
 - rust-lang#120746 (Record coroutine kind in coroutine generics)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 65c0954 into rust-lang:master Feb 7, 2024
11 checks passed
@rustbot rustbot added this to the 1.78.0 milestone Feb 7, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 7, 2024
@rust-timer
Unrolled build for rust-lang#120455
101d3eb 
Rollup merge of rust-lang#120455 - JarlEvanson:sroa-miri-tests, r=cjgillot

 Add FileCheck annotations to MIR-opt SROA tests

Part of rust-lang#116971, adds FileCheck annotations to SROA MIR-opt tests in `tests/mir-opt/sroa` and a few uncategorized files.

r? cjgillot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjgillot cjgillot cjgillot left review comments

Assignees

@cjgillot cjgillot

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.78.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JarlEvanson @rustbot @cjgillot @bors