-
Notifications
You must be signed in to change notification settings - Fork 12.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax the Sized requirement on the Error impl for Box. #120457
base: master
Are you sure you want to change the base?
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
The job Click to see the possible cause of the failure (guessed by this bot)
|
r? libs-api |
The job Click to see the possible cause of the failure (guessed by this bot)
|
I don't understand how this creates conflicting impls of From? |
Because |
@smmalis37 any updates on this? thanks. You can ask on Zulip if you need help with fixing the test. |
I think based on @joboet 's explanation this change can't be done without some form of specialization, as nice as it would be. |
This is already the case for Arc and ThinBox, so I'm guessing this was just an oversight? This will be insta-stable, and probably needs an FCP.