rustc_ast: FieldDef: remove span #120525

klensy · 2024-01-31T12:50:18Z

it can be calculated from Visibility + Ty, at least tests passed?

perf me, please

it can be calculated from Visibility + Ty

rustbot · 2024-01-31T12:50:25Z

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

rustbot · 2024-01-31T12:50:27Z

Changes to the size of AST and/or HIR nodes.

cc @nnethercote

rustbot · 2024-01-31T13:15:24Z

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

rust-log-analyzer · 2024-01-31T13:34:34Z

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

GITHUB_ACTION=__run_7
GITHUB_ACTIONS=true
GITHUB_ACTION_REF=
GITHUB_ACTION_REPOSITORY=
GITHUB_ACTOR=klensy
GITHUB_API_URL=https://api.github.com
GITHUB_BASE_REF=master
GITHUB_ENV=/home/runner/work/_temp/_runner_file_commands/set_env_77281bf8-a7fc-46c3-94a9-2f8d60119c0a
GITHUB_EVENT_NAME=pull_request
---
GITHUB_SERVER_URL=https://github.com
GITHUB_SHA=62d47cfedcc9448f8e4b3ec777fb0a032d1c88fe
GITHUB_STATE=/home/runner/work/_temp/_runner_file_commands/save_state_77281bf8-a7fc-46c3-94a9-2f8d60119c0a
GITHUB_STEP_SUMMARY=/home/runner/work/_temp/_runner_file_commands/step_summary_77281bf8-a7fc-46c3-94a9-2f8d60119c0a
GITHUB_TRIGGERING_ACTOR=klensy
GITHUB_WORKFLOW_REF=rust-lang/rust/.github/workflows/ci.yml@refs/pull/120525/merge
GITHUB_WORKFLOW_SHA=62d47cfedcc9448f8e4b3ec777fb0a032d1c88fe
GITHUB_WORKSPACE=/home/runner/work/rust/rust
GOROOT_1_19_X64=/opt/hostedtoolcache/go/1.19.13/x64
---

...........................................................................
Mismatch at src/cargo-fmt/main.rs:32:
 pub struct Opts {
     /// No output printed to stdout
     #[arg(short = 'q', long = "quiet")]
+    /// No output printed to stdout
+    #[arg(short = 'q', long = "quiet")]
     quiet: bool,
     /// Use verbose output

Mismatch at src/cargo-fmt/main.rs:38:
Mismatch at src/cargo-fmt/main.rs:38:
     #[arg(short = 'v', long = "verbose")]
+    /// Use verbose output
+    #[arg(short = 'v', long = "verbose")]
     verbose: bool,
     /// Print rustfmt version and exit

Mismatch at src/cargo-fmt/main.rs:42:
Mismatch at src/cargo-fmt/main.rs:42:
     #[arg(long = "version")]
+    /// Print rustfmt version and exit
+    #[arg(long = "version")]
 
     /// Specify package to format

Mismatch at src/cargo-fmt/main.rs:46:
---
         value_name = "package",

Mismatch at src/cargo-fmt/main.rs:53:
 
     /// Specify path to Cargo.toml
     #[arg(long = "manifest-path", value_name = "manifest-path")]
+    /// Specify path to Cargo.toml
+    #[arg(long = "manifest-path", value_name = "manifest-path")]
     manifest_path: Option<String>,
 
     /// Specify message-format: short|json|human
Mismatch at src/cargo-fmt/main.rs:59:
Mismatch at src/cargo-fmt/main.rs:59:
     #[arg(long = "message-format", value_name = "message-format")]
+    /// Specify message-format: short|json|human
+    #[arg(long = "message-format", value_name = "message-format")]
     message_format: Option<String>,
     /// Options passed to rustfmt

Mismatch at src/cargo-fmt/main.rs:63:
Mismatch at src/cargo-fmt/main.rs:63:
     // 'raw = true' to make `--` explicit.
     #[arg(name = "rustfmt_options", raw = true)]
+    /// Options passed to rustfmt
+    // 'raw = true' to make `--` explicit.
+    #[arg(name = "rustfmt_options", raw = true)]
     rustfmt_options: Vec<String>,
     /// Format all packages, and also their local path-based dependencies

Mismatch at src/cargo-fmt/main.rs:68:
Mismatch at src/cargo-fmt/main.rs:68:
     #[arg(long = "all")]
+    /// Format all packages, and also their local path-based dependencies
+    #[arg(long = "all")]
 
     /// Run rustfmt in check mode

Mismatch at src/cargo-fmt/main.rs:72:
Mismatch at src/cargo-fmt/main.rs:72:
     #[arg(long = "check")]
+    /// Run rustfmt in check mode
+    #[arg(long = "check")]
 }
 

Mismatch at src/cargo-fmt/main.rs:267:
Mismatch at src/cargo-fmt/main.rs:267:
 #[derive(Debug)]
 pub struct Target {
     /// A path to the main source file of the target.
+    /// A path to the main source file of the target.
     path: PathBuf,
     /// A kind of target (e.g., lib, bin, example, ...).
+    /// A kind of target (e.g., lib, bin, example, ...).
+    /// Rust edition for this target.
     /// Rust edition for this target.
     edition: Edition,
 }
 }
{ "type": "test", "name": "test::verify_check_l_works_with_stdin", "event": "ok" }
....
Mismatch at src/format-diff/main.rs:46:
 pub struct Opts {
     /// Skip the smallest prefix containing NUMBER slashes
     #[clap(
+    short = 'p',
+    long = "skip-prefix",
+    value_name = "NUMBER",
+    )]
+    )]
+    /// Skip the smallest prefix containing NUMBER slashes
+    #[clap(
         short = 'p',
         long = "skip-prefix",
         value_name = "NUMBER",
Mismatch at src/format-diff/main.rs:53:
     )]
     skip_prefix: u32,
 
 
+    /// Custom pattern selecting file paths to reformat
+    #[clap(
+    long = "filter",
+    value_name = "PATTERN",
+    default_value = DEFAULT_PATTERN
+    )]
+    )]
     /// Custom pattern selecting file paths to reformat
     #[clap(
{ "type": "test", "name": "test::configuration_snippet::configuration_snippet_tests", "event": "ok" }


Mismatch at tests/source/configs/struct_field_align_threshold/20.rs:36:
 /// A Doc comment
 #[AnAttribute]
 pub struct Foo {
-    #[rustfmt::skip]
     f :   SomeType, // Comment beside a field
     f:     SomeType, // Comment beside a field
     // Comment on a field

Mismatch at tests/source/configs/struct_field_align_threshold/20.rs:43:
+    // #[AnAttribute]
     #[AnAttribute]
     g:     SomeOtherType,
     /// A doc comment on a field

Mismatch at tests/source/configs/struct_field_align_threshold/20.rs:46:
+    /// A doc comment on a field
     h:     AThirdType,
     pub i: TypeForPublicField,


Mismatch at tests/source/configs/struct_field_align_threshold/20.rs:57:
 // #1029
 struct X {
     // `x` is an important number.
+    // #[allow(unused)] // TODO: use
     #[allow(unused)] // TODO: use
 }


Mismatch at tests/source/configs/struct_field_align_threshold/20.rs:162:
 
 struct Palette {
 struct Palette {
+    /// A map of indices in the palette to a count of pixels in approximately that color
     /// A map of indices in the palette to a count of pixels in approximately
     foo: i32,


Mismatch at tests/source/configs/struct_field_align_threshold/20.rs:171:
 // when the field had attributes
 struct FieldsWithAttributes {
     // Pre Comment
-    #[rustfmt::skip] pub host:String, /* Post comment BBBBBBBBBBBBBB BBBBBBBBBBBBBBBB
-                                       * BBBBBBBBBBBBBBBB BBBBBBBBBBBBBBBBB BBBBBBBBBBB */
+    // #[rustfmt::skip]
+    pub host:String, /* Post comment BBBBBBBBBBBBBB BBBBBBBBBBBBBBBB BBBBBBBBBBBBBBBB
+                      * BBBBBBBBBBBBBBBBB BBBBBBBBBBB */
     // Another pre comment
+    // #[attr1]
+    // #[attr2]
     #[attr1]
     #[attr2]
     pub id: usize, /* CCCCCCCCCCCCCCCCCCC CCCCCCCCCCCCCCCCCCC CCCCCCCCCCCCCCCC

Mismatch at tests/target/configs/struct_field_align_threshold/20.rs:36:
 /// A Doc comment
 #[AnAttribute]
 pub struct Foo {
-    #[rustfmt::skip]
     f :   SomeType, // Comment beside a field
     f:     SomeType, // Comment beside a field
     // Comment on a field

Mismatch at tests/target/configs/struct_field_align_threshold/20.rs:43:
+    // #[AnAttribute]
     #[AnAttribute]
     g:     SomeOtherType,
     /// A doc comment on a field

Mismatch at tests/target/configs/struct_field_align_threshold/20.rs:46:
+    /// A doc comment on a field
     h:     AThirdType,
     pub i: TypeForPublicField,


Mismatch at tests/target/configs/struct_field_align_threshold/20.rs:57:
 // #1029
 struct X {
     // `x` is an important number.
+    // #[allow(unused)] // TODO: use
     #[allow(unused)] // TODO: use
 }


Mismatch at tests/target/configs/struct_field_align_threshold/20.rs:164:
 struct Palette {
     /// A map of indices in the palette to a count of pixels in approximately
     /// that color
+    /// A map of indices in the palette to a count of pixels in approximately
     foo: i32,
 }
 


Mismatch at tests/target/configs/struct_field_align_threshold/20.rs:171:
 // when the field had attributes
 struct FieldsWithAttributes {
     // Pre Comment
-    #[rustfmt::skip] pub host:String, /* Post comment BBBBBBBBBBBBBB BBBBBBBBBBBBBBBB
-                                       * BBBBBBBBBBBBBBBB BBBBBBBBBBBBBBBBB BBBBBBBBBBB */
+    // #[rustfmt::skip]
+    pub host:String, /* Post comment BBBBBBBBBBBBBB BBBBBBBBBBBBBBBB
+                      * BBBBBBBBBBBBBBBB BBBBBBBBBBBBBBBBB BBBBBBBBBBB */
     // Another pre comment
+    // #[attr1]
+    // #[attr2]
     #[attr1]
     #[attr2]
     pub id: usize, /* CCCCCCCCCCCCCCCCCCC CCCCCCCCCCCCCCCCCCC CCCCCCCCCCCCCCCC
Mismatch at tests/source/structs.rs:4:
 /// A Doc comment
 #[AnAttribute]
 pub struct Foo {
 pub struct Foo {
-    #[rustfmt::skip]
     f :   SomeType, // Comment beside a field
-    f: SomeType, // Comment beside a field
+    f: SomeType,    // Comment beside a field
     // Comment on a field
+    // #[AnAttribute]
     #[AnAttribute]
     g: SomeOtherType,
     /// A doc comment on a field
Mismatch at tests/source/structs.rs:14:
+    /// A doc comment on a field
+    /// A doc comment on a field
     h: AThirdType,
     pub i: TypeForPublicField,

Mismatch at tests/source/structs.rs:44:
 // #1029
 struct X {
 struct X {
     // `x` is an important number.
+    // #[allow(unused)] // TODO: use
     #[allow(unused)] // TODO: use
 }

Mismatch at tests/source/structs.rs:149:
 }
 }
 
 struct Palette {
+    /// A map of indices in the palette to a count of pixels in approximately that color
     /// A map of indices in the palette to a count of pixels in approximately
     foo: i32,

Mismatch at tests/source/structs.rs:158:
 // when the field had attributes
 // when the field had attributes
 struct FieldsWithAttributes {
     // Pre Comment
-    #[rustfmt::skip] pub host:String, /* Post comment BBBBBBBBBBBBBB BBBBBBBBBBBBBBBB
-                                       * BBBBBBBBBBBBBBBB BBBBBBBBBBBBBBBBB BBBBBBBBBBB */
+    // #[rustfmt::skip]
+    pub host:String, /* Post comment BBBBBBBBBBBBBB BBBBBBBBBBBBBBBB BBBBBBBBBBBBBBBB
+                      * BBBBBBBBBBBBBBBBB BBBBBBBBBBB */
     // Another pre comment
+    // #[attr1]
+    // #[attr2]
     #[attr1]
     #[attr2]
     pub id: usize, /* CCCCCCCCCCCCCCCCCCC CCCCCCCCCCCCCCCCCCC CCCCCCCCCCCCCCCC
Mismatch at tests/source/structs.rs:342:
 
 // #2208
 struct Test {
 struct Test {
+    /// foo
+    // #[serde(default)]
     #[serde(default)]
     #[serde(default)]
     pub join: Vec<String>,
Mismatch at tests/target/structs.rs:4:
 /// A Doc comment
 #[AnAttribute]
 pub struct Foo {
 pub struct Foo {
-    #[rustfmt::skip]
     f :   SomeType, // Comment beside a field
-    f: SomeType, // Comment beside a field
+    f: SomeType,    // Comment beside a field
     // Comment on a field
+    // #[AnAttribute]
     #[AnAttribute]
     g: SomeOtherType,
     /// A doc comment on a field
Mismatch at tests/target/structs.rs:14:
+    /// A doc comment on a field
+    /// A doc comment on a field
     h: AThirdType,
     pub i: TypeForPublicField,

Mismatch at tests/target/structs.rs:44:
 // #1029
 struct X {
 struct X {
     // `x` is an important number.
+    // #[allow(unused)] // TODO: use
     #[allow(unused)] // TODO: use
 }

Mismatch at tests/target/structs.rs:151:
 struct Palette {
 struct Palette {
     /// A map of indices in the palette to a count of pixels in approximately
     /// that color
+    /// A map of indices in the palette to a count of pixels in approximately
     foo: i32,
 }
 


Mismatch at tests/target/structs.rs:158:
 // when the field had attributes
 struct FieldsWithAttributes {
     // Pre Comment
-    #[rustfmt::skip] pub host:String, /* Post comment BBBBBBBBBBBBBB BBBBBBBBBBBBBBBB
-                                       * BBBBBBBBBBBBBBBB BBBBBBBBBBBBBBBBB BBBBBBBBBBB */
+    // #[rustfmt::skip]
+    pub host:String, /* Post comment BBBBBBBBBBBBBB BBBBBBBBBBBBBBBB
+                      * BBBBBBBBBBBBBBBB BBBBBBBBBBBBBBBBB BBBBBBBBBBB */
     // Another pre comment
+    // #[attr1]
+    // #[attr2]
     #[attr1]
     #[attr2]
     pub id: usize, /* CCCCCCCCCCCCCCCCCCC CCCCCCCCCCCCCCCCCCC CCCCCCCCCCCCCCCC
Mismatch at tests/target/structs.rs:342:
 
 // #2208
 struct Test {
 struct Test {
+    /// foo
+    // #[serde(default)]
     #[serde(default)]
     #[serde(default)]
     pub join: Vec<String>,
Mismatch at tests/target/issue-4791/issue_4928.rs:27:
Mismatch at tests/target/issue-4791/issue_4928.rs:27:
     /// ut labore et dolore magna aliqua. Morbi quis commodo odio aenean sed adipiscing. Nunc
     /// congue nisi vitae suscipit tellus mauris a. Consectetur adipiscing elit pellentesque
     /// habitant morbi tristique senectus.
+    /// Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt
+    /// ut labore et dolore magna aliqua. Morbi quis commodo odio aenean sed adipiscing. Nunc
+    /// congue nisi vitae suscipit tellus mauris a. Consectetur adipiscing elit pellentesque
+    /// habitant morbi tristique senectus.
     pub foo: u32,
 
     /// Elit eget gravida cum sociis natoque penatibus et magnis dis. Consequat semper viverra nam
Mismatch at tests/target/issue-4791/issue_4928.rs:37:
     ///
     ///
     /// Lacinia at quis risus sed vulputate odio ut enim. Etiam erat velit scelerisque in dictum.
     /// Nibh tellus molestie nunc non blandit massa enim nec. Nascetur ridiculus mus mauris vitae.
+    /// Elit eget gravida cum sociis natoque penatibus et magnis dis. Consequat semper viverra nam
+    /// libero. Accumsan in nisl nisi scelerisque eu. Pellentesque id nibh tortor id aliquet. Sed
+    /// velit dignissim sodales ut. Facilisis sed odio morbi quis commodo odio aenean sed. Et
+    /// ultrices neque ornare aenean euismod elementum. Condimentum lacinia quis vel eros donec ac
+    /// odio tempor.
+    ///
+    /// Lacinia at quis risus sed vulputate odio ut enim. Etiam erat velit scelerisque in dictum.
+    /// Nibh tellus molestie nunc non blandit massa enim nec. Nascetur ridiculus mus mauris vitae.
     pub bar: u32,
 
     /// Mi proin sed libero enim sed faucibus turpis. Amet consectetur adipiscing elit duis
Mismatch at tests/target/issue-4791/issue_4928.rs:51:
Mismatch at tests/target/issue-4791/issue_4928.rs:51:
     /// [`FooBar::beep()`]: crate::foobar::FooBar::beep
     /// [`FooBar::boop()`]: crate::foobar::FooBar::boop
     /// [`foobar::BazBaq::BEEP_BOOP`]: crate::foobar::BazBaq::BEEP_BOOP
+    /// Mi proin sed libero enim sed faucibus turpis. Amet consectetur adipiscing elit duis
+    /// tristique sollicitudin nibh sit amet. Congue quisque egestas diam in arcu cursus euismod
+    /// quis viverra. Cum sociis natoque penatibus et magnis dis parturient montes. Enim sit amet
+    /// venenatis urna cursus eget nunc scelerisque viverra. Cras semper auctor neque vitae tempus
+    /// quam pellentesque. Tortor posuere ac ut consequat semper viverra nam libero justo. Vitae
+    /// auctor eu augue ut lectus arcu bibendum at. Faucibus vitae aliquet nec ullamcorper sit amet
+    /// risus nullam. Maecenas accumsan lacus vel facilisis volutpat. Arcu non odio euismod
+    /// lacinia.
+    ///
+    /// [`FooBar::beep()`]: crate::foobar::FooBar::beep
+    /// [`FooBar::boop()`]: crate::foobar::FooBar::boop
+    /// [`foobar::BazBaq::BEEP_BOOP`]: crate::foobar::BazBaq::BEEP_BOOP
     pub baz: u32,
 
     /// Eu consequat ac felis donec et odio pellentesque diam. Ut eu sem integer vitae justo eget.
Mismatch at tests/target/issue-4791/issue_4928.rs:57:
Mismatch at tests/target/issue-4791/issue_4928.rs:57:
     /// Consequat ac felis donec et odio pellentesque diam volutpat.
+    /// Eu consequat ac felis donec et odio pellentesque diam. Ut eu sem integer vitae justo eget.
+    /// Consequat ac felis donec et odio pellentesque diam volutpat.
     pub baq: u32,
 
+    /// Amet consectetur adipiscing elit pellentesque habitant. Ut morbi tincidunt augue interdum
+    /// velit euismod in pellentesque. Imperdiet sed euismod nisi porta lorem. Nec tincidunt
+    /// praesent semper feugiat. Facilisis leo vel fringilla est. Egestas diam in arcu cursus
+    /// euismod quis viverra. Sagittis eu volutpat odio facilisis mauris sit amet. Posuere morbi
+    /// leo urna molestie at.
+    ///
+    /// Pretium aenean pharetra magna ac. Nisl condimentum id venenatis a condimentum vitae. Semper
+    /// quis lectus nulla at volutpat diam ut venenatis tellus. Egestas tellus rutrum tellus
+    /// pellentesque eu tincidunt tortor aliquam.
     /// Amet consectetur adipiscing elit pellentesque habitant. Ut morbi tincidunt augue interdum
     /// velit euismod in pellentesque. Imperdiet sed euismod nisi porta lorem. Nec tincidunt
     /// praesent semper feugiat. Facilisis leo vel fringilla est. Egestas diam in arcu cursus
Mismatch at tests/source/struct_field_doc_comment.rs:41:
 struct MyStruct {
 struct MyStruct {
     #[cfg(unix)] // some comment
     a: u64,
+    #[cfg(not(unix))] /*block comment */
     #[cfg(not(unix))] /*block comment */ b: u32,
 

Mismatch at tests/source/struct_field_doc_comment.rs:47:
 struct MyStruct {
 struct MyStruct {
     #[cfg(unix)] // some comment
     pub a: u64,
+    #[cfg(not(unix))] /*block comment */
     #[cfg(not(unix))] /*block comment */ pub(crate) b: u32,
 

Mismatch at tests/source/struct_field_doc_comment.rs:53:
 struct MyStruct {
 struct MyStruct {
     /// Doc Comments
     /* TODO note to add more to Doc Comments */
+    /// Doc Comments
+    /* TODO note to add more to Doc Comments */
     a: u32,
     /// Doc Comments
     // TODO note
Mismatch at tests/source/struct_field_doc_comment.rs:59:
+    /// Doc Comments
+    // TODO note
     b: u64,
     b: u64,
 }
 

Mismatch at tests/source/struct_field_doc_comment.rs:62:
 struct MyStruct {
     /// Doc Comments
     /* TODO note to add more to Doc Comments */
+    /// Doc Comments
+    /* TODO note to add more to Doc Comments */
     pub a: u32,
+    /// Doc Comments
+    // TODO note
     /// Doc Comments
     // TODO note
     pub(crate) b: u64,
Mismatch at src/macros.rs:694:
 /// Parses macro arguments on macro def.
 struct MacroArgParser {
 struct MacroArgParser {
     /// Either a name of the next metavariable, a separator, or junk.
+    /// Either a name of the next metavariable, a separator, or junk.
     buf: String,
     /// The first token of the current buffer.
+    /// The first token of the current buffer.
     start_tok: Token,
     /// `true` if we are parsing a metavariable or a repeat.
+    /// `true` if we are parsing a metavariable or a repeat.
     is_meta_var: bool,
+    /// The last token parsed.
     last_tok: Token,
+    /// Holds the parsed arguments.
     /// Holds the parsed arguments.
     /// Holds the parsed arguments.
     result: Vec<ParsedMacroArg>,

Mismatch at src/matches.rs:27:
Mismatch at src/matches.rs:27:
     arm: &'a ast::Arm,
     /// `true` if the arm is the last one in match expression. Used to decide on whether we should
     /// add trailing comma to the match arm when `config.trailing_comma() == Never`.
+    /// `true` if the arm is the last one in match expression. Used to decide on whether we should
+    /// add trailing comma to the match arm when `config.trailing_comma() == Never`.
     is_last: bool,
+    /// Holds a byte position of `|` at the beginning of the arm pattern, if available.
     /// Holds a byte position of `|` at the beginning of the arm pattern, if available.
     beginning_vert: Option<BytePos>,

Mismatch at src/rustfmt_diff.rs:15:
 #[derive(Debug, PartialEq)]
 pub(crate) struct Mismatch {
 pub(crate) struct Mismatch {
     /// The line number in the formatted version.
+    /// The line number in the formatted version.
     pub(crate) line_number: u32,
     /// The line number in the original version.
+    /// The line number in the original version.
     pub(crate) line_number_orig: u32,
     /// The set of lines (context and old/new) in the mismatch.
+    /// The set of lines (context and old/new) in the mismatch.
     pub(crate) lines: Vec<DiffLine>,
 

Mismatch at src/rustfmt_diff.rs:37:
Mismatch at src/rustfmt_diff.rs:37:
 #[derive(Debug, PartialEq, Eq)]
 pub struct ModifiedChunk {
     /// The first to be removed from the original text
+    /// The first to be removed from the original text
     pub line_number_orig: u32,
---
 }

Mismatch at src/missed_spans.rs:12:
 
 struct SnippetStatus {
     /// An offset to the current line from the beginning of the original snippet.
+    /// An offset to the current line from the beginning of the original snippet.
     line_start: usize,
     /// A length of trailing whitespaces on the current line.
+    /// A length of trailing whitespaces on the current line.
     last_wspace: Option<usize>,
     /// The current line number.
     cur_line: usize,
 }


Mismatch at src/comment.rs:444:
 /// Different level of indentation are handled by shrinking the shape accordingly.
 struct ItemizedBlock {
+    /// the lines that are identified as part of an itemized block
     lines: Vec<String>,
     lines: Vec<String>,
     /// the number of characters (typically whitespaces) up to the item marker
+    /// the number of characters (typically whitespaces) up to the item marker
     /// the string that marks the start of an item
+    /// the string that marks the start of an item
     opener: String,
     opener: String,
+    /// sequence of characters (typically whitespaces) to prefix new lines that are part of the item
     /// sequence of characters (typically whitespaces) to prefix new lines that are part of the item
     line_start: String,

Mismatch at src/formatting.rs:394:
     pub(crate) has_check_errors: bool,
 
 
     /// Formatted code differs from existing code (--check only).
+    /// Formatted code differs from existing code (--check only).
     pub(crate) has_diff: bool,
+    /// Formatted code missed something, like lost comments or extra trailing space
     /// Formatted code missed something, like lost comments or extra trailing space
     pub(crate) has_unformatted_code_errors: bool,
 }
---
 }
 

Mismatch at src/visitor.rs:32:
 /// Creates a string slice corresponding to the specified span.
 pub(crate) struct SnippetProvider {
     /// A pointer to the content of the file we are formatting.
+    /// A pointer to the content of the file we are formatting.
     big_snippet: Lrc<String>,
     /// A position of the start of `big_snippet`, used as an offset.
+    /// A position of the start of `big_snippet`, used as an offset.
     start_pos: usize,
     /// An end position of the file that this snippet lives.
+    /// An end position of the file that this snippet lives.
     end_pos: usize,
 

Mismatch at src/visitor.rs:80:
     pub(crate) is_if_else_block: bool,
     pub(crate) is_if_else_block: bool,
     pub(crate) snippet_provider: &'a SnippetProvider,
     pub(crate) line_number: usize,
+    /// List of 1-based line ranges which were annotated with skip
+    /// Both bounds are inclusifs.
     /// List of 1-based line ranges which were annotated with skip
     /// Both bounds are inclusifs.
     pub(crate) skipped_range: Rc<RefCell<Vec<(usize, usize)>>>,
{ "type": "test", "name": "test::self_tests", "event": "failed", "stdout": "Ran 5 self tests.\nthread 'test::self_tests' panicked at src/tools/rustfmt/src/test/mod.rs:400:5:\nassertion `left == right` failed: 3 self tests failed\n  left: 3\n right: 0\nnote: run with `RUST_BACKTRACE=1` environment variable to display a backtrace\n" }
Mismatch at tests/target/struct_field_doc_comment.rs:41:
 struct MyStruct {
 struct MyStruct {
     #[cfg(unix)] // some comment
     a: u64,
-    #[cfg(not(unix))] /*block comment */ b: u32,
+    #[cfg(not(unix))] /*block comment */ #[cfg(not(unix))] /*block comment */ b: u32,
 
 struct MyStruct {

Mismatch at tests/target/struct_field_doc_comment.rs:48:
Mismatch at tests/target/struct_field_doc_comment.rs:48:
     #[cfg(unix)] // some comment
     pub a: u64,
+    #[cfg(not(unix))] /*block comment */
     #[cfg(not(unix))] /*block comment */ pub(crate) b: u32,
 

Mismatch at tests/target/struct_field_doc_comment.rs:53:
 struct MyStruct {
 struct MyStruct {
     /// Doc Comments
     /* TODO note to add more to Doc Comments */
+    /// Doc Comments
+    /* TODO note to add more to Doc Comments */
     a: u32,
     /// Doc Comments
     // TODO note
Mismatch at tests/target/struct_field_doc_comment.rs:59:
+    /// Doc Comments
+    // TODO note
     b: u64,
     b: u64,
 }
 

Mismatch at tests/target/struct_field_doc_comment.rs:62:
 struct MyStruct {
     /// Doc Comments
     /* TODO note to add more to Doc Comments */
+    /// Doc Comments
+    /* TODO note to add more to Doc Comments */
     pub a: u32,
+    /// Doc Comments
+    // TODO note
     /// Doc Comments
     // TODO note
     pub(crate) b: u64,
Mismatch at tests/source/unions.rs:4:
 /// A Doc comment
 #[AnAttribute]
 pub union Foo {
 pub union Foo {
-    #[rustfmt::skip]
     f :   SomeType, // Comment beside a field
-    f: SomeType, // Comment beside a field
+    f: SomeType,    // Comment beside a field
     // Comment on a field
+    // #[AnAttribute]
     #[AnAttribute]
     g: SomeOtherType,
     /// A doc comment on a field
Mismatch at tests/source/unions.rs:14:
+    /// A doc comment on a field
+    /// A doc comment on a field
     h: AThirdType,
     pub i: TypeForPublicField,

Mismatch at tests/source/unions.rs:25:
 // #1029
 union X {
 union X {
     // `x` is an important number.
+    // #[allow(unused)] // TODO: use
     #[allow(unused)] // TODO: use
 }

Mismatch at tests/source/unions.rs:91:
 }
 }
 
 union Palette {
+    /// A map of indices in the palette to a count of pixels in approximately that color
     /// A map of indices in the palette to a count of pixels in approximately
     foo: i32,

Mismatch at tests/source/unions.rs:100:
 // when the field had attributes
 // when the field had attributes
 union FieldsWithAttributes {
     // Pre Comment
-    #[rustfmt::skip] pub host:String, /* Post comment BBBBBBBBBBBBBB BBBBBBBBBBBBBBBB
-                                       * BBBBBBBBBBBBBBBB BBBBBBBBBBBBBBBBB BBBBBBBBBBB */
+    // #[rustfmt::skip]
+    pub host:String, /* Post comment BBBBBBBBBBBBBB BBBBBBBBBBBBBBBB BBBBBBBBBBBBBBBB
+                      * BBBBBBBBBBBBBBBBB BBBBBBBBBBB */
     // Another pre comment
+    // #[attr1]
+    // #[attr2]
     #[attr1]
     #[attr2]
     pub id: usize, /* CCCCCCCCCCCCCCCCCCC CCCCCCCCCCCCCCCCCCC CCCCCCCCCCCCCCCC
Mismatch at tests/source/issue_5686.rs:34:
Mismatch at tests/source/issue_5686.rs:34:
     #[hell{world}]
     Cobra {/* struct variant close in leading attribute */} = 6,
     Eagle {
-        /* struct variant closer on associated field attribute */
+        /* struct variant closer on associated field attribute */ #[hell{world}]
         #[hell{world}]
         value: Sting,
     } = 7,
Mismatch at tests/source/enum.rs:42:
     StructLike {
         x: i32, // Test comment
         // Pre-comment
         // Pre-comment
+        //#[Attr50]
         #[Attr50]
         y: SomeType, // Another Comment

Mismatch at tests/target/unions.rs:4:
 /// A Doc comment
 #[AnAttribute]
 #[AnAttribute]
 pub union Foo {
-    #[rustfmt::skip]
     f :   SomeType, // Comment beside a field
-    f: SomeType, // Comment beside a field
+    f: SomeType,    // Comment beside a field
     // Comment on a field
+    // #[AnAttribute]
     #[AnAttribute]
     g: SomeOtherType,
     /// A doc comment on a field
Mismatch at tests/target/unions.rs:14:
+    /// A doc comment on a field
+    /// A doc comment on a field
     h: AThirdType,
     pub i: TypeForPublicField,

Mismatch at tests/target/unions.rs:25:
 // #1029
 union X {
 union X {
     // `x` is an important number.
+    // #[allow(unused)] // TODO: use
     #[allow(unused)] // TODO: use
 }

Mismatch at tests/target/unions.rs:93:
 union Palette {
 union Palette {
     /// A map of indices in the palette to a count of pixels in approximately
     /// that color
+    /// A map of indices in the palette to a count of pixels in approximately
     foo: i32,
 }
 


Mismatch at tests/target/unions.rs:100:
 // when the field had attributes
 union FieldsWithAttributes {
     // Pre Comment
-    #[rustfmt::skip] pub host:String, /* Post comment BBBBBBBBBBBBBB BBBBBBBBBBBBBBBB
-                                       * BBBBBBBBBBBBBBBB BBBBBBBBBBBBBBBBB BBBBBBBBBBB */
+    // #[rustfmt::skip]
+    pub host:String, /* Post comment BBBBBBBBBBBBBB BBBBBBBBBBBBBBBB
+                      * BBBBBBBBBBBBBBBB BBBBBBBBBBBBBBBBB BBBBBBBBBBB */
     // Another pre comment
+    // #[attr1]
+    // #[attr2]
     #[attr1]
     #[attr2]
     pub id: usize, /* CCCCCCCCCCCCCCCCCCC CCCCCCCCCCCCCCCCCCC CCCCCCCCCCCCCCCC
Mismatch at tests/source/multiple.rs:103:
 /// A Doc comment
 #[AnAttribute]
 pub struct Foo {
 pub struct Foo {
-    #[rustfmt::skip]
     f :   SomeType, // Comment beside a field
-    f: SomeType, // Comment beside a field
+    f: SomeType,    // Comment beside a field
     // Comment on a field
     g: SomeOtherType,
+    /// A doc comment on a field
     /// A doc comment on a field
     h: AThirdType,

Mismatch at tests/source/doc-attrib.rs:43:
     b: i32,
 
 
     // regular item comment
+    //#[doc = " item doc attrib comment"]
     /// item doc attrib comment
     c: i32,
 }
{ "type": "test", "name": "test::system_tests", "event": "failed", "stdout": "\u001b[2m2024-01-31T13:34:23.873252Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value One used explicitly for version\n\u001b[2m2024-01-31T13:34:23.876011Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for force_multiline_blocks\n\u001b[2m2024-01-31T13:34:23.877670Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for error_on_line_overflow\n\u001b[2m2024-01-31T13:34:23.877675Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for format_strings\n\u001b[2m2024-01-31T13:34:23.878935Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for format_macro_matchers\n\u001b[2m2024-01-31T13:34:23.880809Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for match_block_trailing_comma\n\u001b[2m2024-01-31T13:34:23.882025Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for use_field_init_shorthand\n\u001b[2m2024-01-31T13:34:23.883280Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value true used explicitly for merge_derives\n\u001b[2m2024-01-31T13:34:23.884470Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value true used explicitly for force_explicit_abi\n\u001b[2m2024-01-31T13:34:23.885541Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for error_on_line_overflow\n\u001b[2m2024-01-31T13:34:23.885545Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for wrap_comments\n\u001b[2m2024-01-31T13:34:23.886727Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for error_on_line_overflow\n\u001b[2m2024-01-31T13:34:23.887278Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for spaces_around_ranges\n\u001b[2m2024-01-31T13:34:23.889392Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value true used explicitly for match_arm_blocks\n\u001b[2m2024-01-31T13:34:23.891308Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Vertical used explicitly for trailing_comma\n\u001b[2m2024-01-31T13:34:23.891886Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for reorder_impl_items\n\u001b[2m2024-01-31T13:34:23.893606Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value true used explicitly for format_macro_bodies\n\u001b[2m2024-01-31T13:34:23.894504Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value 50 used explicitly for single_line_let_else_max_width\n\u001b[2m2024-01-31T13:34:23.898390Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Tall used explicitly for fn_params_layout\n\u001b[2m2024-01-31T13:34:23.899635Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for hard_tabs\n\u001b[2m2024-01-31T13:34:23.900724Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value true used explicitly for remove_nested_parens\n\u001b[2m2024-01-31T13:34:23.902482Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value AlwaysSameLine used explicitly for control_brace_style\n\u001b[2m2024-01-31T13:34:23.903079Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for use_try_shorthand\n\u001b[2m2024-01-31T13:34:23.904791Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value true used explicitly for reorder_imports\n\u001b[2m2024-01-31T13:34:23.905367Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for normalize_comments\n\u001b[2m2024-01-31T13:34:23.906462Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Block used explicitly for imports_indent\n\u001b[2m2024-01-31T13:34:23.906467Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Mixed used explicitly for imports_layout\n\u001b[2m2024-01-31T13:34:23.908252Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Block used explicitly for indent_style\n\u001b[2m2024-01-31T13:34:23.908999Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for error_on_line_overflow\n\u001b[2m2024-01-31T13:34:23.909569Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Block used explicitly for indent_style\n\u001b[2m2024-01-31T13:34:23.911312Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Block used explicitly for indent_style\n\u001b[2m2024-01-31T13:34:23.913081Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value One used explicitly for version\n\u001b[2m2024-01-31T13:34:23.913086Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for error_on_line_overflow\n\u001b[2m2024-01-31T13:34:23.913088Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Block used explicitly for indent_style\n\u001b[2m2024-01-31T13:34:23.913690Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for error_on_line_overflow\n\u001b[2m2024-01-31T13:34:23.913694Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Block used explicitly for indent_style\n\u001b[2m2024-01-31T13:34:23.914272Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Block used explicitly for indent_style\n\u001b[2m2024-01-31T13:34:23.915482Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Block used explicitly for indent_style\n\u001b[2m2024-01-31T13:34:23.917661Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Block used explicitly for indent_style\n\u001b[2m2024-01-31T13:34:23.918255Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Block used explicitly for indent_style\n\u001b[2m2024-01-31T13:34:23.920637Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Block used explicitly for indent_style\n\u001b[2m2024-01-31T13:34:23.921755Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value true used explicitly for empty_item_single_line\n\u001b[2m2024-01-31T13:34:23.923921Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value true used explicitly for format_generated_files\n\u001b[2m2024-01-31T13:34:23.925984Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Never used explicitly for match_arm_leading_pipes\n\u001b[2m2024-01-31T13:34:23.930401Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value SameLineWhere used explicitly for brace_style\n\u001b[2m2024-01-31T13:34:23.931525Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value SameLineWhere used explicitly for brace_style\n\u001b[2m2024-01-31T13:34:23.932100Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for normalize_doc_attributes\n\u001b[2m2024-01-31T13:34:23.933283Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for disable_all_formatting\n\u001b[2m2024-01-31T13:34:23.934257Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for fn_single_line\n\u001b[2m2024-01-31T13:34:23.936016Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Block used explicitly for indent_style\n\u001b[2m2024-01-31T13:34:23.936626Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value 4 used explicitly for tab_spaces\n\u001b[2m2024-01-31T13:34:23.936630Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Block used explicitly for indent_style\n\u001b[2m2024-01-31T13:34:23.943231Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Default used explicitly for use_small_heuristics\n\u001b[2m2024-01-31T13:34:23.944890Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for error_on_line_overflow\n\u001b[2m2024-01-31T13:34:23.948134Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for condense_wildcard_suffixes\n\u001b[2m2024-01-31T13:34:23.951637Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value true used explicitly for reorder_modules\n\u001b[2m2024-01-31T13:34:23.952248Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value 10 used explicitly for short_array_element_width_threshold\n\u001b[2m2024-01-31T13:34:23.954051Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for wrap_comments\n\u001b[2m2024-01-31T13:34:23.955182Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value 80 used explicitly for comment_width\n\u001b[2m2024-01-31T13:34:23.956430Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Wide used explicitly for type_punctuation_density\n\u001b[2m2024-01-31T13:34:23.957950Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value 100 used explicitly for doc_comment_code_block_width\n\u001b[2m2024-01-31T13:34:23.958889Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value 100 used explicitly for doc_comment_code_block_width\n\u001b[2m2024-01-31T13:34:23.960421Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value One used explicitly for version\n\u001b[2m2024-01-31T13:34:23.968252Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value true used explicitly for reorder_imports\n\u001b[2m2024-01-31T13:34:23.974402Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value One used explicitly for version\n\u001b[2m2024-01-31T13:34:23.989330Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value 2015 used explicitly for edition\n\u001b[2m2024-01-31T13:34:24.021546Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value One used explicitly for version\n\u001b[2m2024-01-31T13:34:24.037160Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Block used explicitly for indent_style\n\u001b[2m2024-01-31T13:34:24.037164Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Block used explicitly for imports_indent\n\u001b[2m2024-01-31T13:34:24.038253Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value One used explicitly for version\n\u001b[2m2024-01-31T13:34:24.049361Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value true used explicitly for reorder_imports\n\u001b[2m2024-01-31T13:34:24.056652Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value One used explicitly for version\nWarning: the `merge_imports` option is deprecated. Use `imports_granularity=\"Crate\"` instead\n\u001b[2m2024-01-31T13:34:24.082968Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for wrap_comments\n\u001b[2m2024-01-31T13:34:24.089798Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value One used explicitly for version\n\u001b[2m2024-01-31T13:34:24.166010Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value [] used explicitly for skip_macro_invocations\n\u001b[2m2024-01-31T13:34:24.212104Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value One used explicitly for version\n\u001b[2m2024-01-31T13:34:24.215217Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value One used explicitly for version\n\u001b[2m2024-01-31T13:34:24.222497Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for error_on_line_overflow\n\u001b[2m2024-01-31T13:34:24.222502Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value One used explicitly for version\n\u001b[2m2024-01-31T13:34:24.224555Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for error_on_line_overflow\n\u001b[2m2024-01-31T13:34:24.261981Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value One used explicitly for version\n\u001b[2m2024-01-31T13:34:24.275862Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value true used explicitly for reorder_modules\n\u001b[2m2024-01-31T13:34:24.327026Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value true used explicitly for reorder_imports\n\u001b[2m2024-01-31T13:34:24.333167Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value true used explicitly for merge_derives\nWarning: the `fn_args_layout` option is deprecated. Use `fn_params_layout`. instead\n\u001b[2m2024-01-31T13:34:24.370437Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value One used explicitly for version\n\u001b[2m2024-01-31T13:34:24.379832Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value One used explicitly for version\n\u001b[2m2024-01-31T13:34:24.430788Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value true used explicitly for format_macro_bodies\nRan 588 system tests.\nthread '<unnamed>' panicked at src/tools/rustfmt/src/test/mod.rs:189:9:\nassertion `left == right` failed: 8 system tests failed\n  left: 8\n right: 0\nthread 'test::system_tests' panicked at src/tools/rustfmt/src/test/mod.rs:76:10:\nFailed to join a test thread: Any { .. }\n" }
Mismatch at tests/target/issue_5686.rs:36:
     Eagle {
         /* struct variant closer on associated field attribute */
         /* struct variant closer on associated field attribute */
         #[hell{world}]
+        #[hell{world}]
         value: Sting,
     } = 7,
     Koala {/* struct variant closer on macro call */} = some_macro! {},
Mismatch at tests/target/enum.rs:42:
     StructLike {
         x: i32, // Test comment
         // Pre-comment
         // Pre-comment
+        //#[Attr50]
         #[Attr50]
         y: SomeType, // Another Comment

Mismatch at tests/target/multiple.rs:103:
 /// A Doc comment
 #[AnAttribute]
 #[AnAttribute]
 pub struct Foo {
-    #[rustfmt::skip]
     f :   SomeType, // Comment beside a field
-    f: SomeType, // Comment beside a field
+    f: SomeType,    // Comment beside a field
     // Comment on a field
     g: SomeOtherType,
+    /// A doc comment on a field
     /// A doc comment on a field
     h: AThirdType,

Mismatch at tests/target/doc-attrib.rs:15:
Mismatch at tests/target/doc-attrib.rs:15:
 // Long `#[doc = "..."]`
 struct A {
     /// xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
+    /// xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
     b: i32,
 

Mismatch at tests/target/doc-attrib.rs:40:
 struct C {
---
 

Mismatch at tests/target/doc-attrib.rs:109:
 #[derive(Debug, Default, Copy, Clone)]
 pub struct ContradictAccessors {
     ///<foo>no leading spaces here</foo>
+    ///<foo>no leading spaces here</foo>
     pub mBothAccessors: ::std::os::raw::c_int,
     /// <div rustbindgen accessor="false"></div>
+    /// <div rustbindgen accessor="false"></div>
     pub mNoAccessors: ::std::os::raw::c_int,
     /// <div rustbindgen accessor="unsafe"></div>
+    /// <div rustbindgen accessor="unsafe"></div>
     pub mUnsafeAccessors: ::std::os::raw::c_int,
     /// <div rustbindgen accessor="immutable"></div>
+    /// <div rustbindgen accessor="immutable"></div>
     pub mImmutableAccessor: ::std::os::raw::c_int,
 

Mismatch at tests/target/doc-attrib.rs:123:
 #[derive(Debug, Copy, Clone)]
 #[derive(Debug, Copy, Clone)]
 pub struct mbedtls_mpi {
     ///<  integer sign
+    ///<  integer sign
     pub s: ::std::os::raw::c_int,
     ///<  total # of limbs
+    ///<  total # of limbs
     pub n: ::std::os::raw::c_ulong,
+    ///<  pointer to limbs
     ///<  pointer to limbs
     pub p: *mut mbedtls_mpi_uint,
 }
{ "type": "test", "name": "test::idempotence_tests", "event": "failed", "stdout": "\u001b[2m2024-01-31T13:34:23.877108Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value One used explicitly for version\n\u001b[2m2024-01-31T13:34:23.880488Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for force_multiline_blocks\n\u001b[2m2024-01-31T13:34:23.881957Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for error_on_line_overflow\n\u001b[2m2024-01-31T13:34:23.881963Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for format_strings\n\u001b[2m2024-01-31T13:34:23.883193Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for format_macro_matchers\n\u001b[2m2024-01-31T13:34:23.884971Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for match_block_trailing_comma\n\u001b[2m2024-01-31T13:34:23.886155Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for use_field_init_shorthand\n\u001b[2m2024-01-31T13:34:23.887380Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value true used explicitly for merge_derives\n\u001b[2m2024-01-31T13:34:23.888043Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Block used explicitly for imports_indent\n\u001b[2m2024-01-31T13:34:23.889142Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value true used explicitly for force_explicit_abi\n\u001b[2m2024-01-31T13:34:23.890210Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for error_on_line_overflow\n\u001b[2m2024-01-31T13:34:23.890213Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for wrap_comments\n\u001b[2m2024-01-31T13:34:23.891306Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for error_on_line_overflow\n\u001b[2m2024-01-31T13:34:23.891851Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for spaces_around_ranges\n\u001b[2m2024-01-31T13:34:23.893907Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value true used explicitly for match_arm_blocks\n\u001b[2m2024-01-31T13:34:23.895793Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Vertical used explicitly for trailing_comma\n\u001b[2m2024-01-31T13:34:23.896375Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for reorder_impl_items\n\u001b[2m2024-01-31T13:34:23.898094Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value true used explicitly for format_macro_bodies\n\u001b[2m2024-01-31T13:34:23.899004Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value 50 used explicitly for single_line_let_else_max_width\n\u001b[2m2024-01-31T13:34:23.902741Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Tall used explicitly for fn_params_layout\n\u001b[2m2024-01-31T13:34:23.904005Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for hard_tabs\n\u001b[2m2024-01-31T13:34:23.905763Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value true used explicitly for trailing_semicolon\n\u001b[2m2024-01-31T13:34:23.906413Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value true used explicitly for remove_nested_parens\n\u001b[2m2024-01-31T13:34:23.908150Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value AlwaysSameLine used explicitly for control_brace_style\n\u001b[2m2024-01-31T13:34:23.908775Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for use_try_shorthand\n\u001b[2m2024-01-31T13:34:23.910463Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value true used explicitly for reorder_imports\n\u001b[2m2024-01-31T13:34:23.911037Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for normalize_comments\n\u001b[2m2024-01-31T13:34:23.912138Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Mixed used explicitly for imports_layout\n\u001b[2m2024-01-31T13:34:23.912141Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Block used explicitly for imports_indent\n\u001b[2m2024-01-31T13:34:23.912804Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Block used explicitly for imports_indent\n\u001b[2m2024-01-31T13:34:23.913395Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Block used explicitly for imports_indent\n\u001b[2m2024-01-31T13:34:23.913399Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Mixed used explicitly for imports_layout\n\u001b[2m2024-01-31T13:34:23.914005Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Block used explicitly for indent_style\n\u001b[2m2024-01-31T13:34:23.915046Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Block used explicitly for indent_style\n\u001b[2m2024-01-31T13:34:23.915050Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value true used explicitly for combine_control_expr\n\u001b[2m2024-01-31T13:34:23.917288Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Block used explicitly for indent_style\n\u001b[2m2024-01-31T13:34:23.917967Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for error_on_line_overflow\n\u001b[2m2024-01-31T13:34:23.918522Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Block used explicitly for indent_style\n\u001b[2m2024-01-31T13:34:23.920267Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Block used explicitly for indent_style\n\u001b[2m2024-01-31T13:34:23.922061Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value One used explicitly for version\n\u001b[2m2024-01-31T13:34:23.922065Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Block used explicitly for indent_style\n\u001b[2m2024-01-31T13:34:23.922068Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for error_on_line_overflow\n\u001b[2m2024-01-31T13:34:23.922670Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for error_on_line_overflow\n\u001b[2m2024-01-31T13:34:23.922674Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Block used explicitly for indent_style\n\u001b[2m2024-01-31T13:34:23.923247Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Block used explicitly for indent_style\n\u001b[2m2024-01-31T13:34:23.924462Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Block used explicitly for indent_style\n\u001b[2m2024-01-31T13:34:23.926397Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Block used explicitly for indent_style\n\u001b[2m2024-01-31T13:34:23.926972Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Block used explicitly for indent_style\n\u001b[2m2024-01-31T13:34:23.927543Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Block used explicitly for indent_style\n\u001b[2m2024-01-31T13:34:23.930501Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Block used explicitly for indent_style\n\u001b[2m2024-01-31T13:34:23.931096Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Block used explicitly for indent_style\n\u001b[2m2024-01-31T13:34:23.932193Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value true used explicitly for empty_item_single_line\n\u001b[2m2024-01-31T13:34:23.934413Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value true used explicitly for format_generated_files\n\u001b[2m2024-01-31T13:34:23.936348Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Never used explicitly for match_arm_leading_pipes\n\u001b[2m2024-01-31T13:34:23.940810Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value SameLineWhere used explicitly for brace_style\n\u001b[2m2024-01-31T13:34:23.941956Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value SameLineWhere used explicitly for brace_style\n\u001b[2m2024-01-31T13:34:23.942539Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for normalize_doc_attributes\n\u001b[2m2024-01-31T13:34:23.943637Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for disable_all_formatting\n\u001b[2m2024-01-31T13:34:23.944580Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for fn_single_line\n\u001b[2m2024-01-31T13:34:23.945727Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value SameLineWhere used explicitly for brace_style\n\u001b[2m2024-01-31T13:34:23.946986Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Block used explicitly for indent_style\n\u001b[2m2024-01-31T13:34:23.947598Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value 4 used explicitly for tab_spaces\n\u001b[2m2024-01-31T13:34:23.947602Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Block used explicitly for indent_style\n\u001b[2m2024-01-31T13:34:23.954295Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Default used explicitly for use_small_heuristics\n\u001b[2m2024-01-31T13:34:23.955897Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for error_on_line_overflow\n\u001b[2m2024-01-31T13:34:23.958649Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for error_on_unformatted\n\u001b[2m2024-01-31T13:34:23.959290Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for condense_wildcard_suffixes\n\u001b[2m2024-01-31T13:34:23.962756Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value true used explicitly for reorder_modules\n\u001b[2m2024-01-31T13:34:23.963351Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value 10 used explicitly for short_array_element_width_threshold\n\u001b[2m2024-01-31T13:34:23.965115Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for wrap_comments\n\u001b[2m2024-01-31T13:34:23.966169Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value 80 used explicitly for comment_width\n\u001b[2m2024-01-31T13:34:23.967388Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Wide used explicitly for type_punctuation_density\n\u001b[2m2024-01-31T13:34:23.968885Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value 100 used explicitly for doc_comment_code_block_width\n\u001b[2m2024-01-31T13:34:23.969671Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value 100 used explicitly for doc_comment_code_block_width\n\u001b[2m2024-01-31T13:34:23.972810Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value One used explicitly for version\n\u001b[2m2024-01-31T13:34:23.982737Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value true used explicitly for reorder_imports\n\u001b[2m2024-01-31T13:34:23.990858Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value One used explicitly for version\n\u001b[2m2024-01-31T13:34:24.006599Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value 2015 used explicitly for edition\n\u001b[2m2024-01-31T13:34:24.010360Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for format_macro_matchers\n\u001b[2m2024-01-31T13:34:24.050731Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value One used explicitly for version\n\u001b[2m2024-01-31T13:34:24.070641Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value 0 used explicitly for struct_field_align_threshold\n\u001b[2m2024-01-31T13:34:24.071849Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value SameLineWhere used explicitly for brace_style\n\u001b[2m2024-01-31T13:34:24.071855Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value 100 used explicitly for max_width\n\u001b[2m2024-01-31T13:34:24.071857Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value 4 used explicitly for tab_spaces\n\u001b[2m2024-01-31T13:34:24.071859Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value true used explicitly for reorder_modules\n\u001b[2m2024-01-31T13:34:24.071860Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for hard_tabs\n\u001b[2m2024-01-31T13:34:24.075794Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Block used explicitly for imports_indent\n\u001b[2m2024-01-31T13:34:24.075798Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Block used explicitly for indent_style\n\u001b[2m2024-01-31T13:34:24.076961Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value One used explicitly for version\n\u001b[2m2024-01-31T13:34:24.079318Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for wrap_comments\n\u001b[2m2024-01-31T13:34:24.080821Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for wrap_comments\n\u001b[2m2024-01-31T13:34:24.081368Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for wrap_comments\n\u001b[2m2024-01-31T13:34:24.082910Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for wrap_comments\n\u001b[2m2024-01-31T13:34:24.083461Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for wrap_comments\n\u001b[2m2024-01-31T13:34:24.083961Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for wrap_comments\n\u001b[2m2024-01-31T13:34:24.088003Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for wrap_comments\n\u001b[2m2024-01-31T13:34:24.097119Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value true used explicitly for reorder_imports\n\u001b[2m2024-01-31T13:34:24.106011Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value One used explicitly for version\nWarning: the `merge_imports` option is deprecated. Use `imports_granularity=\"Crate\"` instead\n\u001b[2m2024-01-31T13:34:24.139498Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for wrap_comments\n\u001b[2m2024-01-31T13:34:24.148090Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value One used explicitly for version\n\u001b[2m2024-01-31T13:34:24.237596Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value [] used explicitly for skip_macro_invocations\n\u001b[2m2024-01-31T13:34:24.243590Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value One used explicitly for version\n\u001b[2m2024-01-31T13:34:24.295328Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value One used explicitly for version\n\u001b[2m2024-01-31T13:34:24.298389Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value One used explicitly for version\n\u001b[2m2024-01-31T13:34:24.304203Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value One used explicitly for version\n\u001b[2m2024-01-31T13:34:24.304208Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for error_on_line_overflow\n\u001b[2m2024-01-31T13:34:24.305579Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for error_on_line_overflow\n\u001b[2m2024-01-31T13:34:24.334402Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value One used explicitly for version\n\u001b[2m2024-01-31T13:34:24.347960Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value One used explicitly for version\n\u001b[2m2024-01-31T13:34:24.361529Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value true used explicitly for reorder_modules\n\u001b[2m2024-01-31T13:34:24.417985Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value true used explicitly for format_macro_bodies\n\u001b[2m2024-01-31T13:34:24.424035Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value true used explicitly for reorder_imports\n\u001b[2m2024-01-31T13:34:24.431659Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value true used explicitly for merge_derives\n\u001b[2m2024-01-31T13:34:24.435995Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value Preserve used explicitly for hex_literal_case\nWarning: the `fn_args_layout` option is deprecated. Use `fn_params_layout`. instead\n\u001b[2m2024-01-31T13:34:24.484506Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value One used explicitly for version\n\u001b[2m2024-01-31T13:34:24.494121Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value One used explicitly for version\n\u001b[2m2024-01-31T13:34:24.503080Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value false used explicitly for wrap_comments\n\u001b[2m2024-01-31T13:34:24.546748Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mrustfmt_nightly::test\u001b[0m\u001b[2m:\u001b[0m Default value true used explicitly for format_macro_bodies\nRan 798 idempotent tests.\nthread '<unnamed>' panicked at src/tools/rustfmt/src/test/mod.rs:369:9:\nassertion `left == right` failed: 9 idempotent tests failed\n  left: 9\n right: 0\nthread 'test::idempotence_tests' panicked at src/tools/rustfmt/src/test/mod.rs:76:10:\nFailed to join a test thread: Any { .. }\n" }
error: test failed, to rerun pass `--lib`


test result: FAILED. 169 passed; 3 failed; 0 ignored; 0 measured; 0 filtered out; finished in 722.04ms

oli-obk · 2024-01-31T14:03:25Z

@bors try @rust-timer queue

rustc_ast: FieldDef: remove span it can be calculated from Visibility + Ty, at least tests passed? perf me, please

bors · 2024-01-31T14:04:38Z

⌛ Trying commit bf5d6ae with merge d9df9c5...

bors · 2024-01-31T15:33:30Z

☀️ Try build successful - checks-actions
Build commit: d9df9c5 (d9df9c55666c9066dbed6f5fe143c672c44a5e8f)

rust-timer · 2024-01-31T16:47:50Z

Finished benchmarking commit (d9df9c5): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	9.6%	[2.4%, 15.0%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	9.6%	[2.4%, 15.0%]	3

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.7%	[2.1%, 6.1%]	5
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.1%	[-3.1%, -3.1%]	1
All ❌✅ (primary)	3.7%	[2.1%, 6.1%]	5

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	11.8%	[3.2%, 18.4%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	11.8%	[3.2%, 18.4%]	3

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.0%	[0.0%, 0.1%]	5
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.0%	[0.0%, 0.1%]	5

Bootstrap: 661.871s -> 662.153s (0.04%)
Artifact size: 308.09 MiB -> 308.09 MiB (0.00%)

nnethercote · 2024-01-31T22:21:51Z

It would be good to squash the commits before this merges.

compiler-errors · 2024-02-05T20:55:57Z

@rustbot author

rustc_ast: FieldDef: remove span

5fe6b65

it can be calculated from Visibility + Ty

rustbot assigned oli-obk Jan 31, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 31, 2024

This comment has been minimized.

Sign in to view

klensy added 2 commits January 31, 2024 16:10

clippy fix

4dd28ed

rustfmt: fix

bf5d6ae

klensy marked this pull request as draft January 31, 2024 14:03

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 31, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 31, 2024

Auto merge of rust-lang#120525 - klensy:FieldDef-span, r=<try>

d9df9c5

rustc_ast: FieldDef: remove span it can be calculated from Visibility + Ty, at least tests passed? perf me, please

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jan 31, 2024

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rustc_ast: FieldDef: remove span #120525

rustc_ast: FieldDef: remove span #120525

klensy commented Jan 31, 2024

rustbot commented Jan 31, 2024

rustbot commented Jan 31, 2024

This comment has been minimized.

rustbot commented Jan 31, 2024

rust-log-analyzer commented Jan 31, 2024

oli-obk commented Jan 31, 2024

This comment has been minimized.

bors commented Jan 31, 2024

bors commented Jan 31, 2024

This comment has been minimized.

rust-timer commented Jan 31, 2024

nnethercote commented Jan 31, 2024

compiler-errors commented Feb 5, 2024

rustc_ast: FieldDef: remove span #120525

Are you sure you want to change the base?

rustc_ast: FieldDef: remove span #120525

Conversation

klensy commented Jan 31, 2024

rustbot commented Jan 31, 2024

rustbot commented Jan 31, 2024

This comment has been minimized.

rustbot commented Jan 31, 2024

rust-log-analyzer commented Jan 31, 2024

oli-obk commented Jan 31, 2024

This comment has been minimized.

bors commented Jan 31, 2024

bors commented Jan 31, 2024

This comment has been minimized.

rust-timer commented Jan 31, 2024

Overall result: ❌ regressions - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

Binary size

nnethercote commented Jan 31, 2024

compiler-errors commented Feb 5, 2024