Commits on Feb 11, 2024

1. Reorder the diagnostic API methods. …

   The current order is almost perfectly random. This commit puts them into
   a predictable order in their own impl block, going from the highest
   level (`Block`) to the lowest (`Expect`). Within each level this is the
   order:
   
   - struct_err, err
   - struct_span_err, span_err
   - create_err, emit_err
   
   The first one in each pair creates a diagnostic, the second one creates
   *and* emits a diagnostic. Not every method is present for every level.
   
   The diff is messy, but other than moving methods around, the only thing
   it does is create the new `impl DiagCtxt` block with its own comment.

   

   nnethercote committed Feb 11, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for c35983a
   • Browse repository at this point

   Copy the full SHA

   c35983a View commit details

   Browse the repository at this point in the history

2. Fix inconsistencies in the diagnostic API methods. …

   - Remove low-value comments about functionality that is obvious.
   
   - Add missing `track_caller` attributes -- every method should have one.
   
   - Adjust `rustc_lint_diagnostic` attributes. Every method involving a
     `impl Into<DiagnosticMessage>` or `impl Into<SubdiangnosticMessage>`
     argument should have one, except for those producing bugs, which
     aren't user-facing.

   

   nnethercote committed Feb 11, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for b7b6ebc
   • Browse repository at this point

   Copy the full SHA

   b7b6ebc View commit details

   Browse the repository at this point in the history