better error message on download CI LLVM failure #120790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @Mark-Simulacrum. Use r? to explicitly pick a reviewer |
rustbot
added
S-waiting-on-review
wesleywiser
reviewed
Feb 8, 2024
src/bootstrap/src/core/download.rs
Outdated
| HELP: There could be two reasons behind this: | ||
| 1) The host triple is not supported for `download-ci-llvm`. | ||
| 2) Old builds get deleted after a certain time. | ||
| HELP: If trying to compile an old commit of rustc, rebase to recent commits. If you still get this error, your host triple most likely isn't supported for CI LLVM. Therefore, disable it in config.toml: |
There was a problem hiding this comment.
If trying to compile an old commit of rustc, rebase to recent commits
I'm not sure I understand the suggestion here. If you're trying to compile an old commit, it's likely you have a specific reason for doing so and rebasing onto a more recent commit would not appropriate? I think I'm missing the context where this suggestion applies.
There was a problem hiding this comment.
If you're trying to compile an old commit, it's likely you have a specific reason for doing so
Not always I think (some people/orgs may have quite outdated forks with no purpose). But I see your point. I will change the suggestion.
onur-ozkan
force-pushed
the
better-error-message
branch
from
790876f
to
132b0a1
Compare
Signed-off-by: onur-ozkan <work@onurozkan.dev>
onur-ozkan
force-pushed
the
better-error-message
branch
from
132b0a1
to
8801144
Compare
wesleywiser
approved these changes
Feb 9, 2024
|
Thanks @onur-ozkan! @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 9, 2024
…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#120351 (Implement SystemTime for UEFI) - rust-lang#120354 (improve normalization of `Pointee::Metadata`) - rust-lang#120776 (Move path implementations into `sys`) - rust-lang#120790 (better error message on download CI LLVM failure) - rust-lang#120806 (Clippy subtree update) - rust-lang#120815 (Improve `Option::inspect` docs) - rust-lang#120822 (Emit more specific diagnostics when enums fail to cast with `as`) - rust-lang#120827 (Print image input file and checksum in CI only) - rust-lang#120836 (hide impls if trait bound is proven from env) - rust-lang#120844 (Build DebugInfo for async closures) - rust-lang#120851 (Remove duplicate release note) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 9, 2024
…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#120351 (Implement SystemTime for UEFI) - rust-lang#120354 (improve normalization of `Pointee::Metadata`) - rust-lang#120776 (Move path implementations into `sys`) - rust-lang#120790 (better error message on download CI LLVM failure) - rust-lang#120806 (Clippy subtree update) - rust-lang#120815 (Improve `Option::inspect` docs) - rust-lang#120822 (Emit more specific diagnostics when enums fail to cast with `as`) - rust-lang#120827 (Print image input file and checksum in CI only) - rust-lang#120836 (hide impls if trait bound is proven from env) - rust-lang#120844 (Build DebugInfo for async closures) - rust-lang#120851 (Remove duplicate release note) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 9, 2024
Rollup merge of rust-lang#120790 - onur-ozkan:better-error-message, r=wesleywiser better error message on download CI LLVM failure self-explanatory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
self-explanatory