[beta] backports #121069
Merged
[beta] backports #121069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the library paths to correctly refer to libdemo{1,2}_hexagon
and switch to the release build instead.
Update references to libstandalone to the specific G0/PIC archive instead.
(cherry picked from commit 647a453)
(cherry picked from commit 2aebe6c)
(cherry picked from commit 2c0030f)
(cherry picked from commit 0f21e45)
(cherry picked from commit 6ac035d)
|
rustbot
added
A-testsuite
rustbot
added
the
T-bootstrap
|
@bors r+ rollup=never |
bors
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
|
@bors r+ |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 14, 2024
[beta] backports - Correct paths for hexagon-unknown-none-elf platform doc rust-lang#120533 - CI: Use ninja on apple builders rust-lang#120543 - Correctly check `never_type` feature gating rust-lang#120552 - Revert unsound libcore changes of 119911 rust-lang#120562 r? cuviper
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry |
bors
removed
the
S-waiting-on-review
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
Looks like we need #120914 too! |
This seems to fix two sporadic errors that have been appearing in CI. One is an issue with cmake being unable to verify that cmake is able to build a simple test program. The other is a `invalid r_symbolnum` linking error when trying to build one of cranelift's tests. This is intended as a temporary fix until we can figure out how to resolve those issues. (cherry picked from commit 4fd3cf9)
Allowing the Xcode version to "float" based on whatever default GitHub selects creates an unreliable environment. When GitHub changes the default, we can have multiple jobs in the same run using different versions as it rolls out across machines. It can also cause oscillation between runs as different machines are used. It also causes unpredictable timing when the updates happen. This change helps ensure that the version that is used is pinned. The downside is that it requires manually bumping the version, and the risk that if we take too long, older Xcodes will be removed and that will break the build. (cherry picked from commit 4ce1f1c)
Merged
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 15, 2024
[beta] backports - Correct paths for hexagon-unknown-none-elf platform doc rust-lang#120533 - CI: Use ninja on apple builders rust-lang#120543 - Correctly check `never_type` feature gating rust-lang#120552 - Revert unsound libcore changes of 119911 rust-lang#120562 - Downgrade xcode rust-lang#120914 r? cuviper
|
💥 Test timed out |
bors
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
@bors r+ |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
never_typefeature gating Correctly checknever_typefeature gating #120552r? cuviper