Rollup of 6 pull requests #121086
Merged
Rollup of 6 pull requests #121086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead of just `tcx.at(span).create_def`
Move some tests r? `@petrochenkov`
…ve, r=pnkfelix Remove importing suggestions when there is a shadowed typo candidate Fixes rust-lang#120559
… r=calebcartwright Format `async` trait bounds in rustfmt r? `@ytmimi` or `@calebcartwright` This PR opts to do formatting in the rust-lang/rust tree because otherwise we'd have to wait until a full sync, and rustfmt is currently totally removing the `async` keyword. cc rust-lang/rustfmt#6070
…range, r=oli-obk Fix false positive with if let and ranges Fixes rust-lang#121070
…kind, r=compiler-errors Extend documentation for `Ty::to_opt_closure_kind` method This API was... surprising to use. With a little extra documentation, the weirdness can be reduced quite a lot. :) r? `@compiler-errors`
…=WaffleLapkin Make sure `tcx.create_def` also depends on the forever red node, instead of just `tcx.at(span).create_def` oversight from rust-lang#119136 Not actually an issue, because all uses of `tcx.create_def` were in the resolver, which is `eval_always`, but still good to harden against future uses of `create_def` cc `@petrochenkov` `@WaffleLapkin`
rustbot
added
A-testsuite
|
@bors r+ p=5 rollup=never |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 340bb19fea In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
asynctrait bounds in rustfmt #121035 (Formatasynctrait bounds in rustfmt)Ty::to_opt_closure_kindmethod #121083 (Extend documentation forTy::to_opt_closure_kindmethod)tcx.create_defalso depends on the forever red node, instead of justtcx.at(span).create_def#121084 (Make suretcx.create_defalso depends on the forever red node, instead of justtcx.at(span).create_def)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup