Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #121254

Closed
wants to merge 19 commits into from
Closed

Rollup of 6 pull requests #121254

wants to merge 19 commits into from

Commits on Jan 31, 2024

  1. Configuration menu
    Copy the full SHA
    d907a6b View commit details
    Browse the repository at this point in the history
  2. Add regression test for rust-lang#120471 to ensure that long crate na…

    …me are handled as expected on mobile
    GuillaumeGomez committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    5d29f5a View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. As Windows 10 requires certain features like CMPXCHG16B and a few oth…

    …ers and Rust plans to set Windows 10 as the minimum supported OS for target x86_64-pc-windows-msvc, I have added the cmpxchg16b and sse3 feature (as CPUs that meet the Windows 10 64-bit requirement also support SSE3. See https://walbourn.github.io/directxmath-sse3-and-ssse3/ )
    CKingX committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    d51e703 View commit details
    Browse the repository at this point in the history
  2. Update x86_64_pc_windows_msvc.rs

    Fixed a bug where adding CMPXCHG16B would fail due to different names in Rustc and LLVM
    CKingX committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    d6766e2 View commit details
    Browse the repository at this point in the history
  3. Update x86_64_pc_windows_msvc.rs

    As CMPXCHG16B is supported, I updated the max atomic width to 128-bits from 64-bits
    CKingX committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    fcb06f7 View commit details
    Browse the repository at this point in the history
  4. Update x86_64_uwp_windows_gnu.rs

    Updated x86_64-uwp-windows-gnu to use CMPXCHG16B and SSE3
    CKingX committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    abeac8f View commit details
    Browse the repository at this point in the history
  5. Possibly removed merge policy

    CKingX committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    1c6dda7 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Configuration menu
    Copy the full SHA
    376c7b9 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. Configuration menu
    Copy the full SHA
    131cc37 View commit details
    Browse the repository at this point in the history
  2. Detect when method call on argument could be removed to fulfill faile…

    …d trait bound
    
    When encountering
    
    ```rust
    struct Foo;
    struct Bar;
    impl From<Bar> for Foo {
        fn from(_: Bar) -> Self { Foo }
    }
    fn qux(_: impl From<Bar>) {}
    fn main() {
        qux(Bar.into());
    }
    ```
    
    Suggest removing `.into()`:
    
    ```
    error[E0283]: type annotations needed
     --> f100.rs:8:13
      |
    8 |     qux(Bar.into());
      |     ---     ^^^^
      |     |
      |     required by a bound introduced by this call
      |
      = note: cannot satisfy `_: From<Bar>`
    note: required by a bound in `qux`
     --> f100.rs:6:16
      |
    6 | fn qux(_: impl From<Bar>) {}
      |                ^^^^^^^^^ required by this bound in `qux`
    help: try using a fully qualified path to specify the expected types
      |
    8 |     qux(<Bar as Into<T>>::into(Bar));
      |         +++++++++++++++++++++++   ~
    help: consider removing this method call, as the receiver has type `Bar` and `Bar: From<Bar>` can be fulfilled
      |
    8 -     qux(Bar.into());
    8 +     qux(Bar);
      |
    ```
    
    Fix rust-lang#71252
    estebank committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    9b3fcf9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3a917cd View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2024

  1. add test to guard against inaccurate diagnostic

    Also replaces an incomplete test
    tshepang committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    e3859d2 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2024

  1. Improve wording of static_mut_ref

    Rename `static_mut_ref` lint to `static_mut_refs`.
    obeis committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    408eeae View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#116342 - c410-f3r:t3st3ss, r=Mark-Simulacrum

    Initiate the inner usage of `cfg_match` (Library)
    
    cc rust-lang#115585
    
    Continuation of rust-lang#116312
    CKingX committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    2a438a6 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#120526 - GuillaumeGomez:mobile-long-crate-n…

    …ame, r=notriddle
    
    rustdoc: Correctly handle long crate names on mobile
    
    Fixes rust-lang#120471.
    
    It now renders like this:
    
    ![image](https://github.com/rust-lang/rust/assets/3050060/065b4b8b-ba55-4163-a928-8d7bf735c111)
    
    r? ``@notriddle``
    CKingX committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    12af8a9 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#120820 - CKingX:cpu-base-minimum, r=petroch…

    …enkov
    
    Enable CMPXCHG16B, SSE3, SAHF/LAHF and 128-bit Atomics (in nightly) in Windows x64
    
    As Rust plans to set Windows 10 as the minimum supported OS for target x86_64-pc-windows-msvc, I have added the cmpxchg16b and sse3 feature. Windows 10 requires CMPXCHG16B, LAHF/SAHF, and PrefetchW as stated in the requirements [here](https://download.microsoft.com/download/c/1/5/c150e1ca-4a55-4a7e-94c5-bfc8c2e785c5/Windows%2010%20Minimum%20Hardware%20Requirements.pdf). Furthermore, CPUs that meet these requirements also have SSE3 ([see](https://walbourn.github.io/directxmath-sse3-and-ssse3/))
    CKingX committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    8aea4c3 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#121034 - obeis:improve-static-mut-ref, r=Ra…

    …lfJung
    
    Improve wording of `static_mut_ref`
    
    Close rust-lang#120964
    CKingX committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    c465cfa View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#121067 - tshepang:make-expand-translatable,…

    … r=fmease
    
    make "invalid fragment specifier" translatable
    CKingX committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    3aff0b0 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#121100 - estebank:issue-71252, r=compiler-e…

    …rrors
    
    Detect when method call on argument could be removed to fulfill failed trait bound
    
    When encountering
    
    ```rust
    struct Foo;
    struct Bar;
    impl From<Bar> for Foo {
        fn from(_: Bar) -> Self { Foo }
    }
    fn qux(_: impl From<Bar>) {}
    fn main() {
        qux(Bar.into());
    }
    ```
    
    Suggest removing `.into()`:
    
    ```
    error[E0283]: type annotations needed
     --> f100.rs:8:13
      |
    8 |     qux(Bar.into());
      |     ---     ^^^^
      |     |
      |     required by a bound introduced by this call
      |
      = note: cannot satisfy `_: From<Bar>`
    note: required by a bound in `qux`
     --> f100.rs:6:16
      |
    6 | fn qux(_: impl From<Bar>) {}
      |                ^^^^^^^^^ required by this bound in `qux`
    help: try using a fully qualified path to specify the expected types
      |
    8 |     qux(<Bar as Into<T>>::into(Bar));
      |         +++++++++++++++++++++++   ~
    help: consider removing this method call, as the receiver has type `Bar` and `Bar: From<Bar>` trivially holds
      |
    8 -     qux(Bar.into());
    8 +     qux(Bar);
      |
    ```
    
    Fix rust-lang#71252
    CKingX committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    72997ad View commit details
    Browse the repository at this point in the history