Rollup of 7 pull requests #121271
Merged
Rollup of 7 pull requests #121271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows and UEFI this improves performance and error messaging. On other platforms we optimize the fast path a bit more. This also prepares for later relaxing the checks on certain platforms.
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Also replaces an incomplete test
To help remind forgetful people like me what step they forgot.
and move its content to const_prop_lint.rs and dataflow_const_prop.rs where it is used
…ark-Simulacrum Move `OsStr::slice_encoded_bytes` validation to platform modules This delegates OS string slicing (`OsStr::slice_encoded_bytes`) validation to the underlying platform implementation. For now that results in increased performance and better error messages on Windows without any changes to semantics. In the future we may want to provide different semantics for different platforms. The existing implementation is still used on Unix and most other platforms and is now optimized a little better. Tracking issue: rust-lang#118485 cc `@epage,` `@BurntSushi`
… r=fmease make "invalid fragment specifier" translatable
…g, r=Mark-Simulacrum Remove unnecessary unit binding It appears that the unit binding is not necessary at this time. However, I am unsure of its importance in the past. Please let me know if it is unsafe to remove.
…rochenkov Add help to `hir_analysis_unrecognized_intrinsic_function` To help remind forgetful people like me what step they forgot. (If this just ICE'd, rust-lang/compiler-team#620 style, the stack trace would point me here, but since there's a "nice" error that information is lost.)
…crum remove extraneous text from example config
…i-obk Remove const_prop.rs Removed const_prop.rs and moved its contents to const_prop_lint.rs and dataflow_const_prop.rs where they are used. const_prop.rs does not actually do any const propagation any more. After rust-lang#116012 all it contains is code that is used by const_prop_lint.rs and one macro that is used by dataflow_const_prop.rs. So it made sense to just move it to those two places and remove this file.
…, r=Mark-Simulacrum Add uncontroversial syscall doc aliases to std docs This PR contains the parts of rust-lang#113891 that don’t break the doc alias policy. r? `@Mark-Simulacrum`
rustbot
added
O-wasi
|
@bors r+ rollup=never p=7 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: c9c83cca51 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Nilstrieb
pushed a commit
to Nilstrieb/rust
that referenced
this pull request
Feb 18, 2024
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#118569 (Move `OsStr::slice_encoded_bytes` validation to platform modules) - rust-lang#121067 (make "invalid fragment specifier" translatable) - rust-lang#121224 (Remove unnecessary unit binding) - rust-lang#121247 (Add help to `hir_analysis_unrecognized_intrinsic_function`) - rust-lang#121257 (remove extraneous text from example config) - rust-lang#121260 (Remove const_prop.rs) - rust-lang#121266 (Add uncontroversial syscall doc aliases to std docs) r? `@ghost` `@rustbot` modify labels: rollup
|
Finished benchmarking commit (8a49772): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 641.367s -> 640.58s (-0.12%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
OsStr::slice_encoded_bytesvalidation to platform modules #118569 (MoveOsStr::slice_encoded_bytesvalidation to platform modules)hir_analysis_unrecognized_intrinsic_function#121247 (Add help tohir_analysis_unrecognized_intrinsic_function)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup